Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0034148 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | have not tried | 2016-09-30 13:30 | 2016-10-24 09:37 | |||
| Reporter | adrianromero | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR17Q1 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | b8709e58401b | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | OBPS | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0034148: [SER QA 1820] Closing layaway fails if the preference Save Removed tickets is activated | |||||||
| Description | If The preference Web POS Save Removed Tickets is activated then closing a layaway that has been loaded from the backend is sent to the server and an exception is thrown. Actually it does not save inconsistent data because the order loader fails when the POS tries to sent incorrectly a layaway to be saved as deleted. | |||||||
| Steps To Reproduce | * Set the preference Web POS Save Removed Tickets to 'Y' * Create a layaway and process it without any payment * Go to the menu option "Layaways" and select the layaway created * Tap on the button "X" and close the layaway Observe in the Openbravo logs the exception raised: java.lang.NullPointerException at org.openbravo.retail.posterminal.UpdateCashup.getAndUpdateCashUp(UpdateCashup.java:90) at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:209) at org.openbravo.mobile.core.process.DataSynchronizationProcess.saveRecord(DataSynchronizationProcess.java:198) at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:155) at org.openbravo.mobile.core.process.DataSynchronizationProcess.exec(DataSynchronizationProcess.java:87) at org.openbravo.mobile.core.process.MobileImportEntryProcessorRunnable.processEntry(MobileImportEntryProcessorRunnable.java:42) at org.openbravo.retail.posterminal.importprocess.OrderImportEntryProcessor$OrderLoaderRunnable.processEntry(OrderImportEntryProcessor.java:58) at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.doRunCycle(ImportEntryProcessor.java:369) at org.openbravo.service.importprocess.ImportEntryProcessor$ImportEntryProcessRunnable.run(ImportEntryProcessor.java:291) at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511) at java.util.concurrent.FutureTask.run(FutureTask.java:266) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:745) | |||||||
| Proposed Solution | Tapping on "X" to close the loaded layaway does not have to send the document to the server side, just remove it form the editing documents in the Web POS. The proposed patch just does this. if the ticket is not editable the preference to save deleted tickets is not checked. | |||||||
| Tags | SER-QA | |||||||
| Attached Files |  Issue1820_LayawayCloseIssue.patch [^] (1,157 bytes) 2016-10-04 09:19 [Show Content]
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0090575) hgbot (developer) 2016-10-14 09:25 |
Repository: tools/automation/pi-mobile Changeset: d6b206536e43ad6cfeff30528793eeef1616b7b9 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Fri Oct 14 12:50:15 2016 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/d6b206536e43ad6cfeff30528793eeef1616b7b9 [^] Verifies issue 34148 : Added automated test 'I34148_VerifyPrefSaveRemovedTicket' --- A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I34148_VerifyPrefSaveRemovedTicket.java --- |
|
(0090576) hgbot (developer) 2016-10-14 09:26 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: b8709e58401bff9661f99cda4320c92c303b89f3 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Fri Oct 14 12:50:39 2016 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b8709e58401bff9661f99cda4320c92c303b89f3 [^] Fixes issue 34148 : Preference "Save Removed tickets" should work if the receipt is editable --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
(0090765) marvintm (viewer) 2016-10-21 13:06 |
The change can be slightly simpler: instead of adding yet another condition to the removeOrder function, it would be better just not to call the function if the order is not editable. In this way, the code would be easier to understand. |
|
(0090803) marvintm (viewer) 2016-10-24 09:36 |
Finally it has been decided that the current change is correct, as there are several things (such as removing the order from the list) that need to happen even if the order is not editable. |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-09-30 13:30 | adrianromero | New Issue | |
| 2016-09-30 13:30 | adrianromero | Assigned To | => prakashmurugesan88 |
| 2016-09-30 13:30 | adrianromero | OBNetwork customer | => Yes |
| 2016-09-30 13:30 | adrianromero | Triggers an Emergency Pack | => No |
| 2016-09-30 13:48 | adrianromero | Summary | Closing layaway fails if the preference Save Removed tickets is activated => [SER QA 1820] Closing layaway fails if the preference Save Removed tickets is activated |
| 2016-10-04 09:17 | adrianromero | Tag Attached: SER-QA | |
| 2016-10-04 09:19 | adrianromero | Resolution time | => 1476741600 |
| 2016-10-04 09:19 | adrianromero | Proposed Solution updated | |
| 2016-10-04 09:19 | adrianromero | File Added: Issue1820_LayawayCloseIssue.patch | |
| 2016-10-04 09:21 | adrianromero | Description Updated | View Revisions |
| 2016-10-04 09:22 | adrianromero | Assigned To | prakashmurugesan88 => Retail |
| 2016-10-04 09:45 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2016-10-04 09:47 | ranjith_qualiantech_com | Status | new => scheduled |
| 2016-10-14 09:25 | hgbot | Checkin | |
| 2016-10-14 09:25 | hgbot | Note Added: 0090575 | |
| 2016-10-14 09:26 | hgbot | Checkin | |
| 2016-10-14 09:26 | hgbot | Note Added: 0090576 | |
| 2016-10-14 09:26 | hgbot | Status | scheduled => resolved |
| 2016-10-14 09:26 | hgbot | Resolution | open => fixed |
| 2016-10-14 09:26 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b8709e58401bff9661f99cda4320c92c303b89f3 [^] |
| 2016-10-21 13:06 | marvintm | Note Added: 0090765 | |
| 2016-10-24 09:36 | marvintm | Note Added: 0090803 | |
| 2016-10-24 09:37 | marvintm | Review Assigned To | => marvintm |
| 2016-10-24 09:37 | marvintm | Status | resolved => closed |
| 2016-10-24 09:37 | marvintm | Fixed in Version | => RR17Q1 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |