Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0033954
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersmajoralways2016-09-12 17:332016-10-05 19:35
ReportermaiteView Statuspublic 
Assigned Tomarkmm82 
PriorityurgentResolutionfixedFixed in Version3.0PR16Q4
StatusclosedFix in branchFixed in SCM revisiona3c2fb154a29
ProjectionnoneETAnoneTarget Version3.0PR17Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesAdvanced Payables and Receivables Mngmt
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033954: Erroneous reconciliation's balance when reactivating and deleting "intermediate" reconciliation document

DescriptionOnce a non-last reconciliation is reactivated and deleted, balance for next reconciliations needs to be recalculated
Steps To Reproduce1. Access Financial Account "Cuenta de Banco" and reactivate non-last reconciliation
2. Run "Match Statement" process, select "Cancel" option for automatching and unmatch all lines
3. Access Reconciliations tab, verify that reconciliation has no items and delete it
4. Realize that starting balance of subsequent reconciliations has not been updated when it should
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0090358)
markmm82 (developer)
2016-09-28 21:32

Test Plan
1. Access Financial Account "Cuenta de Banco".
2. Go to Reconciliations tab.
3. Select a non-last reconciliation and Reactivate it.
4. Run "Match Transactions Force" process, select "Cancel" option for automatching and unmatch all lines
5. Access Reconciliations tab, verify that reconciliation has no items and delete it.
6. Realize that starting balance of subsequent reconciliations has been updated correctly.
(0090421)
hgbot (developer)
2016-09-30 12:43

Repository: erp/devel/pi
Changeset: a3c2fb154a29a54f46d66f73143f5126a70214ad
Author: Mark <markmm82 <at> gmail.com>
Date: Thu Sep 29 19:46:04 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/a3c2fb154a29a54f46d66f73143f5126a70214ad [^]

Fixes issue 33954: Recalculated next reconciliation's balance after deletion

Once a non-last reconciliation is reactivated and deleted, balance for next reconciliations have been recalculated.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/triggers/APRM_FIN_RECON_CHECK_TRG.xml
---
(0090422)
hgbot (developer)
2016-09-30 12:43

Repository: erp/devel/pi
Changeset: ed8fb0de3b970164d4ef234a0a50da194cc2efbc
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 30 09:57:00 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/ed8fb0de3b970164d4ef234a0a50da194cc2efbc [^]

Related to issue 33954: Code review improvements

Avoid loop and do the update with just one query.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/triggers/APRM_FIN_RECON_CHECK_TRG.xml
---
(0090436)
hgbot (developer)
2016-09-30 14:36

Repository: erp/devel/pi
Changeset: 3f4dc99dd5bee7a95e4d47cb89abf6b5507d0e93
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Sep 30 14:35:09 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/3f4dc99dd5bee7a95e4d47cb89abf6b5507d0e93 [^]

Related to issue 33954: Fix trigger in Oracle

Event handler has been created in order to update subsequent reconciliations balances when a reconciliation is deleted, instead of doing it in FIN_Reconciliation trigger.

---
M modules/org.openbravo.advpaymentmngt/src-db/database/model/triggers/APRM_FIN_RECON_CHECK_TRG.xml
A modules/org.openbravo.advpaymentmngt/src/org/openbravo/advpaymentmngt/event/FIN_ReconciliationEventListener.java
---
(0090437)
aferraz (manager)
2016-09-30 14:36

Code review + Testing OK
(0090446)
hudsonbot (developer)
2016-09-30 19:07

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/538700cbd709 [^]
Maturity status: Test
(0090447)
hudsonbot (developer)
2016-09-30 19:07

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/538700cbd709 [^]
Maturity status: Test
(0090503)
hudsonbot (developer)
2016-10-05 19:35

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9f948cce366c [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-09-12 17:33 maite New Issue
2016-09-12 17:33 maite Assigned To => Triage Finance
2016-09-12 17:33 maite Modules => Advanced Payables and Receivables Mngmt
2016-09-12 17:33 maite Resolution time => 1475445600
2016-09-12 17:33 maite Triggers an Emergency Pack => No
2016-09-12 17:34 maite Issue Monitored: networkb
2016-09-15 11:11 aferraz Assigned To Triage Finance => AtulOpenbravo
2016-09-21 15:31 aferraz Assigned To AtulOpenbravo => markmm82
2016-09-26 17:53 markmm82 Status new => scheduled
2016-09-28 21:32 markmm82 Note Added: 0090358
2016-09-30 12:43 hgbot Checkin
2016-09-30 12:43 hgbot Note Added: 0090421
2016-09-30 12:43 hgbot Status scheduled => resolved
2016-09-30 12:43 hgbot Resolution open => fixed
2016-09-30 12:43 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a3c2fb154a29a54f46d66f73143f5126a70214ad [^]
2016-09-30 12:43 hgbot Checkin
2016-09-30 12:43 hgbot Note Added: 0090422
2016-09-30 12:45 aferraz Review Assigned To => aferraz
2016-09-30 12:45 aferraz Note Added: 0090424
2016-09-30 12:45 aferraz Status resolved => closed
2016-09-30 12:45 aferraz Fixed in Version => 3.0PR16Q4
2016-09-30 14:36 hgbot Checkin
2016-09-30 14:36 hgbot Note Added: 0090436
2016-09-30 14:36 aferraz Note Deleted: 0090424
2016-09-30 14:36 aferraz Note Added: 0090437
2016-09-30 19:07 hudsonbot Checkin
2016-09-30 19:07 hudsonbot Note Added: 0090446
2016-09-30 19:07 hudsonbot Checkin
2016-09-30 19:07 hudsonbot Note Added: 0090447
2016-10-05 19:35 hudsonbot Checkin
2016-10-05 19:35 hudsonbot Note Added: 0090503


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker