Anonymous | Login
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Openbravo ERP] A. Platformminorhave not tried2016-08-24 11:412016-08-29 15:13
ReportershuehnerView Statuspublic 
Assigned Toaferraz 
PrioritynormalResolutionfixedFixed in Version3.0PR16Q2.3
StatusclosedFix in branchFixed in SCM revisionf4d5cad9480c
ProjectionnoneETAnoneTarget Version3.0PR16Q2.3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo

0033812: Accidental double query in PriceListVersionFilterExpressionName (order lines, product selector dropdown)

DescriptionThat class has double query m_pricelist_version and also is missing a limit 1 so could lead to high mem usage.

Note: Code seems to be very similar or identical to the change reported in issue 33705
Steps To Reproducewith debugging code from [^]

Open Sales Order
create new header
In lines tab
Create new record in grid view
Click on product selector drop down and see debugging code fire
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0033790 closedshuehner Accidental double query in PriceListVersionFilterExpressionName (order lines, product selector dropdown) 

-  Notes
hgbot (developer)
2016-08-29 14:20

Repository: erp/backports/3.0PR16Q2.3
Changeset: f4d5cad9480cbfca055032ab1f86d7ff4e7e310f
Author: Alvaro Ferraz <alvaro.ferraz <at>>
Date: Thu Aug 25 15:16:24 2016 +0200
URL: [^]

Fixed 33812. Avoid double query with .count() + .list(). Add limit 1 to query

Query did .count() + then retrieve 1 record after adding extra order by.

This change removes the count as it only adds extra overhead and directly
does the real .list() query.
As the code only uses single row of result add extra limit 1 to reduce
number of result rows loaded into memory if many match the filter.
Simply code to use .uniqueResult() instead of .list().get(0)

M src/org/openbravo/erpCommon/info/
caristu (developer)
2016-08-29 15:13

Code reviewed

- Issue History
Date Modified Username Field Change
2016-08-25 14:25 aferraz Type defect => backport
2016-08-25 14:25 aferraz Target Version => 3.0PR16Q2.3
2016-08-29 13:09 aferraz Assigned To shuehner => aferraz
2016-08-29 14:20 hgbot Checkin
2016-08-29 14:20 hgbot Note Added: 0089498
2016-08-29 14:20 hgbot Status scheduled => resolved
2016-08-29 14:20 hgbot Resolution open => fixed
2016-08-29 14:20 hgbot Fixed in SCM revision [^] => [^]
2016-08-29 15:13 caristu Note Added: 0089506
2016-08-29 15:13 caristu Status resolved => closed
2016-08-29 15:13 caristu Fixed in Version => 3.0PR16Q2.3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker