Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033787
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2016-08-24 10:252016-09-23 18:22
ReporterNaroaIriarteView Statuspublic 
Assigned ToNaroaIriarte 
PrioritynormalResolutionfixedFixed in Version3.0PR16Q4
StatusclosedFix in branchFixed in SCM revision38d87f5ca8e1
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033787: Some PL functions need to be properly deleted and reviewed

DescriptionThe hex_to_int is_trigger_enabled functions are not deleted when an update.database is done, it would be nice to do it this way.
The instr function is showing a warning: warning:00000:6:DECLARE:unused variable "i".

This should be fixed also.
Steps To Reproduce.
Proposed SolutionFor the hex_to_int and is_trigger_enabled functions: drop the functions if they exist in the postscript-Oracle.sql and prescript-PostgreSql.sql classes.
For the instr function, remove the unused i variable.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0032932 closedNaroaIriarte There are a lot of warnings in the application that should be fixed 

-  Notes
(0089442)
NaroaIriarte (developer)
2016-08-26 12:10

 The "hex_to_int" and "is_trigger_enabled" functions are kept in the excludeFilter.xml because they are needed to avoid the following errors when executing ant update.database:


[java] Error reading default values for parameters in function hex_to_int (pattern not found)
...

[java] java.lang.NullPointerException
     [java] at org.apache.ddlutils.model.Parameter.getName(Parameter.java:53)
     [java] at org.apache.ddlutils.platform.postgresql.PostgreSqlBuilder.writeParameter(PostgreSqlBuilder.java:476)
     [java] at org.apache.ddlutils.platform.postgresql.PostgreSqlBuilder.writeDropFunctionStmt(PostgreSqlBuilder.java:316)
     [java] at org.apache.ddlutils.platform.SqlBuilder.dropFunction(SqlBuilder.java:4040)
     [java] at org.apache.ddlutils.platform.postgresql.PostgreSqlBuilder.dropFunction(PostgreSqlBuilder.java:466)
     [java] at org.apache.ddlutils.platform.SqlBuilder.processChange(SqlBuilder.java:1336)
     ...
(0090152)
hgbot (developer)
2016-09-22 10:41

 Repository: erp/devel/pi
Changeset: 38d87f5ca8e1016f21cda73371157e8f5ba39d7c
Author: Naroa Iriarte <naroa.iriarte <at> openbravo.com>
Date: Thu Sep 22 10:40:12 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/38d87f5ca8e1016f21cda73371157e8f5ba39d7c [^]

Fixed issue 33787: Some PL functions needed to be properly removed

The hex_to_int and is_trigger_enabled functions were not properly removed, it was neccessary to do an install.source to have them properly removed. Now these functios are removed if they exist when an update is done.

---
M src-db/database/model/postscript-Oracle.sql
M src-db/database/model/prescript-PostgreSql.sql
---
(0090179)
alostale (manager)
2016-09-23 08:16

 code reviewed

tested in oracle and pg:

1. When updating from an old version when those functions are present, they get properly removed on update
2. When updating from a newer version when those functions don't exist, there is no error
(0090214)
hudsonbot (developer)
2016-09-23 18:22

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/25f7de2ab346 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-08-24 10:25 NaroaIriarte New Issue
2016-08-24 10:25 NaroaIriarte Assigned To => NaroaIriarte
2016-08-24 10:25 NaroaIriarte Modules => Core
2016-08-24 10:25 NaroaIriarte Triggers an Emergency Pack => No
2016-08-24 10:26 NaroaIriarte Relationship added related to 0032932
2016-08-24 10:26 NaroaIriarte Review Assigned To => alostale
2016-08-24 10:26 NaroaIriarte Status new => acknowledged
2016-08-24 10:27 NaroaIriarte Status acknowledged => scheduled
2016-08-26 12:10 NaroaIriarte Note Added: 0089442
2016-09-22 10:41 hgbot Checkin
2016-09-22 10:41 hgbot Note Added: 0090152
2016-09-22 10:41 hgbot Status scheduled => resolved
2016-09-22 10:41 hgbot Resolution open => fixed
2016-09-22 10:41 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/38d87f5ca8e1016f21cda73371157e8f5ba39d7c [^]
2016-09-23 08:16 alostale Note Added: 0090179
2016-09-23 08:16 alostale Status resolved => closed
2016-09-23 08:16 alostale Fixed in Version => 3.0PR16Q4
2016-09-23 18:22 hudsonbot Checkin
2016-09-23 18:22 hudsonbot Note Added: 0090214

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker