0033770: ModuleManagement install from local obx triggers accidental 4* load of ad_module_dependency

Description

The flow of installing packs from local obx file looks for ad_module_dependency information in the local database.

That code calls .list() 4 times on the same OBCriteria instances running the sql query 4 times which should be avoided.

Steps To Reproduce

Use debugging code from:
https://issues.openbravo.com/view.php?id=33767 [^]

And follow flow of ci job int-dummy-pgsql.

Following local hack is sufficient to produce the issue.
Download latest org.openbravo.v3 module ci test obx from forge (i.e. minor version 29874
Edit local version to be 29874-1 for core module + org.openbravo.v3 module in database
run export.database to work around 'local changes' check in mmc
Now in MMC install from local file pointing to downloaded v3 obx

Observe the extra .list() calls with the debugging code mentioned above.

Tags

Performance

Attached Files

33770.diff [^] (1,257 bytes) 2016-08-23 17:03 [Show Content] [Hide Content]

diff -r d55a930e5875 src/org/openbravo/erpCommon/modules/ImportModule.java
--- a/src/org/openbravo/erpCommon/modules/ImportModule.java	Tue Aug 23 16:42:13 2016 +0200
+++ b/src/org/openbravo/erpCommon/modules/ImportModule.java	Tue Aug 23 17:03:41 2016 +0200
@@ -1175,10 +1175,12 @@
               org.openbravo.model.ad.module.ModuleDependency.PROPERTY_DEPENDENTMODULE + ".id",
               modId));
           String enforcement = null;
-          if (!qDependentMod.list().isEmpty()
-              && qDependentMod.list().get(0).isUserEditableEnforcement()
-              && qDependentMod.list().get(0).getInstanceEnforcement() != null) {
-            enforcement = qDependentMod.list().get(0).getInstanceEnforcement();
+          qDependentMod.setMaxResults(1);
+          org.openbravo.model.ad.module.ModuleDependency dependentMod = (org.openbravo.model.ad.module.ModuleDependency) qDependentMod
+              .uniqueResult();
+          if (dependentMod != null && dependentMod.isUserEditableEnforcement()
+              && dependentMod.getInstanceEnforcement() != null) {
+            enforcement = dependentMod.getInstanceEnforcement();
           } else {
             enforcement = (String) dynModule.get("DEPENDENCY_ENFORCEMENT");
           }

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

feature request

0033767

closed

platform

Add code to auto-detect 'accidental double query' on same OBQuery or OBCriteria object

Notes
(0089314) shuehner (administrator) 2016-08-23 17:03	Extra notes: - There is no unique constraint in db on the combination of filters used in the query - No limit is set in the query - no ordering is set in the query - but code only uses .get(0) result So assuming multiple result rows for that filter are possible the result is undefined (random ordering as per sql spec when not specifying order by in the query)

Issue History
Date Modified	Username	Field	Change
2016-08-23 17:01	shuehner	New Issue
2016-08-23 17:01	shuehner	Assigned To	=> platform
2016-08-23 17:01	shuehner	Modules	=> Core
2016-08-23 17:01	shuehner	Triggers an Emergency Pack	=> No
2016-08-23 17:03	shuehner	Note Added: 0089314
2016-08-23 17:03	shuehner	Relationship added	related to 0033767
2016-08-23 17:03	shuehner	File Added: 33770.diff
2016-08-23 17:10	shuehner	Tag Attached: Performance
2016-08-29 09:20	alostale	Status	new => acknowledged
2016-12-01 14:05	alostale	Priority	normal => urgent
2016-12-01 14:05	alostale	Priority	urgent => high
2022-02-01 08:05	alostale	Assigned To	platform => Triage Platform Base