Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0033702
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajorhave not tried2016-08-12 09:552016-08-18 13:35
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in VersionRR16Q2.2
StatusclosedFix in branchFixed in SCM revision0eadefd4c5c3
ProjectionnoneETAnoneTarget VersionRR16Q2.2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033702: NPE in POSImportEntryProcessor when the posterminal json property has an illegal value

DescriptionSee stacktrace [1], this causes the import entry from not being saved at all. Change the code [2] to set the status to error and a warning messages.

[1]
Caused by: org.openbravo.base.exception.OBException: java.lang.NullPointerException
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.createImportEntry(DataSynchronizationProcess.java:89)
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.executeCreateImportEntry(DataSynchronizationProcess.java:115)
        ... 41 more
Caused by: java.lang.NullPointerException
        at org.openbravo.retail.posterminal.importprocess.POSImportEntryProcessor.onSave(POSImportEntryProcessor.java:79)
        at sun.reflect.GeneratedMethodAccessor445.invoke(Unknown Source)

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/060b566c4098/src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java [^]
Steps To ReproduceRun retail
Put breakpoint in java code in POSImportEntryProcessor
Login to webpos
Do some actions
At breakpoint change the json to set the posTerminalId to the value "null" (note use the string value "null" so not NULL or null)
Proposed Solutionlog warning
set status to Error if no posterminal can be found
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0033696RR16Q4 closedmtaal NPE in POSImportEntryProcessor when the posterminal json property has an illegal value 

-  Notes
(0089101)
hgbot (developer)
2016-08-15 19:39

Repository: retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal
Changeset: 0eadefd4c5c3e835e70a2873c04b6615e871509a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Aug 15 19:39:08 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal/rev/0eadefd4c5c3e835e70a2873c04b6615e871509a [^]

Fixes issue 33702: NPE in POSImportEntryProcessor when the posterminal json property has an illegal value
If no posterminal id can be found then still create the import entry but with status error.
Also use static finals were appropriate.
The changeset for issue 33555 has been included in the commit as it seemed better to keep than to rework the
code to a new version.

---
M src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java
---

- Issue History
Date Modified Username Field Change
2016-08-12 12:46 Orekaria Type defect => backport
2016-08-12 12:46 Orekaria Target Version RR16Q4 => RR16Q2.2
2016-08-15 19:39 hgbot Checkin
2016-08-15 19:39 hgbot Note Added: 0089101
2016-08-15 19:39 hgbot Status scheduled => resolved
2016-08-15 19:39 hgbot Resolution open => fixed
2016-08-15 19:39 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/77435e4a7b40ba41925cf9d53712db38b242675c [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal/rev/0eadefd4c5c3e835e70a2873c04b6615e871509a [^]
2016-08-18 13:35 guilleaer Status resolved => closed
2016-08-18 13:35 guilleaer Fixed in Version => RR16Q2.2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker