Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033671
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-08-10 10:392016-08-26 16:55
ReportervmromanosView Statuspublic 
Assigned Tomario_castello 
PriorityimmediateResolutionfixedFixed in VersionRR16Q4
StatusclosedFix in branchFixed in SCM revision0b8451075de8
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033671: FIN_PaymentScheduleDetail created from POS doesn't include the Business Partner

DescriptionThe FIN_PaymentScheduleDetail created from POS doesn't include the Business Partner.

The ERP always sets the business partner information when creating the PSD from an invoice or an order (through extension points on C_Invoice_Post and C_Order_Post). However the POS doesn't fill it.

When the order is directly paid from the POS there is no problem. However, credit orders generated from POS couldn't be paid in the ERP after fixing 0033629, because that fix requires to have the Business Partner information.
Steps To Reproduce1. Create and pay and order in POS
2. Go to the ERP and search for the associated payment (Sales Order | Payment Plan | Payment Details, and browse to the Payment In window)
3. Inside the Payment In window, go to Lines tab and verify Business Partner field is empty. It should have the order's business partner
Proposed SolutionModify OrderLoader
Ensure created PSD has set the business partner:
paymentScheduleDetail.setBusinessPartner(order.getBusinessPartner());

Wrong data PSD should be updated. You can reuse module script UpdateBpPaymentLine.
It's recommended to modify the update queries to filter by isinvoicepaid = 'N', so it performs faster:

update fin_payment_scheduledetail psd
set c_bpartner_id = (select c_bpartner_id from c_invoice i, fin_payment_schedule ps
                     where ps.fin_payment_schedule_id = fin_payment_schedule_invoice
                     and ps.c_invoice_id = i.c_invoice_id)
where c_bpartner_id is null and fin_payment_schedule_invoice is not null and isinvoicepaid = 'N';


update fin_payment_scheduledetail psd
set c_bpartner_id = (select c_bpartner_id from c_order o, fin_payment_schedule ps
                                                     where ps.fin_payment_schedule_id = fin_payment_schedule_order
                                                     and ps.c_order_id = o.c_order_id)
where c_bpartner_id is null and fin_payment_schedule_order is not null
and fin_payment_schedule_invoice is null and isinvoicepaid = 'N';
TagsNo tags attached.
Attached Filespatch file icon Issue_33671.patch [^] (1,875 bytes) 2016-08-10 11:46 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0033675RR16Q3.1 closedmario_castello Retail Modules FIN_PaymentScheduleDetail created from POS doesn't include the Business Partner 
depends on backport 0033676RR16Q2.2 closedRetail Retail Modules FIN_PaymentScheduleDetail created from POS doesn't include the Business Partner 
related to defect 0033744RR16Q4 closedmario_castello Retail Modules Module script required to fix wrong data created by 33671 
related to defect 0033776 closedSanjota Openbravo ERP Business partner being null in Payment scheduledetails 
blocks defect 0033629 closedalostale Openbravo ERP slow order/invoice grid population in Add Payment 

-  Notes
(0089217)
hgbot (developer)
2016-08-18 16:29

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 5f2056b6faf440501a4ae97a68e7b1268ccdb006
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Aug 17 09:16:59 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5f2056b6faf440501a4ae97a68e7b1268ccdb006 [^]

Fixed issue 33671: Added Business Partner for FIN_PaymentScheduleDetail for Orders created from POS

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0089306)
guilleaer (manager)
2016-08-23 15:15

 Test pending.

Maybe we not need to create a new test, just use one test which already exists in the system and add this new check to it
(0089360)
hgbot (developer)
2016-08-24 16:15

 Repository: tools/automation/pi-mobile
Changeset: 0b8451075de8c93507136a9b03668864db980536
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Aug 23 09:55:00 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0b8451075de8c93507136a9b03668864db980536 [^]

Fixed issue 33671: Added changes in test I31471_PayLayawayAlreadyInvoiced to verify the information of Business Partner

---
M src-test/org/openbravo/test/mobile/common/selenium/database/WebPOSDatabaseHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31471_PayLayawayAlreadyInvoiced.java
---
(0089361)
hgbot (developer)
2016-08-24 16:16

 Repository: tools/automation/pi-mobile
Changeset: 7db9d8d6400f5208dfaf0a158c2e4cde1cc1366a
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Aug 23 10:41:03 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/7db9d8d6400f5208dfaf0a158c2e4cde1cc1366a [^]

Related to issue 33671: Added new function to verify the information of payment shedule detail

---
M src-test/org/openbravo/test/mobile/common/selenium/database/WebPOSDatabaseHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31471_PayLayawayAlreadyInvoiced.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/I31137_Sale.java
---
(0089470)
hgbot (developer)
2016-08-26 16:55

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d17d71adc6675b313a246d23180a85017d431906
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Aug 25 22:11:51 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d17d71adc6675b313a246d23180a85017d431906 [^]

Fixed issue 33744: Added new module script to fix data refer to issue 33671

---
A build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744.class
A build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744Data.class
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744.java
A src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue33744_Data.xsql
---

- Issue History
Date Modified Username Field Change
2016-08-10 10:39 vmromanos New Issue
2016-08-10 10:39 vmromanos Assigned To => Retail
2016-08-10 10:39 vmromanos Triggers an Emergency Pack => No
2016-08-10 10:39 vmromanos Relationship added blocks 0033629
2016-08-10 10:43 vmromanos Steps to Reproduce Updated View Revisions
2016-08-10 10:43 vmromanos Proposed Solution updated
2016-08-10 11:09 Orekaria Status new => scheduled
2016-08-10 11:46 simbu94 File Added: Issue_33671.patch
2016-08-11 11:47 Orekaria Status scheduled => resolved
2016-08-11 11:47 Orekaria Resolution open => fixed
2016-08-11 11:47 Orekaria Status resolved => new
2016-08-11 11:47 Orekaria Resolution fixed => open
2016-08-12 12:44 migueldejuana Assigned To Retail => Orekaria
2016-08-17 08:24 guilleaer Assigned To Orekaria => mario_castello
2016-08-17 14:34 mario_castello Status new => acknowledged
2016-08-17 17:20 mario_castello Status acknowledged => scheduled
2016-08-18 16:29 hgbot Checkin
2016-08-18 16:29 hgbot Note Added: 0089217
2016-08-18 16:29 hgbot Status scheduled => resolved
2016-08-18 16:29 hgbot Resolution open => fixed
2016-08-18 16:29 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5f2056b6faf440501a4ae97a68e7b1268ccdb006 [^]
2016-08-18 17:30 guilleaer Relationship added related to 0033744
2016-08-23 15:15 guilleaer Note Added: 0089306
2016-08-23 15:15 guilleaer Status resolved => new
2016-08-23 15:15 guilleaer Resolution fixed => open
2016-08-23 15:15 guilleaer Status new => scheduled
2016-08-24 16:15 hgbot Checkin
2016-08-24 16:15 hgbot Note Added: 0089360
2016-08-24 16:15 hgbot Status scheduled => resolved
2016-08-24 16:15 hgbot Resolution open => fixed
2016-08-24 16:15 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5f2056b6faf440501a4ae97a68e7b1268ccdb006 [^] => http://code.openbravo.com/tools/automation/pi-mobile/rev/0b8451075de8c93507136a9b03668864db980536 [^]
2016-08-24 16:16 hgbot Checkin
2016-08-24 16:16 hgbot Note Added: 0089361
2016-08-25 08:44 guilleaer Review Assigned To => guilleaer
2016-08-25 08:44 guilleaer Status resolved => closed
2016-08-25 08:44 guilleaer Fixed in Version => RR16Q4
2016-08-26 16:55 hgbot Checkin
2016-08-26 16:55 hgbot Note Added: 0089470
2017-07-13 11:12 ngarcia Relationship added related to 0033776

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker