0033645: Storeserver automated test show that sometimes additional mobile servers are available to the webpos client

Description

The store server multi-server tests ([1]) have 2 stores defined store1 and store2. Store2 is for the CMS terminals, store1 for the VBS terminals. The tests only use the VBS terminals. Still it seems that store2 url is being operated resulting in errors in the log ([2]).

[1]
https://ci.openbravo.com/view/storeserver [^]

[2]
https://ci.openbravo.com/view/storeserver/job/ret-ms-store-pgsql/lastCompletedBuild/testReport/org.openbravo.test.mobile.retail.multiserver.selenium.tests/MS001_SalesFlow/test/ [^]

Steps To Reproduce

Run multi-server tests on the ci environment.

It was not reproducable locally. Assumption is that there is some race condition which can't be replicated.

Proposed Solution

Prevent wrong servers from being send to the client in all cases.

Tags

No tags attached.

Attached Files

33645.diff [^] (944 bytes) 2016-08-07 13:49 [Show Content] [Hide Content]

diff --git a/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java b/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java
--- a/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java
+++ b/src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java
@@ -239,19 +239,6 @@
 
   protected JSONArray getServers() throws JSONException {
     JSONArray respArray = new JSONArray();
-
-    if (!MobileServerUtils.isMultiServerEnabled()) {
-      return respArray;
-    }
-
-    OBQuery<MobileServerDefinition> servers = OBDal.getInstance().createQuery(
-        MobileServerDefinition.class, " order by " + MobileServerDefinition.PROPERTY_PRIORITY);
-    servers.setFilterOnReadableClients(false);
-    servers.setFilterOnReadableOrganization(false);
-    for (MobileServerDefinition server : servers.list()) {
-      respArray.put(createServerJSON(server));
-    }
-
     return respArray;
   }

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0088891) hgbot (developer) 2016-08-08 14:00	Repository: erp/pmods/org.openbravo.mobile.core Changeset: 0c471e2db4f01306180c506ac39806842f0bdcc4 Author: Martin Taal <martin.taal <at> openbravo.com> Date: Mon Aug 08 14:00:03 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0c471e2db4f01306180c506ac39806842f0bdcc4 [^] Fixes issue 33645: Storeserver automated test show that sometimes additional mobile servers are available to the webpos client Do not send any servers to the client in generic level as we don't know the organization so can't select which servers to send --- M src/org/openbravo/mobile/core/login/MobileCoreLoginUtilsServlet.java ---

(0089075) Sandrahuguet (developer) 2016-08-12 09:08	reviewed and tested

Issue History
Date Modified	Username	Field	Change
2016-08-07 13:21	mtaal	New Issue
2016-08-07 13:21	mtaal	Assigned To	=> mtaal
2016-08-07 13:21	mtaal	Triggers an Emergency Pack	=> No
2016-08-07 13:49	mtaal	File Added: 33645.diff
2016-08-08 14:00	hgbot	Checkin
2016-08-08 14:00	hgbot	Note Added: 0088891
2016-08-08 14:00	hgbot	Status	new => resolved
2016-08-08 14:00	hgbot	Resolution	open => fixed
2016-08-08 14:00	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0c471e2db4f01306180c506ac39806842f0bdcc4 [^]
2016-08-08 14:00	mtaal	Review Assigned To	=> Sandrahuguet
2016-08-12 09:08	Sandrahuguet	Note Added: 0089075
2016-08-12 09:08	Sandrahuguet	Status	resolved => closed
2016-08-12 09:08	Sandrahuguet	Fixed in Version	=> RR16Q4