0033614: OrderLoader: Extra m_product read for every orderline related to services

Description

Since servoces project merge OrderLoader has following code

      if (jsonOrderLine.has("relatedLines")) {
        if ("S".equals(orderline.getProduct().getProductType())) {
          orderLineServiceList.put(orderline.getId(), jsonOrderLine.getJSONArray("relatedLines"));
        }
      }

Triggering extra m_product read to check product_type == "S".

However productType is sent with extra product in the json already so no reason to read it from database again.

Steps To Reproduce

Trace Sql's done by orderloader with an order using services

Tags

Performance

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

0039887

closed

ranjith_qualiantech_com

relatedLines json array expect different types for product key in ExternalOrderLoader and OrderLoader

Notes
(0089725) hgbot (developer) 2016-09-05 08:23	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 935d16e6e1c98df6458e423152492c838943fbcc Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Thu Sep 01 10:03:23 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/935d16e6e1c98df6458e423152492c838943fbcc [^] Fixed issue 33614 Extra m_product read in orderloader related to services --- M src/org/openbravo/retail/posterminal/OrderLoader.java ---

Issue History
Date Modified	Username	Field	Change
2016-08-03 14:12	shuehner	New Issue
2016-08-03 14:12	shuehner	Assigned To	=> Retail
2016-08-03 14:12	shuehner	Triggers an Emergency Pack	=> No
2016-08-03 14:12	shuehner	Tag Attached: Performance
2016-09-01 09:33	Sandrahuguet	Status	new => scheduled
2016-09-01 10:14	Sandrahuguet	Assigned To	Retail => Sandrahuguet
2016-09-05 08:23	hgbot	Checkin
2016-09-05 08:23	hgbot	Note Added: 0089725
2016-09-05 08:23	hgbot	Status	scheduled => resolved
2016-09-05 08:23	hgbot	Resolution	open => fixed
2016-09-05 08:23	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/935d16e6e1c98df6458e423152492c838943fbcc [^]
2016-09-05 08:43	Sandrahuguet	Review Assigned To	=> marvintm
2016-09-19 17:55	marvintm	Status	resolved => closed
2017-11-30 10:07	shuehner	Fixed in Version	=> RR16Q4
2019-01-09 10:32	gorkaion	Issue cloned	0039887
2019-01-09 10:32	gorkaion	Relationship added	related to 0039887