Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033614Retail ModulesWeb POSpublic2016-08-03 14:122019-01-09 10:32
Reportershuehner 
Assigned ToSandrahuguet 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033614: OrderLoader: Extra m_product read for every orderline related to services
DescriptionSince servoces project merge OrderLoader has following code

      if (jsonOrderLine.has("relatedLines")) {
        if ("S".equals(orderline.getProduct().getProductType())) {
          orderLineServiceList.put(orderline.getId(), jsonOrderLine.getJSONArray("relatedLines"));
        }
      }

Triggering extra m_product read to check product_type == "S".

However productType is sent with extra product in the json already so no reason to read it from database again.
Steps To ReproduceTrace Sql's done by orderloader with an order using services
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0039887 closed ranjith_qualiantech_com relatedLines json array expect different types for product key in ExternalOrderLoader and OrderLoader 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-08-03 14:12shuehnerNew Issue
2016-08-03 14:12shuehnerAssigned To => Retail
2016-08-03 14:12shuehnerTriggers an Emergency Pack => No
2016-08-03 14:12shuehnerTag Attached: Performance
2016-09-01 09:33SandrahuguetStatusnew => scheduled
2016-09-01 10:14SandrahuguetAssigned ToRetail => Sandrahuguet
2016-09-05 08:23hgbotCheckin
2016-09-05 08:23hgbotNote Added: 0089725
2016-09-05 08:23hgbotStatusscheduled => resolved
2016-09-05 08:23hgbotResolutionopen => fixed
2016-09-05 08:23hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/935d16e6e1c98df6458e423152492c838943fbcc [^]
2016-09-05 08:43SandrahuguetReview Assigned To => marvintm
2016-09-19 17:55marvintmStatusresolved => closed
2017-11-30 10:07shuehnerFixed in Version => RR16Q4
2019-01-09 10:32gorkaionIssue cloned0039887
2019-01-09 10:32gorkaionRelationship addedrelated to 0039887

Notes
(0089725)
hgbot   
2016-09-05 08:23   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 935d16e6e1c98df6458e423152492c838943fbcc
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Sep 01 10:03:23 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/935d16e6e1c98df6458e423152492c838943fbcc [^]

Fixed issue 33614 Extra m_product read in orderloader related to services

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---