Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0033489
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2016-07-15 14:432016-08-11 18:40
ReporterngarciaView Statuspublic 
Assigned Tomarkmm82 
PriorityurgentResolutionfixedFixed in Version3.0PR16Q4
StatusclosedFix in branchFixed in SCM revision6e46a5541bbd
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033489: Cannot post a cost adjustment if the period was created in a version previous to 3.0PR14Q4

DescriptionCannot post a cost adjustment if the period was created in a version previous to 3.0PR14Q4. Records in C_PERIODCONTROL tab are included when creating a record in the C_PERIOD table (C_PERIOD_TRG trigger) or when setting an organization as ready (AD_ORG_READY function). The CAD docbase type was included in 3.0PR14Q4
Steps To Reproduce   Install a version previous to 3.0PR14Q4
   Create the 2016 year and periods
   Upgrade the instance to any version after 3.0PR14Q4
   Create the Cost Adjustment document in case it does not exist
   Go to the last transaction of a product (Product - Transactions tab) and add a Manual Cost Adjusment
   Check a new record has been created in Cost Adjustment window
   Try to post it and check the following error message is shown:
      The Period does not exist or it is not opened
   Go to Open/Close Period Control and check the Cost Adjustment document category is not available for the current period (2016)
   Create a new year and its periods
   Check the Cost Adjustment document category is not available for that periods
TagsNo tags attached.
Attached Filesdiff file icon 33489.diff [^] (3,149 bytes) 2016-08-02 21:31 [Show Content]
? file icon CreateAccountingConfiguration.class [^] (3,499 bytes) 2016-08-02 21:32

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0088758)
markmm82 (developer)
2016-08-02 21:16
edited on: 2016-08-02 21:30

Test Plan
1. Install a version previous to 3.0PR14Q4, for instance 3.0PR14Q3.7
2. Create the 2016 year and periods
3. Go to Open/Close Period Control and check the "Cost Adjustment Document" category is NOT available for the current period (2016). That is because the Cost Adjustments feature was included in Openbravo 3.0PR14Q4.
4. Upgrade the instance to last on pi. Apply the patch with the solution of this issue (you can find it attached, be sure that .class is updated). It have updates to the module script to add the CAD document to the period when the instance is upgraded.
5. Run update.database and compile.complete tasks.
6. Cost Adjustments feature was included in Openbravo 3.0PR14Q4. That's why it is required to apply the new dataset to the corresponding organization. For example "F&B EspaƱa S.A".
7. Go to Open/Close Period Control window, select the 2016 period and check the "Cost Adjustment Document" category is now available for the current period (2016).
8. Open the periods.
9. Go to the Product window select "Cerveza Ale 0,5 L"
10. Go to "Transactions" tab and order by "Transaction Process Date" column in order to select the last transaction
11. Add a Manual Cost Adjusment to it.
   Total Cost Amount = 1000.00
   Accounting Date = today (for instance 18-07-2016)
   Incremental = YES
12. Check a new record has been created in Cost Adjustment window
13. Try to post it and check the process finish successfully!!! (A valid Conversion rate must be defined)

(0088914)
hgbot (developer)
2016-08-09 09:07

Repository: erp/devel/pi
Changeset: 6e46a5541bbdd5318f9bda7f25cded92e332094b
Author: Mark <markmm82 <at> gmail.com>
Date: Wed Aug 03 09:52:57 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/6e46a5541bbdd5318f9bda7f25cded92e332094b [^]

Fixes issue 33489: Can't post CAD if period was created previous to 3.0PR14Q4

Cost Adjustments feature was included in Openbravo 3.0PR14Q4, so periods created in lower versions doesn't includes the Cost Adjustment Document. When the instance is upgrated, these periods was not updated and it causes that CAD can't be posted. To include this document to all these periods was updated the CreateAccountingConfiguration module script to take into account control periods that has not included the CAD. Also was updated the Module Script Execution Limits to the 29718 version.

---
M modules/org.openbravo.advpaymentmngt/build/classes/org/openbravo/advpaymentmngt/modulescript/CreateAccountingConfiguration.class
M modules/org.openbravo.advpaymentmngt/src-util/modulescript/src/org/openbravo/advpaymentmngt/modulescript/CreateAccountingConfiguration.java
---
(0088915)
aferraz (manager)
2016-08-09 09:11

Code review + Testing OK
(0089049)
hudsonbot (developer)
2016-08-11 18:40

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-07-15 14:43 ngarcia New Issue
2016-07-15 14:43 ngarcia Assigned To => Triage Finance
2016-07-15 14:43 ngarcia Modules => Core
2016-07-15 14:43 ngarcia Resolution time => 1470348000
2016-07-15 14:43 ngarcia Triggers an Emergency Pack => No
2016-07-15 14:43 ngarcia Issue Monitored: networkb
2016-07-18 17:13 markmm82 Status new => scheduled
2016-07-18 17:41 aferraz Assigned To Triage Finance => markmm82
2016-08-02 21:16 markmm82 Note Added: 0088758
2016-08-02 21:30 markmm82 Note Edited: 0088758 View Revisions
2016-08-02 21:31 markmm82 File Added: 33489.diff
2016-08-02 21:32 markmm82 File Added: CreateAccountingConfiguration.class
2016-08-09 09:07 hgbot Checkin
2016-08-09 09:07 hgbot Note Added: 0088914
2016-08-09 09:07 hgbot Status scheduled => resolved
2016-08-09 09:07 hgbot Resolution open => fixed
2016-08-09 09:07 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/6e46a5541bbdd5318f9bda7f25cded92e332094b [^]
2016-08-09 09:11 aferraz Review Assigned To => aferraz
2016-08-09 09:11 aferraz Note Added: 0088915
2016-08-09 09:11 aferraz Status resolved => closed
2016-08-09 09:11 aferraz Fixed in Version => 3.0PR16Q4
2016-08-11 18:40 hudsonbot Checkin
2016-08-11 18:40 hudsonbot Note Added: 0089049


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker