Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033465
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminoralways2016-07-12 13:422016-09-05 13:12
ReportermaiteView Statuspublic 
Assigned Tomarkmm82 
PriorityimmediateResolutionfixedFixed in Version3.0PR16Q4
StatusclosedFix in branchFixed in SCM revision22f8e0393302
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2016-01-13
Regression introduced in release3.0PR16Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/27ef13611fff [^]
Triggers an Emergency PackNo
Summary

0033465: Invoice amount not populated when running Add Payment from Add Transaction from Match Statement process

DescriptionWhen specific invoice is selected , amount field is set to zero instead of to invoice's amount
Steps To Reproduce1. Register Purchase Invoice with total amount 100 and process
2. Access Financial Account, go to Bank Statement tab and create register with bank statement line with Amount out=150. Process bank statement
3. Run Match Statement process, press Cancel and run Add Transaction process by pressing +
4. Run Add Payment process by pressing + in payment's selector. Clear filtering data if required and select previous invoice. Realize that amount is not populated with 100

NOTE: if you follow similar process from Transaction's grid you will see that amount field is populated with invoice's amount
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00293923.0PR15Q3 closedumartirena Bank Statement Line amount should be maintained when registering payment out from Match statement process 
related to defect 00291243.0PR15Q2 closedSandrahuguet It is not possible to create Payment Out document from "match statement" window 
related to defect 0028755 closedSandrahuguet It is not possible "leaving credit to be used later" when adding a payment in match statement. 
depends on backport 00334703.0PR16Q3 closedmarkmm82 Invoice amount not populated when running Add Payment from Add Transaction from Match Statement process 
depends on backport 00334713.0PR16Q2.2 closedmarkmm82 Invoice amount not populated when running Add Payment from Add Transaction from Match Statement process 
caused by defect 0031392 closedAtulOpenbravo It is not possible to match positive bank statement line against negative purchase invoice from Match Statement process 
related to defect 0033666 closednonofrancisco when adding a payment in match statement, the actual payment is 0, and it should be the transaction amount 

-  Notes
(0088459)
markmm82 (developer)
2016-07-13 22:12

 Test Plan 1
1. Register Purchase Invoice with total amount 100 and process
2. Access Financial Account, go to Bank Statement tab and create register with bank statement line with Amount out=150. Process bank statement
3. Run Match Statement process, press Cancel and run Add Transaction process by pressing +
4. Run Add Payment process by pressing + in payment's selector. Clear filtering data if required and select previous invoice. Realize that amount is populated with 100


Test Plan 2
1. Register Sales Invoice with total amount 200 and process
2. Access Financial Account, go to Transaction tab and create a new Transaction header
    -Set Transaction Type = BP Deposit
    -Move down to "Amounts" section and set Deposit Amount = 200.
    -Move up and run "Add Payment" process by pressing + in payment's selector.
        -Notice that "Actual Payment field" is populated with 200.
        -Go to "Order/Invoice" section and Clear filtering data if required and select previous invoice. Realize that amount is populated with 200
    -Select and press Done.
3. Save the transaction and process.
4. Notice process is completed successfully


Test Plan 3
1. Register Purchase Invoice with total amount 300 and process
2. Access Financial Account, go to Transaction tab and create a new Transaction header
    -Set Transaction Type = BP Withdrawal
    -Move down to "Amounts" section and set Withdrawal Amount = 300.
    -Move up and run "Add Payment" process by pressing + in payment's selector.
        -Notice that "Actual Payment field" is populated with 300.
        -Go to "Order/Invoice" section and Clear filtering data if required and select previous invoice. Realize that amount is populated with 300
    -Select and press Done.
3. Save the transaction and process.
4. Notice process is completed successfully


Test Plan 4
1. Access Financial Account, go to Transaction tab and select previous transaction created in Test Plan 3 (Withdrawal = 300).
3. Run Match Statement process, press Cancel and run Add Transaction process by pressing +
4. Run Add Payment process by pressing + in payment's selector. Clear filtering data if required and select previous invoice. Realize that amount is populated with 300

Test Plan 5 (check for related issue 31392)
1. Register purchase invoice document setting qty=-1 so invoice's amount is negative (for instance -1.23). Process invoice
2. Access Cuenta de Banco financial account and register bank statement with a line with amount in. Process bank statement
3. Run "Match Statement" process, press cancel button.
4. Run Add Transaction from positive line.
    -Change type to "BP Withdrawal" run "Add Payment" process by pressing + in payment's selector.
     -Go to "Order/Invoice" section and Clear filtering data if required and select previous invoice (-1.23).
    -Realize that you are not to create negative payment out

Try similar workflow but registering negative payment out document directly from the invoice and withdrawn it in the financial account, notice you will be able to match it against positive bank statement line using search transaction process.


Test Plan 6 (check for related issue 29392)
1. Access "Cuenta de banco" financial account and create new Bank Statement record. Add Bank Statement Line with amount out=100 and process
2. Run "Match statement" process and press "+" icon to add new transaction
3. Press "+" icon to add new payment.
4. Clear filter if necessary, uncheck invoices considered by default and check invoices again and realize that distributed amount is not your bank statement line amount but total invoice's amount.
5. Select a line with amount greater than the statement line amount, for instance 140. Done.
6. You will back to the Add Transaction window, press DONE button.
7. Notice that a message "Bank statement line and transaction amount does not match. Do you want to perform a partial match?" Press OK
8. As you are trying to match a bank statement line with an invoice amount greater, and the process only distribute that specific amount of the invoice's total, two lines are created:
    -Amount Out = 140, Amount In = 0, Matching Type = Added
    -Amount Out = 0, Amount In = 40, Matching Type = (EMPTY) difference (40)


Test Plan 7 (check for related issue 29392)
Repeat the steps 1 to 4 of test plan 6
5. Select a line with amount lower than the statement line amount, for instance 60. Done.
6. You will back to the Add Transaction window, press DONE button.
7. Notice that a message "Bank statement line and transaction amount does not match. Do you want to perform a partial match?" Press OK
8. As you are trying to match a bank statement line with an invoice amount lower, and the process only distribute that specific amount of the invoice's total, the total is now distributed in two lines:
    -Amount Out = 40, Amount In = 0, Matching Type = (EMPTY) difference
    -Amount Out = 60, Amount In = 0, Matching Type = Added


Test Plan 8 (check for related issue 29124)
1. Access Cuenta de Banco financial account, create new Bank Statement document. Add Bank Statement Line with amount OUT=55. Process bank statement document
2. Run Match Statement process and cancel algorithm execution
3. Press "+" button to add new transaction related with your bank statement line
4. Press "+" button in Payment field to create payment out document.
5. Go to GL item section and add new record, select any item and set Paid Out=55.
6. Realize that Actual payment=55 and Expected payment=0, which is correct. Press Done.
7. Press done button and next OK. Notice that the match was successfull.


Test Plans for regressions related to issue 29390

Test Plan 9 (check for related issue 28755)
Seems to UI and the match statement workflow changed since this issue was reported.
https://issues.openbravo.com/view.php?id=28755 [^]


Test Plan 10 (check for related issue 29238)
1. Access Financial Account "Cuenta de Banco", create new Bank statement document with a bank statement line of 50 amount IN. Process Bank Statement
2. Run "Match Statement" process cancelling automatic execution
3. Press "+" button to create a new transaction from your bank statement line
4. Select any gl item and press Done
5. Press Done and OK
6. Go to Reconciliations tab and realize that reconciliation in Draft status containing your transaction has been created
7. Access Transactions tab and realize that your GL Item transaction is processed, it is correct!


Test Plan 11 (check for related issue 28971)
1. Create a sales invoice with negative amount and complete it
2. Create a Payment In for the invoice's business partner and 0 amount
3. Click on Add Details
4. Select the Invoice to be paid and add the outstanding amount if needed
5. Add a G/L Item and add the outstanding amount in positive in the Received In field
6. Check the Done button is enabled and you can process the payment.


Test Plan 12 (check for related issue 29464)
1. Access "Cuenta de Banco" financial account and create new Bank Statement. Add line with IN amount=50. Process
2. Access "Execution process" window and add parameter to "Simple Execution Process":
    Parameter type= IN,
    Input type= Checkbox,
    Default value for flag= yes,
    Mandatory= yes
3. Access Financial Account | Payment method tab and configure Transferencia as "Automatic", Execution process= "Simple Execution Process" and Deferred= NO
4. Run "Match Statement" process and "Add transaction" process. Realize that Deposit amount is set to 50
5. Run "Add Payment" process, choose any invoice and press Done. Realize that Deposit amount still being 50
6. Press Done and Ok, and notice that any error is shown and the match is successfull.


Test Plan 13 (check for related issue 29533)
1. Go to Financial Account window. Select "Bank - Account 1".
2. Go to Imported Bank Statements tab. Create a Header.
3. Create a Bank Statement Line. Amount Out 10. Process it.
4. Click on Match Statement. Press cancel in the displayed popup.
5. Select the previously created line and click on Add Transaction.
6. Set as Transaction Type "Bank Fee", be sure the Withdrawal field = 10 and press Done.
7. Realize that any error is raised, and the match is completed successfully


Test Plan 14 (check for related issue 29534)
1. Go to Financial Account window, transaction tab.
2. Add new record and change Transaction Date = 25-07-2016
3. Realize that Accounting Date is automatically updated with the same date.

4. Go to Financial Account window. Select "Bank - Account 1".
5. Go to Imported Bank Statements tab. Create a Header.
6. Create a Bank Statement Line. Amount Out 10. Process it.
7. Click on Match Statement. Press cancel in the displayed popup.
8. Select the previously created line and click on Add Transaction.
9. Change Transaction Date to 26-07-2016.
10. Realize that Accounting Date is automatically updated with this new date.


Test Plan 15 (check for related issue 31697)
1. Access Cuenta de Banco financial account, create new Bank Statement record
2. Add Bank Statement line setting any amount and Description as "bsl description". Process bank statement
3. Run "Match Statement" process and press Add Transaction button (+) from your line. Realize that Description field "bsl description" is shown
4. Select any GL Item in the combo. Realize that Description field has been updated with the line´s description and with the GL Item's description.
It is OK!
(0088463)
hgbot (developer)
2016-07-14 11:33

 Repository: erp/devel/pi
Changeset: 22f8e03933024c633305fc6782429098e6c8c92c
Author: Mark <markmm82 <at> gmail.com>
Date: Wed Jul 13 09:45:27 2016 -0400
URL: http://code.openbravo.com/erp/devel/pi/rev/22f8e03933024c633305fc6782429098e6c8c92c [^]

Fixes issue 33465: Right invoice amount when Add Payment from Match Statement

Invoice amount is populated when running Add Payment from Add Transaction from Match Statement process, and the amount field is set to invoice's amount instead of to zero when specific invoice is selected.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0088465)
aferraz (manager)
2016-07-14 11:38

 Code review + Testing OK
(0089011)
hudsonbot (developer)
2016-08-11 18:40

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/edaa05b1fb18 [^]
Maturity status: Test
(0089751)
hgbot (developer)
2016-09-05 13:12

 Repository: tools/automation/int
Changeset: 7e8bef12da1b478798e8b797204cc33d96edc357
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Jul 14 11:56:34 2016 +0200
URL: http://code.openbravo.com/tools/automation/int/rev/7e8bef12da1b478798e8b797204cc33d96edc357 [^]

Related to issue 33465: Backout changesets 6a29f40bf68d & 65c12cf5437a

Undo changes done for issue 31392 in APRDepositReconciliation010, APRRegression30007Out and APRWithdrawalReconciliation006 selenium tests because since issue 33465 they are not necessary.

---
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_ReconciliationRefactor/APRDepositReconciliation010.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_ReconciliationRefactor/APRWithdrawalReconciliation006.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/addpayment/testsuites/APR_Regressions/APROut_Regressions/APRRegression30007Out.java
---

- Issue History
Date Modified Username Field Change
2016-07-12 13:42 maite New Issue
2016-07-12 13:42 maite Assigned To => Triage Finance
2016-07-12 13:42 maite Modules => Core
2016-07-12 13:42 maite Resolution time => 1470088800
2016-07-12 13:42 maite Triggers an Emergency Pack => No
2016-07-12 13:43 maite Issue Monitored: networkb
2016-07-12 13:50 aferraz Assigned To Triage Finance => markmm82
2016-07-12 13:54 aferraz Relationship added caused by 0031392
2016-07-12 13:54 aferraz Category Z. Others => 09. Financial management
2016-07-12 16:04 markmm82 Status new => acknowledged
2016-07-13 10:54 aferraz Relationship added related to 0029392
2016-07-13 10:54 aferraz Relationship added related to 0029124
2016-07-13 10:54 aferraz Relationship added related to 0028755
2016-07-13 10:56 aferraz Relationship added related to 0029390
2016-07-13 11:21 aferraz Relationship deleted related to 0029390
2016-07-13 11:23 aferraz Regression level => Production - Confirmed Stable
2016-07-13 11:23 aferraz Regression date => 2016-01-13
2016-07-13 11:23 aferraz Regression introduced in release => 3.0PR16Q2
2016-07-13 11:23 aferraz Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/27ef13611fff [^]
2016-07-13 11:24 aferraz Status acknowledged => scheduled
2016-07-13 22:12 markmm82 Note Added: 0088459
2016-07-14 11:33 hgbot Checkin
2016-07-14 11:33 hgbot Note Added: 0088463
2016-07-14 11:33 hgbot Status scheduled => resolved
2016-07-14 11:33 hgbot Resolution open => fixed
2016-07-14 11:33 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/22f8e03933024c633305fc6782429098e6c8c92c [^]
2016-07-14 11:38 aferraz Review Assigned To => aferraz
2016-07-14 11:38 aferraz Note Added: 0088465
2016-07-14 11:38 aferraz Status resolved => closed
2016-07-14 11:38 aferraz Fixed in Version => 3.0PR16Q4
2016-08-11 12:34 aferraz Relationship added related to 0033666
2016-08-11 18:40 hudsonbot Checkin
2016-08-11 18:40 hudsonbot Note Added: 0089011
2016-09-05 13:12 hgbot Checkin
2016-09-05 13:12 hgbot Note Added: 0089751

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker