Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033446
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] Web POSmajoralways2016-07-07 13:022016-07-20 15:49
ReportermarvintmView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in VersionRR16Q4
StatusclosedFix in branchFixed in SCM revisionfd6416a8e685
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033446: Mobile/Retail API is too open

DescriptionCurrently the Java-side API exposed by the Mobile infrastructure and the Web POS is too open, and several things could be closed without breaking existing modules.

This is particularly important now that an automated API check is going to be added to Retail, in order to minimize the amount of real API changes which are logged by this tool.
Steps To Reproduce.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0088296)
hgbot (developer)
2016-07-07 16:55

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b3b7d6b2667004ce9ac07c530fb8459f0485cdb2
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Jul 07 13:16:32 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b3b7d6b2667004ce9ac07c530fb8459f0485cdb2 [^]

Fixed issue 33446. Implemented changes to close the API as much as possible

---
M src/org/openbravo/retail/posterminal/BrandProductHQLCriteria.java
M src/org/openbravo/retail/posterminal/CashCloseProcessor.java
M src/org/openbravo/retail/posterminal/CategoryTreeHQLCriteria.java
M src/org/openbravo/retail/posterminal/CustomerAddrLoader.java
M src/org/openbravo/retail/posterminal/CustomerLoader.java
M src/org/openbravo/retail/posterminal/EmailSender.java
M src/org/openbravo/retail/posterminal/OrderGroupingProcessor.java
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/ProcessCashCloseMaster.java
M src/org/openbravo/retail/posterminal/ProcessVoidLayaway.java
M src/org/openbravo/retail/posterminal/ad_callouts/CharacteristicVerification.java
M src/org/openbravo/retail/posterminal/master/Cashup.java
M src/org/openbravo/retail/posterminal/master/LoadedCustomer.java
M src/org/openbravo/retail/posterminal/master/PriceList.java
M src/org/openbravo/retail/posterminal/master/Product.java
M src/org/openbravo/retail/posterminal/master/ProductDiscProperties.java
M src/org/openbravo/retail/posterminal/master/ProductPrice.java
M src/org/openbravo/retail/posterminal/master/ProductProperties.java
M src/org/openbravo/retail/posterminal/term/TerminalProperties.java
M src/org/openbravo/retail/posterminal/utility/GenerateProductImages.java
---
(0088297)
hgbot (developer)
2016-07-07 16:56

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 1ac54f09d1debbfc832ef357a72f45a7c23e96d3
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Jul 07 13:16:40 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1ac54f09d1debbfc832ef357a72f45a7c23e96d3 [^]

Fixed issue 33446. Implemented changes to close the API as much as possible

---
M src/org/openbravo/mobile/core/login/LabelsComponent.java
M src/org/openbravo/mobile/core/login/ProfileUtils.java
M src/org/openbravo/mobile/core/login/RolePermissions.java
M src/org/openbravo/mobile/core/process/WebServiceAbstractServlet.java
M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java
M src/org/openbravo/mobile/core/utils/LogClientLoader.java
---
(0088298)
hgbot (developer)
2016-07-07 16:56

 Repository: erp/pmods/org.openbravo.retail.discounts
Changeset: fd6416a8e68569d4ec8f712bd6e3ba1164c73f98
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Jul 07 13:17:02 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/fd6416a8e68569d4ec8f712bd6e3ba1164c73f98 [^]

Fixed issue 33446. Implemented changes to close the API as much as possible

---
M src/org/openbravo/retail/discounts/AddPack.java
---

- Issue History
Date Modified Username Field Change
2016-07-07 13:02 marvintm New Issue
2016-07-07 13:02 marvintm Assigned To => Retail
2016-07-07 13:02 marvintm OBNetwork customer => No
2016-07-07 13:02 marvintm Triggers an Emergency Pack => No
2016-07-07 13:02 marvintm Assigned To Retail => marvintm
2016-07-07 13:02 marvintm Status new => scheduled
2016-07-07 16:55 hgbot Checkin
2016-07-07 16:55 hgbot Note Added: 0088296
2016-07-07 16:55 hgbot Status scheduled => resolved
2016-07-07 16:55 hgbot Resolution open => fixed
2016-07-07 16:55 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b3b7d6b2667004ce9ac07c530fb8459f0485cdb2 [^]
2016-07-07 16:56 hgbot Checkin
2016-07-07 16:56 hgbot Note Added: 0088297
2016-07-07 16:56 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b3b7d6b2667004ce9ac07c530fb8459f0485cdb2 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1ac54f09d1debbfc832ef357a72f45a7c23e96d3 [^]
2016-07-07 16:56 hgbot Checkin
2016-07-07 16:56 hgbot Note Added: 0088298
2016-07-07 16:56 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/1ac54f09d1debbfc832ef357a72f45a7c23e96d3 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discounts/rev/fd6416a8e68569d4ec8f712bd6e3ba1164c73f98 [^]
2016-07-20 15:49 guilleaer Review Assigned To => guilleaer
2016-07-20 15:49 guilleaer Status resolved => closed
2016-07-20 15:49 guilleaer Fixed in Version => RR16Q4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker