0033396: NPE with symmetric DS modules installed but not used in tomcat

Description

In case where Symmetric DS + synchronization modules are installed.
But not used (no ant install.symmetric.ds done)

At least in one case of uploading i.e. order,invoice,cashup data the code seems to not check if SymmetricDS is actually running and fails with the following stacktrace.

30712 [http-8080-2] ERROR org.openbravo.replication.symmetricds.SynchronizationEngineProvider - The engine holder has not been set. It should have been initialized by the SetupSymmetricListener class when tomcat was started
30712 [http-8080-2] ERROR org.openbravo.retail.storeserver.synchronization.MultiServerJSONSymmetricDSStarter -
java.lang.NullPointerException
    at org.openbravo.retail.storeserver.synchronization.MultiServerJSONSymmetricDSStarter$1.run(MultiServerJSONSymmetricDSStarter.java:54)
    at java.lang.Thread.run(Thread.java:745)
    at org.openbravo.retail.storeserver.synchronization.MultiServerJSONSymmetricDSStarter.doAction(MultiServerJSONSymmetricDSStarter.java:65)
    at org.openbravo.mobile.core.servercontroller.MultiServerJSONProcess.exec(MultiServerJSONProcess.java:288)
    at org.openbravo.mobile.core.process.JSONProcessSimple.exec(JSONProcessSimple.java:59)
    at org.openbravo.mobile.core.process.SecuredJSONProcess.secureExec(SecuredJSONProcess.java:53)
    at org.openbravo.mobile.core.process.MobileServiceProcessor.execProcess(MobileServiceProcessor.java:117)
    at org.openbravo.mobile.core.process.MobileServiceProcessor.execServiceName(MobileServiceProcessor.java:79)
    at org.openbravo.mobile.core.process.MobileService.doGetOrPost(MobileService.java:89)
    at org.openbravo.mobile.core.process.MobileService.doPost(MobileService.java:59)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:643)

Steps To Reproduce

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

caused by

feature request

0033235

RR16Q3

closed

mtaal

Replicating transactions - research a different way to execute transactions in a multi-server environment

Notes
(0088114) hgbot (developer) 2016-06-30 18:27	Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization Changeset: ae7e06d93e5cb8f056af024f6ddda25105e69e79 Author: Augusto Mauch <augusto.mauch <at> openbravo.com> Date: Thu Jun 30 18:23:47 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/ae7e06d93e5cb8f056af024f6ddda25105e69e79 [^] Fixes issue 33396: Makes sure SymmetricDS is started before using its engine SynchronizationEngineProvider.getInstance().getEngine() returns a ServerSymmetricEngine object if SymmetricDS is up and running in the current server, otherwise it returns null. The MultiServerJSONSymmetricDSStarter class was invoking methods over SynchronizationEngineProvider.getInstance().getEngine() without checking whether the engine was null. --- M src/org/openbravo/retail/storeserver/synchronization/MultiServerJSONSymmetricDSStarter.java ---

(0088141) mtaal (manager) 2016-07-01 11:08	Reviewed

Issue History
Date Modified	Username	Field	Change
2016-06-30 16:46	shuehner	New Issue
2016-06-30 16:46	shuehner	Assigned To	=> StoreServer
2016-06-30 18:25	AugustoMauch	Assigned To	StoreServer => AugustoMauch
2016-06-30 18:26	AugustoMauch	Review Assigned To	=> mtaal
2016-06-30 18:27	hgbot	Checkin
2016-06-30 18:27	hgbot	Note Added: 0088114
2016-06-30 18:27	hgbot	Status	new => resolved
2016-06-30 18:27	hgbot	Resolution	open => fixed
2016-06-30 18:27	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/ae7e06d93e5cb8f056af024f6ddda25105e69e79 [^]
2016-06-30 18:33	AugustoMauch	Relationship added	caused by 0033235
2016-07-01 11:08	mtaal	Note Added: 0088141
2016-07-01 11:08	mtaal	Status	resolved => closed
2016-07-11 13:21	gorka_gil	Project	Modules => Retail Modules
2016-07-12 16:13	gorka_gil	Category	StoreServer Infrastructure => StoreServer