Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0033332
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementminorhave not tried2016-06-22 16:122016-08-11 19:42
ReportershuehnerView Statuspublic 
Assigned ToTriage Omni OMS 
PrioritynormalResolutionno change requiredFixed in Version
StatusclosedFix in branchFixed in SCM revision
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033332: Missing DalUtil.getId triggering extra useless sql-select in FinUtility.getDocumentType

DescriptionThis line in above function:
    if ("0".equals(org.getId())) {

Triggers ad_org select in database while not needing this.

Using DalUtil.getId avoid that extra select.

Found in stacktrace of some OrderLoader flow
    at org.openbravo.model.common.enterprise.Organization_$$_javassist_223.getId(Organization_$$_javassist_223.java)
    at org.openbravo.advpaymentmngt.utility.FIN_Utility.getDocumentType(FIN_Utility.java:282)
    at org.openbravo.retail.posterminal.OrderLoader.getPaymentDocumentType(OrderLoader.java:663)
    at org.openbravo.retail.posterminal.OrderLoader.processPayments(OrderLoader.java:1485)
    at org.openbravo.retail.posterminal.OrderLoader.handlePayments(OrderLoader.java:1317)
    at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:454)
Steps To Reproduceshu jmeter for highvol but
TagsPerformance
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0089058)
shuehner (administrator)
2016-08-11 19:42

Obsolete after fix of 33200 which removes all need of using DalUtil.getId

https://issues.openbravo.com/view.php?id=33200 [^]

- Issue History
Date Modified Username Field Change
2016-06-22 16:12 shuehner New Issue
2016-06-22 16:12 shuehner Assigned To => Triage Finance
2016-06-22 16:12 shuehner Modules => Core
2016-06-22 16:12 shuehner Triggers an Emergency Pack => No
2016-06-22 16:13 shuehner Tag Attached: Performance
2016-08-11 19:42 shuehner Note Added: 0089058
2016-08-11 19:42 shuehner Status new => closed
2016-08-11 19:42 shuehner Resolution open => no change required


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker