Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033302
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 04. Warehouse managementmajoralways2016-06-17 13:092016-06-22 18:10
ReporterpsanjuanView Statuspublic 
Assigned ToSanjota 
PriorityurgentResolutionfixedFixed in Version3.0PR16Q3
StatusclosedFix in branchFixed in SCM revisiona6bc45531368
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionProfessional ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033302: Costing engine is not taking into account that purchase price list can be setup to include taxes.

DescriptionCosting engine is not taking into account that purchase price list can be setup to include taxes, while cost should not include taxes anyway.
Steps To ReproduceGo to Price list window and create a new one for F&B España, named: Purchase Price List Including Taxes. Set it up as "Price Including Taxes". Enter a price list version valid from 01-01-2016.

Go to Product window and create a new product, named: Product Issue 33302.

Go to Price tab and select just created purchase price list including taxes.
Enter a price = 121.00 (this price includes a 21.00 of taxes (21%)

Go to Business Partner window, search by Bebidas Alegres BP. Go to Vendor sub-tab and assign just created price list including taxes in there, field: "Purchase Pricelist"

Go to Goods Receipt and create a new one for F&B España, Bebidas Alegres BP, for 1 unit of the product just created. Complete.

Run Costing Background process.

Go to product window, search by the product and check that the cost shown in "Costing" tab is 121.00.

Above is not correct because cost should not include taxes. Correct Cost should have been 100.00
Proposed SolutionWhen calling to FinancialUtils.getProductPrice method from CostingAlgorithm.getPriceListCost, CostingAlgorithm.getReceiptDefaultCost or CostingUtils.getDefaultCost methods we need to "exclude" purchase price lists including taxes.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00339683.0PR17Q1 closeddmiguelez Wrong costs calculated with Backdated Transactions 

-  Notes
(0087684)
Sanjota (developer)
2016-06-20 17:26

 Test plan:
Go to Price list window and create a new one for F&B España, named: Purchase Price List Including Taxes. Set it up as "Price Including Taxes". Enter a price list version valid from 01-01-2016.

Go to Product window and create a new product, named: Product Issue 33302.

Go to Price tab and select just created purchase price list including taxes.
Enter a price = 121.00 (this price includes a 21.00 of taxes (21%)

Go to Business Partner window, search by Bebidas Alegres BP. Go to Vendor sub-tab and assign just created price list including taxes in there, field: "Purchase Pricelist"

Go to Goods Receipt and create a new one for F&B España, Bebidas Alegres BP, for 1 unit of the product just created. Complete.

Run Costing Background process.

Check the process log in process monitor for the process scheduled
and you can see the error No Price List or Standard Cost found for given product. Org: F&B España, S.A, Product: <product details>
also
Go to product window, search by the product and check the cost tab and there won't be any record created.
Which tells that the purchase pricelist with tax included are excluded in costing.
(0087716)
hgbot (developer)
2016-06-21 12:06

 Repository: erp/devel/pi
Changeset: a6bc455313684af22bab91f4d8420b41b54e2c66
Author: Sanjota <sanjota.nelagi <at> promantia.com>
Date: Tue Jun 21 02:37:36 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/a6bc455313684af22bab91f4d8420b41b54e2c66 [^]

Fixes issue 33302: Related to costing of purchase price lists including taxes

Fix to the issue Costing engine is not taken into account that purchase price list can be setup to include taxes, while cost should not include taxes.

---
M src/org/openbravo/costing/CostingAlgorithm.java
M src/org/openbravo/costing/CostingUtils.java
M src/org/openbravo/financial/FinancialUtils.java
---
(0087717)
hgbot (developer)
2016-06-21 12:06

 Repository: erp/devel/pi
Changeset: 49000d1b62921c2b18c6984d314ec2744ae14c2a
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Jun 21 11:48:41 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/49000d1b62921c2b18c6984d314ec2744ae14c2a [^]

Related to issue 33302: Code review improvements

- Add new usePriceIncludeTax parameter to getProductPrice method documentation.
- Check usePriceIncludeTax flag only once in getProductPrice query.
- Send usePriceIncludeTax parameter correctly in CostingAlgorithm.getPriceListCost method.
- Send usePriceIncludeTax parameter in CostingAlgorithm.getReceiptDefaultCost method.

---
M src/org/openbravo/costing/CostingAlgorithm.java
M src/org/openbravo/financial/FinancialUtils.java
---
(0087718)
aferraz (manager)
2016-06-21 12:07

 Code review + Testing OK
(0087828)
hudsonbot (developer)
2016-06-22 18:10

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/468afe624cc8 [^]
Maturity status: Test
(0087829)
hudsonbot (developer)
2016-06-22 18:10

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/468afe624cc8 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-06-17 13:09 psanjuan New Issue
2016-06-17 13:09 psanjuan Assigned To => Triage Finance
2016-06-17 13:09 psanjuan Modules => Core
2016-06-17 13:09 psanjuan Triggers an Emergency Pack => No
2016-06-17 13:18 psanjuan Steps to Reproduce Updated View Revisions
2016-06-17 13:21 psanjuan Steps to Reproduce Updated View Revisions
2016-06-17 13:32 psanjuan Steps to Reproduce Updated View Revisions
2016-06-17 13:34 psanjuan Steps to Reproduce Updated View Revisions
2016-06-17 13:36 psanjuan Proposed Solution updated
2016-06-17 13:48 aferraz Proposed Solution updated
2016-06-20 11:02 Sanjota Status new => scheduled
2016-06-20 13:14 aferraz Proposed Solution updated
2016-06-20 13:14 aferraz Assigned To Triage Finance => Sanjota
2016-06-20 17:26 Sanjota Note Added: 0087684
2016-06-21 11:34 aferraz Proposed Solution updated
2016-06-21 12:06 hgbot Checkin
2016-06-21 12:06 hgbot Note Added: 0087716
2016-06-21 12:06 hgbot Status scheduled => resolved
2016-06-21 12:06 hgbot Resolution open => fixed
2016-06-21 12:06 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/a6bc455313684af22bab91f4d8420b41b54e2c66 [^]
2016-06-21 12:06 hgbot Checkin
2016-06-21 12:06 hgbot Note Added: 0087717
2016-06-21 12:07 aferraz Review Assigned To => aferraz
2016-06-21 12:07 aferraz Note Added: 0087718
2016-06-21 12:07 aferraz Status resolved => closed
2016-06-21 12:07 aferraz Fixed in Version => 3.0PR16Q3
2016-06-21 12:51 psanjuan Summary Costing engine is not taken into account that purchase price list can be setup to include taxes. => Costing engine is not taking into account that purchase price list can be setup to include taxes.
2016-06-21 12:51 psanjuan Description Updated View Revisions
2016-06-22 18:10 hudsonbot Checkin
2016-06-22 18:10 hudsonbot Note Added: 0087828
2016-06-22 18:10 hudsonbot Checkin
2016-06-22 18:10 hudsonbot Note Added: 0087829
2016-09-19 10:12 aferraz Relationship added related to 0033968

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker