Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033301
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2016-06-17 10:542016-06-30 19:13
ReportermaiteView Statuspublic 
Assigned ToSanjota 
PriorityurgentResolutionfixedFixed in Version3.0PR16Q3
StatusclosedFix in branchFixed in SCM revision9a7e4cc7bd8f
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033301: Extra "Asset Amortization" record with total amount of 0 when Asset defined as "Every Month Is 30 Day"= NO

DescriptionExtra "Asset Amortization" record with total amount of 0 when Asset defined as "Every Month Is 30 Day"= NO. In case it is defined with "Every Month Is 30 Day"= YES then no extra line is created
Steps To Reproduce1. Access Asset window and create record as follows:
 - Depreciate= yes
 - Depreciation type= linear
 - Calculate type= time
 - Amortize= monthly
 - Usable life-months=120
 - Every month is 30 days= NO
 - Purchase date= 19-01-2015
 - Depreciation start date= 19-01-2015
 - Asset value= 33.82
2. Run Create Amortization process and realize that 121 records have been created in Asset Amortization tab (instead of 120) and that last one hast amount of 0

NOTE: if you delete "Asset Amortization" records, set Every month is 30 days= YES and run process again then 120 records are created
TagsNo tags attached.
Attached Files? file icon 33301.sql [^] (90 bytes) 2016-06-30 12:42

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0087863)
Sanjota (developer)
2016-06-23 23:37
edited on: 2016-06-27 12:14

 Test Plan:
1. Access Asset window and create record as follows:
 - Depreciate= yes
 - Depreciation type= linear
 - Calculate type= time
 - Amortize= monthly
 - Usable life-months=120
 - Every month is 30 days= NO
 - Purchase date= 19-01-2015
 - Depreciation start date= 19-01-2015
 - Asset value= 33.82
2. Run Create Amortization process and Observe that 120 records have been created in Asset Amortization tab without having any line with amount=0.
3.- Set Sum function for columns "Amortization Percentage" and "Amortization Amount"
4. Check that "Amortization Percentage" = 100.00 and Amortization Amount = 33.82


NOTE: if you delete now "Asset Amortization" records, and set Every month is 30 days= YES and run process again then 121 records are created without any line with amount =0

Check that:
- monthly amortization percentage is 0.83 but first one (0.35) as depreciation start date = 19-01-2015 and last one (0.88)
- "Amortization Percentage" = 100.00
- and Amortization Amount = 33.82

Also Please find attached script "33301Script.sql", to delete already existing lines with amount=0
(0087969)
psanjuan (manager)
2016-06-27 12:14

 Test plan above verified.

Issue can be code reviewed and closed.
(0088091)
hgbot (developer)
2016-06-30 12:43

 Repository: erp/devel/pi
Changeset: 9a7e4cc7bd8fd9e7ae4a647b0852c48905cbf47e
Author: Sanjota <sanjota.nelagi <at> promantia.com>
Date: Fri Jun 24 02:49:55 2016 +0530
URL: http://code.openbravo.com/erp/devel/pi/rev/9a7e4cc7bd8fd9e7ae4a647b0852c48905cbf47e [^]

Fixes issue 33301: Extra "Asset Amortization" record with total amount of 0

Extra "Asset Amortization" record with total amount of 0 when Asset defined as "Every Month Is 30 Day"= NO.
In case it is defined with "Every Month Is 30 Day"= YES then no extra line is created

---
M src/org/openbravo/erpCommon/ad_process/assets/AssetLinearDepreciationMethodProcess.java
---
(0088092)
hgbot (developer)
2016-06-30 12:43

 Repository: erp/devel/pi
Changeset: edafa9b0e0b0dae2b69d1986792598d9de5df942
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Jun 30 12:42:50 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/edafa9b0e0b0dae2b69d1986792598d9de5df942 [^]

Related to issue 33301: Code review improvements

---
M src/org/openbravo/erpCommon/ad_process/assets/AssetLinearDepreciationMethodProcess.java
---
(0088093)
aferraz (manager)
2016-06-30 12:44

 Code review + Testing OK
(0088094)
aferraz (manager)
2016-06-30 12:44

 Attached script to delete wrong data.
(0088119)
hudsonbot (developer)
2016-06-30 19:13

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/afefea138cd1 [^]
Maturity status: Test
(0088120)
hudsonbot (developer)
2016-06-30 19:13

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/afefea138cd1 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-06-17 10:54 maite New Issue
2016-06-17 10:54 maite Assigned To => Triage Finance
2016-06-17 10:54 maite Modules => Core
2016-06-17 10:54 maite Resolution time => 1467842400
2016-06-17 10:54 maite Triggers an Emergency Pack => No
2016-06-17 10:54 maite Issue Monitored: networkb
2016-06-17 14:58 aferraz Assigned To Triage Finance => markmm82
2016-06-23 12:30 aferraz Assigned To markmm82 => Sanjota
2016-06-23 23:33 Sanjota File Added: 33301Script.sql
2016-06-23 23:37 Sanjota Note Added: 0087863
2016-06-23 23:38 Sanjota Note Edited: 0087863 View Revisions
2016-06-27 12:14 psanjuan Note Edited: 0087863 View Revisions
2016-06-27 12:14 psanjuan Note Added: 0087969
2016-06-30 12:41 aferraz File Deleted: 33301Script.sql
2016-06-30 12:42 aferraz File Added: 33301.sql
2016-06-30 12:43 hgbot Checkin
2016-06-30 12:43 hgbot Note Added: 0088091
2016-06-30 12:43 hgbot Status new => resolved
2016-06-30 12:43 hgbot Resolution open => fixed
2016-06-30 12:43 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/9a7e4cc7bd8fd9e7ae4a647b0852c48905cbf47e [^]
2016-06-30 12:43 hgbot Checkin
2016-06-30 12:43 hgbot Note Added: 0088092
2016-06-30 12:44 aferraz Review Assigned To => aferraz
2016-06-30 12:44 aferraz Note Added: 0088093
2016-06-30 12:44 aferraz Status resolved => closed
2016-06-30 12:44 aferraz Fixed in Version => 3.0PR16Q3
2016-06-30 12:44 aferraz Note Added: 0088094
2016-06-30 19:13 hudsonbot Checkin
2016-06-30 19:13 hudsonbot Note Added: 0088119
2016-06-30 19:13 hudsonbot Checkin
2016-06-30 19:13 hudsonbot Note Added: 0088120

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker