Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033292
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] Z. Othersminorhave not tried2016-06-16 14:242016-06-27 12:33
ReportershuehnerView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision58a17e7e4040
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toshuehner
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033292: Disable junit test: SystemValidatorTest temporarily until it is enhanced to be disabled (optionally)

DescriptionIn some stage of release process currently module dependencies from retail to erp are temporarily inconsistent.

That is handled in normal CI process but an earlier change in 33032 causes this systemValidatorTest to also raise it during running junit tests.

Until that specific junit test can be enhanced to 'selectively disable' it temporarily switch of this specific test.
Steps To Reproduce-
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0046883 newTriage Platform Base Remove obsolete post.publication flag which was used in release process to temp-disable SystemValidatorTest 

-  Notes
(0087344)
hgbot (developer)
2016-06-16 14:33

 Repository: erp/devel/pi
Changeset: 68ef7d86fab1a990670628ca4d77813ae3929891
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Thu Jun 16 14:32:40 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/68ef7d86fab1a990670628ca4d77813ae3929891 [^]

Issue 33292. Temporarily disable testModulesValidation

---
M src-test/src/org/openbravo/test/system/SystemValidatorTest.java
---
(0087353)
hgbot (developer)
2016-06-16 15:03

 Repository: erp/devel/pi
Changeset: c57cff772373d352fab2f03dd5e9147784eb0130
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Jun 16 15:02:24 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/c57cff772373d352fab2f03dd5e9147784eb0130 [^]

issue 33292: test can be disabled with post.publication JVM prop set to true

---
M src-test/src/org/openbravo/test/system/SystemValidatorTest.java
---
(0087630)
hudsonbot (developer)
2016-06-17 19:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087631)
hudsonbot (developer)
2016-06-17 19:38

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test
(0087970)
shuehner (administrator)
2016-06-27 12:24

 Example commandline usage:
ANT_OPTS="-Dpost.publication=true" ant run.test -Dtest=org.openbravo.test.system.SystemValidatorTest

Needs to be done via ANT_OPTS as ant command 're-defines' -D and does not passes those on as java system properties.
(0087971)
hgbot (developer)
2016-06-27 12:28

 Repository: erp/devel/pi
Changeset: 58a17e7e4040610abb3bf3eda8e807bcd59599f4
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Fri Jun 24 23:05:23 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/58a17e7e4040610abb3bf3eda8e807bcd59599f4 [^]

Fixed 33292. Undo @Ignore annotation now that test can be selectively disabled.

---
M src-test/src/org/openbravo/test/system/SystemValidatorTest.java
---
(0087972)
shuehner (administrator)
2016-06-27 12:31

 Re-assign to Asier.
As single patch which is kept is authored by him.
(0087973)
shuehner (administrator)
2016-06-27 12:33

 reviewed & tested.
Normal i.e. ant run.test -Dtest=org.openbravo.test.system.SystemValidatorTest
runs the test without any changes.

If optionally system property post.pulication is set:

It will skip this single testcase and notes reason in skip details:
    [junit] Testcase: testModulesValidation took 0.45 sec
    [junit] SKIPPED: Ignoring test case during post publication cycle: got: "true", expected: not "true"

- Issue History
Date Modified Username Field Change
2016-06-16 14:24 shuehner New Issue
2016-06-16 14:24 shuehner Assigned To => shuehner
2016-06-16 14:24 shuehner Modules => Core
2016-06-16 14:24 shuehner Triggers an Emergency Pack => No
2016-06-16 14:33 hgbot Checkin
2016-06-16 14:33 hgbot Note Added: 0087344
2016-06-16 15:03 hgbot Checkin
2016-06-16 15:03 hgbot Note Added: 0087353
2016-06-17 19:38 hudsonbot Checkin
2016-06-17 19:38 hudsonbot Note Added: 0087630
2016-06-17 19:38 hudsonbot Checkin
2016-06-17 19:38 hudsonbot Note Added: 0087631
2016-06-27 12:24 shuehner Note Added: 0087970
2016-06-27 12:28 hgbot Checkin
2016-06-27 12:28 hgbot Note Added: 0087971
2016-06-27 12:28 hgbot Status new => resolved
2016-06-27 12:28 hgbot Resolution open => fixed
2016-06-27 12:28 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/58a17e7e4040610abb3bf3eda8e807bcd59599f4 [^]
2016-06-27 12:31 shuehner Review Assigned To => shuehner
2016-06-27 12:31 shuehner Note Added: 0087972
2016-06-27 12:31 shuehner Assigned To shuehner => alostale
2016-06-27 12:33 shuehner Note Added: 0087973
2016-06-27 12:33 shuehner Status resolved => closed
2021-05-28 10:32 shuehner Relationship added related to 0046883

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker