Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033291 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2016-06-16 13:24 | 2016-08-19 10:26 | |||
| Reporter | aaroncalero | View Status | public | |||||
| Assigned To | ranjith_qualiantech_com | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR16Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | fb99be0138c6 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | mtaal | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033291: [SERQA 1304] Approval not granted if the user has more than one preference allowing an action | |||||||
| Description | If a user has different preferences granting approval for an action (e.g. one configured for the specific user and one configured for its role), if the user tries to approve that action, the system doesn't allow it. | |||||||
| Steps To Reproduce | Using livebuilds: Login in backend and go to the preference window. Configure the following preferences: Web POS Delete Line Approval, value:Y, Visible at user: Openbravo. Web POS Delete Line Approval, value:Y, Visible at role: The White Valley Group Admin Web POS Delete Line Approval, value:N, Visible at user: Vall Blanca Store User. Login in web pos with user vallblanca. Create a new ticket, add a line, and try to delete the line. The Approval Required popup will be shown and Openbravo will be available as Supervisor. Select Openbravo and write its password. Then click on Approve. The 'User does not have privileges to approve this action' error will be shown and the line won't be deleted. | |||||||
| Proposed Solution | It is possible to send to the CheckAppoval.java file, which validates the supervisor credentials, several approvals at the same time to validate all of them together. That process executes a query which filters permissions by role and user. The query is returning the whole preference object, although it only needs the 'property' value. After that, compares the amount of results returned by the query (which may include duplicated preferences), with the amount of approvals requested. The proposed solution is to make the query return only the 'property' of the preference, and group by that field, so no duplicates are returned. | |||||||
| Tags | SER-QA | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0087660) hgbot (developer) 2016-06-20 12:30 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: fb99be0138c620e4eee7835281d0392a026bb155 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Jun 20 15:59:37 2016 +0530 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fb99be0138c620e4eee7835281d0392a026bb155 [^] Fixes issue 33291 : Changes in CheckApproval Query to remove duplicate - groupby clause added to query inorder to remove duplicated --- M src/org/openbravo/retail/posterminal/utility/CheckApproval.java --- |
|
(0087661) hgbot (developer) 2016-06-20 12:30 |
Repository: tools/automation/pi-mobile Changeset: f0abd36d3f31e6de666215c0f21de9b07276c165 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Jun 20 15:59:27 2016 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/f0abd36d3f31e6de666215c0f21de9b07276c165 [^] Verifies issue 33291 : Added automated test 'I33291_CheckApprovalBasedonPreference' --- A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I33291_CheckApprovalBasedonPreference.java --- |
|
(0087916) mtaal (manager) 2016-06-25 19:52 |
Reviewed and tested |
|
(0089225) hgbot (developer) 2016-08-18 19:18 |
Repository: retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal Changeset: c6e632dcf5a8f752f7c8bc60c17cee351c8728ee Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Mon Jun 20 15:59:37 2016 +0530 URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal/rev/c6e632dcf5a8f752f7c8bc60c17cee351c8728ee [^] Related to issue 0033590: Fixes for issue 33291. Changes in CheckApproval Query to remove duplicate - groupby clause added to query inorder to remove duplicated --- M src/org/openbravo/retail/posterminal/utility/CheckApproval.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-06-16 13:24 | aaroncalero | New Issue | |
| 2016-06-16 13:24 | aaroncalero | Assigned To | => Retail |
| 2016-06-16 13:24 | aaroncalero | Resolution time | => 1467237600 |
| 2016-06-16 13:24 | aaroncalero | Triggers an Emergency Pack | => No |
| 2016-06-16 13:27 | aaroncalero | Tag Attached: SER-QA | |
| 2016-06-16 13:27 | aaroncalero | Summary | Approval not granted if the user has more than one preference allowing an action => [SERQA 1304] Approval not granted if the user has more than one preference allowing an action |
| 2016-06-17 12:34 | marvintm | Status | new => acknowledged |
| 2016-06-20 06:24 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2016-06-20 06:24 | ranjith_qualiantech_com | Status | acknowledged => scheduled |
| 2016-06-20 12:30 | hgbot | Checkin | |
| 2016-06-20 12:30 | hgbot | Note Added: 0087660 | |
| 2016-06-20 12:30 | hgbot | Status | scheduled => resolved |
| 2016-06-20 12:30 | hgbot | Resolution | open => fixed |
| 2016-06-20 12:30 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fb99be0138c620e4eee7835281d0392a026bb155 [^] |
| 2016-06-20 12:30 | hgbot | Checkin | |
| 2016-06-20 12:30 | hgbot | Note Added: 0087661 | |
| 2016-06-23 19:20 | marvintm | Review Assigned To | => mtaal |
| 2016-06-25 19:52 | mtaal | Note Added: 0087916 | |
| 2016-06-25 19:52 | mtaal | Status | resolved => closed |
| 2016-06-25 19:52 | mtaal | Fixed in Version | => RR16Q3 |
| 2016-06-25 19:55 | mtaal | Relationship added | related to 0033357 |
| 2016-08-18 19:18 | hgbot | Checkin | |
| 2016-08-18 19:18 | hgbot | Note Added: 0089225 | |
| 2016-08-19 10:25 | guilleaer | Status | closed => new |
| 2016-08-19 10:25 | guilleaer | Resolution | fixed => open |
| 2016-08-19 10:25 | guilleaer | Fixed in Version | RR16Q3 => |
| 2016-08-19 10:25 | guilleaer | Status | new => scheduled |
| 2016-08-19 10:25 | guilleaer | Status | scheduled => resolved |
| 2016-08-19 10:25 | guilleaer | Resolution | open => fixed |
| 2016-08-19 10:26 | guilleaer | Status | resolved => closed |
| 2016-08-19 10:26 | guilleaer | Fixed in Version | => RR16Q4 |
| 2016-08-19 10:26 | guilleaer | Fixed in Version | RR16Q4 => RR16Q3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |