Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033238 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | major | always | 2016-06-13 16:18 | 2017-11-13 15:23 | |||
| Reporter | egoitz | View Status | public | |||||
| Assigned To | migueldejuana | |||||||
| Priority | immediate | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 3f14edc346d0 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | Production - Confirmed Stable | |||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033238: Multi currency payments not working | |||||||
| Description | Multi currency payments in the WebPOS are not working. | |||||||
| Steps To Reproduce | 1. create ticket with many lines and pay a ticket for 100 euros 2-Create a new ticket with 150 euros 3-Pay 100 euros 4-Add a payment is dolar execeding with the change the amount available in dolars in the cash. 5-click on cash to get the change in euros 6-click in done button -->> there is not enough cash message is displayed The system does not allow you to paid saying that there is not enough change in the currency, what is incorrect. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||||||||||||||||
|
|||||||||||||||||||||||||||||
 Relationships |
|
Notes |
|
|
(0087331) ranjith_qualiantech_com (developer) 2016-06-16 10:17 |
In payment.js, While clicking "Done" button all the payments in the receipt has been validated again in the method "checkValidPaymentList". this leads to create some issues. It better to remove this method and validate all receipt payments whenever there is a change(add/remove) in payments Case 1: 1) Cashup 2) Create ticket and add product "Avalanche transceiver" and complete it 3) Create ticket and add product "Avalanche transceiver" 4) Add 100 by Cash 5) Add 100 by USA Cash 6) While clicking "USA Cash", Msg("There is not enough cash available.") should be displayed, Done button should be disabled 7) While clicking "Cash", Msg("There is not enough cash available.") should "not" be displayed, Done button should be enabled, Since we have enough cash to give change in "Cash" Payment method 8) While clicking "Card", Msg("There is not enough cash available.") should "not" be displayed, Done button should be enabled, Since we have enough cash to give change in "Cash" Payment method Case 2: 1) Set overpayment limit to 10 for "Card" Payment method in backend 2) Create ticket and add product "Avalanche transceiver" 3) Add 200 by Card 4) Make sure Msg("Overpayment exceeded limit.") should be displayed 5) While clicking "Cash", Msg("Overpayment exceeded limit.") should be displayed, Done button should be disabled, Since Card exceeds overpayment limit Case 3: 1) Cashup 2) Create ticket and add product "Avalanche transceiver" 3) Add 200 by Cash 4) While clicking "Cash"/"Card", Msg("There is not enough cash available.") should be displayed, Done button should be disabled, Since we don't have enough cash in "Cash" Payment method Returns Case 1: 1) Cashup 2) Create ticket and add product "Avalanche transceiver" and make it as "Return" 3) Add 50 by Cash, Msg("There is not enough cash available.") should be displayed, Done button should be disabled 4) While clicking "Card", Msg("There is not enough cash available.") should be displayed, Done button should be disabled |
|
(0087665) hgbot (developer) 2016-06-20 12:59 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 51f7e7346e5ba0b1be62d75d0c481518af367d47 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Mon Jun 20 12:58:23 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/51f7e7346e5ba0b1be62d75d0c481518af367d47 [^] Fixed issue 0033238: Multi currency payments not working - Fix check payments logic to support correctly multicurrency, overpayments... - If we have a message ('not enough cash', 'overpayment'...) and Done button is disabled, we avoid user adding more payments till the issues is solved --- M src-db/database/sourcedata/AD_MESSAGE.xml M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0087666) hgbot (developer) 2016-06-20 12:59 |
Repository: tools/automation/pi-mobile Changeset: 61f52808f89902f3b63d383668053b19a6bb4e2a Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Mon Jun 20 10:32:49 2016 +0200 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/61f52808f89902f3b63d383668053b19a6bb4e2a [^] Related issue 33238: Adapt tests to new payment validation change --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I31279_LayawayUSACashPayments.java M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I31328_ReceiptReturnByCardPayment.java --- |
|
(0087667) migueldejuana (developer) 2016-06-20 13:03 |
Inside the fix a backout of this commit has been done. https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/895f3def5c1b2ae302197f33f0e0cebbe45f8e00 [^] |
|
(0087753) hgbot (developer) 2016-06-21 18:02 |
Repository: retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal Changeset: be815499ab611ca7b6750945278d4a639c22a149 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Tue Jun 21 18:01:36 2016 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal/rev/be815499ab611ca7b6750945278d4a639c22a149 [^] Fixed issue 0033238: Multi currency payments not working - Fix check payments logic to support correctly multicurrency, overpayments... - If we have a message ('not enough cash', 'overpayment'...) and Done button is disabled, we avoid user adding more payments till the issues is solved --- M src-db/database/sourcedata/AD_MESSAGE.xml M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0087756) hgbot (developer) 2016-06-21 18:18 |
Repository: retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal Changeset: b713c3eca1656d8fd5bdc56959c6a47e835471bf Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Tue Jun 21 18:11:59 2016 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal/rev/b713c3eca1656d8fd5bdc56959c6a47e835471bf [^] Fixed issue 0033238: Multi currency payments not working - Fix check payments logic to support correctly multicurrency, overpayments... - If we have a message ('not enough cash', 'overpayment'...) and Done button is disabled, we avoid user adding more payments till the issues is solved --- M src-db/database/sourcedata/AD_MESSAGE.xml M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/keyboard-toolbars.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0087779) hgbot (developer) 2016-06-22 10:08 |
Repository: retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal Changeset: a28da67403c9efbda6d3341f495ef3dfe3e66e9e Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Wed Jun 22 08:50:22 2016 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal/rev/a28da67403c9efbda6d3341f495ef3dfe3e66e9e [^] Fixed issue 0033238: Multi currency payments not working - Show no overpayment allowed when we added the payment, not before --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0087780) hgbot (developer) 2016-06-22 10:08 |
Repository: retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal Changeset: 0dc9e0ed7da94fc894efe3e0c0557a623b73ab77 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Wed Jun 22 08:50:22 2016 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal/rev/0dc9e0ed7da94fc894efe3e0c0557a623b73ab77 [^] Fixed issue 0033238: Multi currency payments not working - Show no overpayment allowed when we added the payment, not before --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0087781) hgbot (developer) 2016-06-22 10:09 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 3f14edc346d0ac2928fcdb0444b9e32f5b113477 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Wed Jun 22 08:50:22 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3f14edc346d0ac2928fcdb0444b9e32f5b113477 [^] Fixed issue 0033238: Multi currency payments not working - Show no overpayment allowed when we added the payment, not before --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0087841) hgbot (developer) 2016-06-23 07:45 |
Repository: tools/automation/pi-mobile Changeset: 440823640be86c376e65e481029ac96c4fdf5294 Author: Ranjith S R <ranjith <at> qualiantech.com> Date: Thu Jun 23 11:13:10 2016 +0530 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/440823640be86c376e65e481029ac96c4fdf5294 [^] Verifies issue 33238 : Added automated test 'I33238_VerifyMultiCurrencyReceipt' --- A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I33238_VerifyMultiCurrencyReceipt.java --- |
|
(0087886) marvintm (manager) 2016-06-24 10:38 |
It seems there is one case which is not correct: - Do cashup, and leave no cash in the till. - Create a ticket with one avalanche transceiver (total 150.50) - Pay with 200€ in cash. The message "There is not enough cash available" will be shown. This is correct. - Change payment method to Card. The same message appears. This is wrong, as this payment method is not of type cash, and in this case, it doesn't make sense to do the check. |
|
(0087889) marvintm (manager) 2016-06-24 12:08 |
Finally, the change done is correct. The Web POS does not support the ability to transform change obtained from an excessive payment in cash into a separate payment in non-cash payment method, only transformation between different cash payment methods is allowed. Thus, the check we are doing, which was implemented in the following issue: https://issues.openbravo.com/view.php?id=29463 [^] is correct. |
|
(0088254) hgbot (developer) 2016-07-06 20:40 |
Repository: retail/backports/3.0RR16Q2.1/pi-mobile Changeset: 29381eb60e5b715601b99a0b23ca02940036441d Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Wed Jul 06 13:56:27 2016 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.1/pi-mobile/rev/29381eb60e5b715601b99a0b23ca02940036441d [^] Related issue 33238: Adapt tests to new payment validation change - Change tests for new payments validation behaviour and alos for payment method button remain active feature --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/LayawayVerifyPaymentsInformation.java M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I31941_PaymentDataStoredAndRetrieved.java M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I31328_ReceiptReturnByCardPayment.java --- |
|
(0088255) hgbot (developer) 2016-07-06 20:41 |
Repository: retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal Changeset: cf5744eff4848ff574777caeae3ad0de86fe1ec3 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Wed Jul 06 13:36:15 2016 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal/rev/cf5744eff4848ff574777caeae3ad0de86fe1ec3 [^] Related issue 33238: Adapt tests to new payment validation change - Use isNegative instead of isReturn to cover void layaway case (void layaway is not return but it is negative) --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0088331) hgbot (developer) 2016-07-08 11:38 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: ace286f5f346d024a70e7081839b985cc0954114 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Fri Jul 08 11:36:31 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ace286f5f346d024a70e7081839b985cc0954114 [^] Related issue 33238: Adapt tests to new payment validation change - Use isNegative instead of isReturn to cover void layaway case (void layaway is not return but it is negative) --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0088369) hgbot (developer) 2016-07-11 13:19 |
Repository: tools/automation/pi-mobile Changeset: 29381eb60e5b715601b99a0b23ca02940036441d Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Wed Jul 06 13:56:27 2016 +0200 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/29381eb60e5b715601b99a0b23ca02940036441d [^] Related issue 33238: Adapt tests to new payment validation change - Change tests for new payments validation behaviour and alos for payment method button remain active feature --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/LayawayVerifyPaymentsInformation.java M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I31941_PaymentDataStoredAndRetrieved.java M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I31328_ReceiptReturnByCardPayment.java --- |
|
(0088383) hgbot (developer) 2016-07-12 11:16 |
Repository: retail/backports/3.0RR16Q3/org.openbravo.retail.posterminal Changeset: 2a334e8ea8e9d242fff33964bc86d90359028a12 Author: Miguel de Juana <miguel.dejuana <at> openbravo.com> Date: Fri Jul 08 11:36:31 2016 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR16Q3/org.openbravo.retail.posterminal/rev/2a334e8ea8e9d242fff33964bc86d90359028a12 [^] Related issue 33238: Adapt tests to new payment validation change - Use isNegative instead of isReturn to cover void layaway case (void layaway is not return but it is negative) --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js --- |
|
(0100488) hgbot (developer) 2017-11-13 15:23 |
Repository: tools/automation/pi-mobile Changeset: 7002313be0744816c06f53a60a4f758014cf3d22 Author: Rafael Queralta Pozo <rqueralta <at> nauta.cu> Date: Tue Oct 31 19:00:16 2017 -0400 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/7002313be0744816c06f53a60a4f758014cf3d22 [^] Related issue 33238: Adapt tests to new payment validation change --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I33238_VerifyMultiCurrencyReceipt.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-06-13 16:18 | egoitz | New Issue | |
| 2016-06-13 16:18 | egoitz | Assigned To | => Retail |
| 2016-06-13 16:18 | egoitz | Resolution time | => 1466028000 |
| 2016-06-13 16:18 | egoitz | Regression level | => Production - Confirmed Stable |
| 2016-06-13 16:18 | egoitz | Triggers an Emergency Pack | => No |
| 2016-06-13 17:58 | marvintm | Status | new => scheduled |
| 2016-06-13 18:16 | marvintm | Status | scheduled => acknowledged |
| 2016-06-14 11:49 | malsasua | Steps to Reproduce Updated | View Revisions |
| 2016-06-14 12:21 | ranjith_qualiantech_com | Assigned To | Retail => ranjith_qualiantech_com |
| 2016-06-14 12:21 | ranjith_qualiantech_com | Status | acknowledged => scheduled |
| 2016-06-14 12:21 | ranjith_qualiantech_com | Relationship added | caused by 0031328 |
| 2016-06-16 10:17 | ranjith_qualiantech_com | Note Added: 0087331 | |
| 2016-06-20 05:13 | ranjith_qualiantech_com | Assigned To | ranjith_qualiantech_com => migueldejuana |
| 2016-06-20 12:59 | hgbot | Checkin | |
| 2016-06-20 12:59 | hgbot | Note Added: 0087665 | |
| 2016-06-20 12:59 | hgbot | Status | scheduled => resolved |
| 2016-06-20 12:59 | hgbot | Resolution | open => fixed |
| 2016-06-20 12:59 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/51f7e7346e5ba0b1be62d75d0c481518af367d47 [^] |
| 2016-06-20 12:59 | hgbot | Checkin | |
| 2016-06-20 12:59 | hgbot | Note Added: 0087666 | |
| 2016-06-20 13:03 | migueldejuana | Note Added: 0087667 | |
| 2016-06-21 18:02 | hgbot | Checkin | |
| 2016-06-21 18:02 | hgbot | Note Added: 0087753 | |
| 2016-06-21 18:02 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/51f7e7346e5ba0b1be62d75d0c481518af367d47 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal/rev/be815499ab611ca7b6750945278d4a639c22a149 [^] |
| 2016-06-21 18:18 | hgbot | Checkin | |
| 2016-06-21 18:18 | hgbot | Note Added: 0087756 | |
| 2016-06-21 18:18 | hgbot | Fixed in SCM revision | http://code.openbravo.com/retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal/rev/be815499ab611ca7b6750945278d4a639c22a149 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal/rev/b713c3eca1656d8fd5bdc56959c6a47e835471bf [^] |
| 2016-06-22 10:08 | hgbot | Checkin | |
| 2016-06-22 10:08 | hgbot | Note Added: 0087779 | |
| 2016-06-22 10:08 | hgbot | Fixed in SCM revision | http://code.openbravo.com/retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal/rev/b713c3eca1656d8fd5bdc56959c6a47e835471bf [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal/rev/a28da67403c9efbda6d3341f495ef3dfe3e66e9e [^] |
| 2016-06-22 10:08 | hgbot | Checkin | |
| 2016-06-22 10:08 | hgbot | Note Added: 0087780 | |
| 2016-06-22 10:08 | hgbot | Fixed in SCM revision | http://code.openbravo.com/retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal/rev/a28da67403c9efbda6d3341f495ef3dfe3e66e9e [^] => http://code.openbravo.com/retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal/rev/0dc9e0ed7da94fc894efe3e0c0557a623b73ab77 [^] |
| 2016-06-22 10:09 | hgbot | Checkin | |
| 2016-06-22 10:09 | hgbot | Note Added: 0087781 | |
| 2016-06-22 10:09 | hgbot | Fixed in SCM revision | http://code.openbravo.com/retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal/rev/0dc9e0ed7da94fc894efe3e0c0557a623b73ab77 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3f14edc346d0ac2928fcdb0444b9e32f5b113477 [^] |
| 2016-06-23 07:45 | hgbot | Checkin | |
| 2016-06-23 07:45 | hgbot | Note Added: 0087841 | |
| 2016-06-24 10:38 | marvintm | Note Added: 0087886 | |
| 2016-06-24 10:38 | marvintm | Status | resolved => new |
| 2016-06-24 10:38 | marvintm | Resolution | fixed => open |
| 2016-06-24 10:38 | marvintm | Status | new => scheduled |
| 2016-06-24 12:08 | marvintm | Note Added: 0087889 | |
| 2016-06-24 12:08 | marvintm | Status | scheduled => resolved |
| 2016-06-24 12:08 | marvintm | Resolution | open => fixed |
| 2016-06-24 12:09 | marvintm | Review Assigned To | => marvintm |
| 2016-06-24 12:09 | marvintm | Status | resolved => closed |
| 2016-07-06 20:40 | hgbot | Checkin | |
| 2016-07-06 20:40 | hgbot | Note Added: 0088254 | |
| 2016-07-06 20:41 | hgbot | Checkin | |
| 2016-07-06 20:41 | hgbot | Note Added: 0088255 | |
| 2016-07-08 09:25 | migueldejuana | Relationship added | related to 0033453 |
| 2016-07-08 11:38 | hgbot | Checkin | |
| 2016-07-08 11:38 | hgbot | Note Added: 0088331 | |
| 2016-07-11 13:19 | hgbot | Checkin | |
| 2016-07-11 13:19 | hgbot | Note Added: 0088369 | |
| 2016-07-12 11:16 | hgbot | Checkin | |
| 2016-07-12 11:16 | hgbot | Note Added: 0088383 | |
| 2017-06-07 17:22 | migueldejuana | Relationship added | related to 0035830 |
| 2017-11-13 15:23 | hgbot | Checkin | |
| 2017-11-13 15:23 | hgbot | Note Added: 0100488 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |