Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0033211
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2016-06-09 18:122016-06-17 09:21
ReportergorkaionView Statuspublic 
Assigned Togorkaion 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionb165e55e3afc
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionpiSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033211: Bad performance of ProductListEventHandler evenhandler

DescriptionThis event handler populates the Product Category list of an assortment when products are added to it.

It checks that the new product's category is not already included and add it in case it is necessary.

The process is not considering high volumes of product categories and can be optimized.
Steps To ReproduceRemove unneeded list() and loops by single HQL query.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0087145)
hgbot (developer)
2016-06-09 18:17

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b165e55e3afcd7975df2624a25140569cbc086b1
Author: Gorka Ion Damián <gorkaion.damian <at> openbravo.com>
Date: Thu Jun 09 18:16:49 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b165e55e3afcd7975df2624a25140569cbc086b1 [^]

Fixed issue 33211.Fix performance issues.

- Changed loop through existing categories by a single query.
- Do not load in memory objects if it is not necessary by using Proxies.
- Create a new addProductCategoryToAssortment method to avoid duplicated code.

---
M src/org/openbravo/retail/posterminal/event/ProductListEventHandler.java
---

- Issue History
Date Modified Username Field Change
2016-06-09 18:12 gorkaion New Issue
2016-06-09 18:12 gorkaion Assigned To => gorkaion
2016-06-09 18:12 gorkaion Triggers an Emergency Pack => No
2016-06-09 18:13 gorkaion Review Assigned To => marvintm
2016-06-09 18:17 hgbot Checkin
2016-06-09 18:17 hgbot Note Added: 0087145
2016-06-09 18:17 hgbot Status new => resolved
2016-06-09 18:17 hgbot Resolution open => fixed
2016-06-09 18:17 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b165e55e3afcd7975df2624a25140569cbc086b1 [^]
2016-06-17 09:21 marvintm Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker