Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0033184 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | minor | have not tried | 2016-06-07 19:20 | 2018-02-27 18:30 | |||
Reporter | shuehner | View Status | public | |||||
Assigned To | Sandrahuguet | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | RR18Q2 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 8060f90a626c | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | marvintm | |||||||
OBNetwork customer | No | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0033184: OrderLoader does accidental 2*flush during TriggerHandler enable | |||||||
Description | The saveRecord function contains: OBDal.getInstance().flush(); TriggerHandler.getInstance().enable(); The enable function itself does a flush already (via getConnection() ) so doing a flush before is not useful. That explicit flush should be removed and replaced by a comment (noting the implicit flush) | |||||||
Steps To Reproduce | 29476 [Import Entry - 1] INFO org.openbravo.dal.service.OBDal - Flush of 334 entities and 2835 collections took: 11 java.lang.Throwable at org.openbravo.dal.service.OBDal.flush(OBDal.java:210) at org.openbravo.dal.service.OBDal.getConnection(OBDal.java:146) at org.openbravo.dal.service.OBDal.getConnection(OBDal.java:130) at org.openbravo.dal.core.TriggerHandler.enable(TriggerHandler.java:104) at org.openbravo.retail.posterminal.OrderLoader.saveRecord(OrderLoader.java:460) | |||||||
Tags | Performance | |||||||
Attached Files | ||||||||
![]() |
|
![]() |
|
(0102831) hgbot (developer) 2018-02-26 08:41 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 8060f90a626cc4b81bb23143bdeb0d718dd01b40 Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Wed Feb 07 12:51:16 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8060f90a626cc4b81bb23143bdeb0d718dd01b40 [^] Fixed issue 33184 delete duplicate flush --- M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
![]() |
|||
Date Modified | Username | Field | Change |
2016-06-07 19:20 | shuehner | New Issue | |
2016-06-07 19:20 | shuehner | Assigned To | => Retail |
2016-06-07 19:20 | shuehner | OBNetwork customer | => No |
2016-06-07 19:20 | shuehner | Triggers an Emergency Pack | => No |
2016-06-07 19:20 | shuehner | Tag Attached: Performance | |
2018-02-07 13:20 | Sandrahuguet | Assigned To | Retail => Sandrahuguet |
2018-02-26 08:41 | hgbot | Checkin | |
2018-02-26 08:41 | hgbot | Note Added: 0102831 | |
2018-02-26 08:41 | hgbot | Status | new => resolved |
2018-02-26 08:41 | hgbot | Resolution | open => fixed |
2018-02-26 08:41 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8060f90a626cc4b81bb23143bdeb0d718dd01b40 [^] |
2018-02-27 16:11 | Sandrahuguet | Review Assigned To | => marvintm |
2018-02-27 18:30 | marvintm | Status | resolved => closed |
2018-02-27 18:30 | marvintm | Fixed in Version | => RR18Q2 |
Copyright © 2000 - 2009 MantisBT Group |