Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0033183
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2016-06-07 18:442017-11-30 09:45
ReportershuehnerView Statuspublic 
Assigned ToSandrahuguet 
PrioritynormalResolutionfixedFixed in VersionRR16Q4
StatusclosedFix in branchFixed in SCM revisionb8e1db64b56e
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033183: OrderLoader.verifyOrderExistance function should no longer be required

DescriptionThat function checks 2 things:

a.) Order with same uuid does not already exist
b.) Order with same uuid exists but is not a duplicate (by having different documentno).

The check of a.) is today already done in DataSynchronizationProcess so not required to be don again here.

The check of b.) is a workaround against a very old bug in client side uuid generation which lead to duplicate values sometimes.
As that has been fixed on the client-side a long time as the need for b.) also disappeared.
Steps To Reproduce-
TagsPerformance
Attached Files

- Relationships Relation Graph ] Dependency Graph ]

-  Notes
(0089642)
shuehner (administrator)
2016-09-01 11:16

Note: InvoiceLoader.java (only exists in but-dev-branch) has copy of tht function called checkInvoiceExistance. That copy should probably be simplified also.
(0090005)
hgbot (developer)
2016-09-16 08:16

Repository: tools/automation/pi-mobile
Changeset: 956a6015c0ad908580ad67abc0bfbf9f071bf9a9
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Thu Sep 15 15:53:04 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/956a6015c0ad908580ad67abc0bfbf9f071bf9a9 [^]

related to issue 33183 added a new check and allowed tomcat error

---
M src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/DuplicatedTicketAreSavedProperly.java
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/sales/EquivalentTicketsSavedCorrectly.java
---
(0090006)
hgbot (developer)
2016-09-16 08:17

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d6c57e186028adf1c34d517ad9fc6a533a6ba5f4
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Sep 07 16:10:38 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d6c57e186028adf1c34d517ad9fc6a533a6ba5f4 [^]

Fixed issue 33183 verifyOrderExistance function should no longer be required

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0090374)
hgbot (developer)
2016-09-29 14:11

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 030b6351be9367d361105ef83d823ad764f36f7c
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Thu Sep 29 14:11:33 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/030b6351be9367d361105ef83d823ad764f36f7c [^]

Related to issue 33183. Improved method name for greater clarity of its purpose.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---
(0090691)
airaceburu (reporter)
2016-10-19 10:13
edited on: 2016-10-19 10:13

reopened by error


- Issue History
Date Modified Username Field Change
2016-06-07 18:44 shuehner New Issue
2016-06-07 18:44 shuehner Assigned To => Retail
2016-06-07 18:44 shuehner Triggers an Emergency Pack => No
2016-06-07 18:44 shuehner Tag Attached: Performance
2016-09-01 10:14 Sandrahuguet Status new => scheduled
2016-09-01 10:14 Sandrahuguet Assigned To Retail => Sandrahuguet
2016-09-01 11:16 shuehner Note Added: 0089642
2016-09-07 16:28 Sandrahuguet Review Assigned To => marvintm
2016-09-16 08:16 hgbot Checkin
2016-09-16 08:16 hgbot Note Added: 0090005
2016-09-16 08:17 hgbot Checkin
2016-09-16 08:17 hgbot Note Added: 0090006
2016-09-16 08:17 hgbot Status scheduled => resolved
2016-09-16 08:17 hgbot Resolution open => fixed
2016-09-16 08:17 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d6c57e186028adf1c34d517ad9fc6a533a6ba5f4 [^]
2016-09-29 14:11 hgbot Checkin
2016-09-29 14:11 hgbot Note Added: 0090374
2016-09-29 14:12 marvintm Status resolved => closed
2016-10-19 10:06 hgbot Checkin
2016-10-19 10:06 hgbot Note Added: 0090690
2016-10-19 10:06 hgbot Status closed => resolved
2016-10-19 10:06 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d6c57e186028adf1c34d517ad9fc6a533a6ba5f4 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b8e1db64b56e26aac5a73eca573e5102c314aac5 [^]
2016-10-19 10:13 airaceburu Note Added: 0090691
2016-10-19 10:13 airaceburu Status resolved => closed
2016-10-19 10:13 airaceburu Note Edited: 0090691 View Revisions
2016-10-19 10:17 airaceburu Note Deleted: 0090690
2017-11-30 09:45 shuehner Fixed in Version => RR16Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker