Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||||||
ID | ||||||||||||
0033181 | ||||||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||||||
defect | [Retail Modules] Web POS | minor | have not tried | 2016-06-07 18:38 | 2016-06-07 18:41 | |||||||
Reporter | shuehner | View Status | public | |||||||||
Assigned To | Retail | |||||||||||
Priority | normal | Resolution | open | Fixed in Version | ||||||||
Status | new | Fix in branch | Fixed in SCM revision | |||||||||
Projection | none | ETA | none | Target Version | ||||||||
OS | Any | Database | Any | Java version | ||||||||
OS Version | Database version | Ant version | ||||||||||
Product Version | SCM revision | |||||||||||
Review Assigned To | ||||||||||||
Regression level | ||||||||||||
Regression date | ||||||||||||
Regression introduced in release | ||||||||||||
Regression introduced by commit | ||||||||||||
Triggers an Emergency Pack | No | |||||||||||
Summary | 0033181: Most OrderLoader insert flush() 'ed' during call to getStock which is non-obvious and breaks debug timing | |||||||||||
Description | OrderLoader schedules many insert (order,lines,tax,lines-tax) and next DAL flush will only execute the corresponding SQL's. Currently that next DAL-flush happening is the one very hidden inside StockUtils.getStock which does a flush on its own. On top of being very non-obvious where the inserts happen that leads to the time the 'inserts' in the database take to be attributed to the 'getStock' section in the performance time logging of the OrderLoader. Also that flush in getStock triggers a flush per getStock call ( in practice per line of the Order) which is not required. I suggest to add a single clear flush() in the orderLoader itself to be able to clearly report take this one takes. The 'flush' happens in the StockUtils function should be made optional (will be logged as separate issue and linked to this one). A possible location to add the new flush() in the OrderLoader could be just before the 'createShipmentLines' function call. | |||||||||||
Steps To Reproduce | - | |||||||||||
Tags | Performance | |||||||||||
Attached Files | ||||||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | |||||||||
|
Issue History | |||
Date Modified | Username | Field | Change |
2016-06-07 18:38 | shuehner | New Issue | |
2016-06-07 18:38 | shuehner | Assigned To | => Retail |
2016-06-07 18:38 | shuehner | Triggers an Emergency Pack | => No |
2016-06-07 18:38 | shuehner | Tag Attached: Performance | |
2016-06-07 18:41 | shuehner | Relationship added | related to 0033182 |
Copyright © 2000 - 2009 MantisBT Group |