0033181: Most OrderLoader insert flush() 'ed' during call to getStock which is non-obvious and breaks debug timing

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0033181

Retail Modules

Web POS

public

2016-06-07 18:38

2016-06-07 18:41

Reporter

shuehner

Assigned To

Retail

Priority

normal

Severity

minor

Reproducibility

have not tried

Status

new

Resolution

open

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0033181: Most OrderLoader insert flush() 'ed' during call to getStock which is non-obvious and breaks debug timing

Description

OrderLoader schedules many insert (order,lines,tax,lines-tax) and next DAL flush will only execute the corresponding SQL's.

Currently that next DAL-flush happening is the one very hidden inside StockUtils.getStock which does a flush on its own.

On top of being very non-obvious where the inserts happen that leads to the time the 'inserts' in the database take to be attributed to the 'getStock' section in the performance time logging of the OrderLoader.

Also that flush in getStock triggers a flush per getStock call ( in practice per line of the Order) which is not required.

I suggest to add a single clear flush() in the orderLoader itself to be able to clearly report take this one takes.

The 'flush' happens in the StockUtils function should be made optional (will be logged as separate issue and linked to this one).

A possible location to add the new flush() in the OrderLoader could be just before the 'createShipmentLines' function call.

Steps To Reproduce

Proposed Solution

Additional Information