Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033176 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Web POS | minor | have not tried | 2016-06-07 18:07 | 2018-03-19 09:27 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | Sandrahuguet | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR18Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 0050c49b4a1f | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | marvintm | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033176: OrderLoader countPayments functions is called to often (once per payment) | |||||||
| Description | The countPayments functions which counts all payment related to the order being processed is called in a loop per payment present in the Order. That seems to not be required as the code can easily know how many payments it created (via the loop) so should only need to query some initial payment-count once before the loop (to find any possible payments created before this orderloader invocation). Then it could use this startcount + simple add a counter to get unique DocumentNo. | |||||||
| Steps To Reproduce | Configure POS to use useOrderDocumentNoForRelatedDocs preference to use that code-path. Add item to webpos cart. Use 2 different payments methods to pay this ticket i.e. 5€ cash + rest 'credit'. | |||||||
| Tags | Performance | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0103263) hgbot (developer) 2018-03-15 08:23 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 0050c49b4a1f375b764ecfb881d2120606e9a8e6 Author: Sandra Huguet <sandra.huguet <at> openbravo.com> Date: Wed Mar 14 09:07:31 2018 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0050c49b4a1f375b764ecfb881d2120606e9a8e6 [^] fixed issue 33176 call to countPayments only once time during orderloader --- M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-06-07 18:07 | shuehner | New Issue | |
| 2016-06-07 18:07 | shuehner | Assigned To | => Retail |
| 2016-06-07 18:07 | shuehner | Triggers an Emergency Pack | => No |
| 2016-06-07 18:07 | shuehner | Relationship added | related to 0033123 |
| 2016-06-07 18:07 | shuehner | Tag Attached: Performance | |
| 2018-03-14 13:14 | Sandrahuguet | Assigned To | Retail => Sandrahuguet |
| 2018-03-14 15:19 | Sandrahuguet | Review Assigned To | => marvintm |
| 2018-03-15 08:23 | hgbot | Checkin | |
| 2018-03-15 08:23 | hgbot | Note Added: 0103263 | |
| 2018-03-15 08:23 | hgbot | Status | new => resolved |
| 2018-03-15 08:23 | hgbot | Resolution | open => fixed |
| 2018-03-15 08:23 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0050c49b4a1f375b764ecfb881d2120606e9a8e6 [^] |
| 2018-03-19 09:27 | marvintm | Status | resolved => closed |
| 2018-03-19 09:27 | marvintm | Fixed in Version | => RR18Q2 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |