Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033090
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminoralways2016-05-31 16:172017-05-16 17:11
ReporterOrekariaView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionopenFixed in Version
StatusacknowledgedFix in branchFixed in SCM revision96b1af1bf79a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033090: UI glitches in the payment area

DescriptionUI glitches in the payment area
Steps To ReproduceSee video:
http://screencast.com/t/LjYtjbgLrQE [^]
TagsNo tags attached.
Attached Filesjpg file icon GAL_screenshoot_Selection_410.jpg [^] (174,287 bytes) 2016-06-20 19:33

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on defect 0032928 closedmario_castello [SERQA 1078] No enough space for the payment method name and its info 

-  Notes
(0086965)
hgbot (developer)
2016-06-02 21:54

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 3ca7a68129942478f771b2053f65472328e5035d
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Jun 01 07:57:57 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3ca7a68129942478f771b2053f65472328e5035d [^]

Fixed issue 33090: Added some changes to paymentLines views to accept different resolutions

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0086978)
migueldejuana (developer)
2016-06-03 10:21

 - Payment name and remove button are not vertically centered
- Remove button change its size when resizing window
- I would separate more remove button from scroll
(0087045)
umartirena (reporter)
2016-06-07 09:28

 After the last change we are facing an issue when trying to hide Remove Payment button due to a new development. remove.hide() "display:none" it does not work because it is overridden with "display:block".

It also there is a problem when adding new buttons. Before the change if one button was hidden the second one was appearing in the place of the first one. Now it appears right after the first one even if is hidden.

See the video: http://www.screencast.com/t/afOpUg5jNg9 [^]
(0087256)
hgbot (developer)
2016-06-14 15:55
edited on: 2016-06-14 15:58

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 078739cca62ce091ea736141ef2b5d6bc748d635
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Jun 14 07:52:58 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/078739cca62ce091ea736141ef2b5d6bc748d635 [^]

Related to issue 33090: Added changes to removePayment button in payment lines

Delete "display:block" to allow hide the button.
Added name and margin to the button.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0087637)
hgbot (developer)
2016-06-17 20:10
edited on: 2016-06-17 20:19

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: b25b20d8db0129c534cc70c8b6bd154b0a29c1ec
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Jun 16 10:44:48 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b25b20d8db0129c534cc70c8b6bd154b0a29c1ec [^]

Fixed issue 33090: Added changes to button removePayment in payment lines view

Added margin when the second row show information.
The Payment name can not be centralized because can be affected the information in the second row.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0087687)
guilleaer (manager)
2016-06-20 19:33

 When the width is close to 800px but we are working in a single column view the remove button is not alligned to the right side.

Attached screenshot (GAL_screenshoot_Selection_410)
(0087758)
hgbot (developer)
2016-06-21 21:01

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 96b1af1bf79a5bcd3de438bee8f2b5095737f8ed
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Jun 21 13:00:29 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/96b1af1bf79a5bcd3de438bee8f2b5095737f8ed [^]

Fixed issue 33090: Delete max-width from other component and align to right the button removePayment line

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0087776)
migueldejuana (developer)
2016-06-22 08:41

 Tested and reviewed
(0090832)
dbaz (developer)
2016-10-24 22:01
edited on: 2016-10-25 12:56

 1. Payments Area min-width should be 325px, even on smartphones.
2. Cancel Payment Button width should be always the same (45px)
3. Cancel Payment Button should be always vertically centered
4. Complete Payment Button height: the payments area should never hit this button, so it should be always above this area.
5. The separation between the payed amount and the Cancel Payment Button should be always the same (~ 11px)

http://screencast.com/t/Pwd3Iq4XNut [^]
(0090834)
mario_castello (developer)
2016-10-25 00:27

 You are considering a single button, try with a layaway order type that have more than one button.
(0090855)
dbaz (developer)
2016-10-25 11:16
edited on: 2016-10-25 12:56

 Thanks Mario, you are completly right.

Then, the pending points are:

1. Cancel Payment Button width should be always the same (45px)
2. Cancel Payment Button should be always vertically centered
3. The separation between the payed amount and the Cancel Payment Button should be always the same (~ 11px)

and due to this last minute change, I have to add I new one:

4. There should not be line break in the currency conversion field if the 'More Information' field is not present or is empty. Also, if the 'More Information' text is too long, and the currency conversion field is not present, the line break of this long 'More Information' text should happen near the 'Cancel Payment' button.
If both 'More Information' and currency conversion fields are present (not empty), then the current table layout is ok.

http://screencast.com/t/UzfYsXK12Nt [^]

- Issue History
Date Modified Username Field Change
2016-05-31 16:17 Orekaria New Issue
2016-05-31 16:17 Orekaria Assigned To => Retail
2016-05-31 16:17 Orekaria Triggers an Emergency Pack => No
2016-05-31 16:18 Orekaria Relationship added depends on 0032928
2016-05-31 17:52 mario_castello Assigned To Retail => mario_castello
2016-05-31 17:53 mario_castello Status new => acknowledged
2016-05-31 17:53 mario_castello Status acknowledged => scheduled
2016-06-02 21:54 hgbot Checkin
2016-06-02 21:54 hgbot Note Added: 0086965
2016-06-02 21:54 hgbot Status scheduled => resolved
2016-06-02 21:54 hgbot Resolution open => fixed
2016-06-02 21:54 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3ca7a68129942478f771b2053f65472328e5035d [^]
2016-06-03 10:21 migueldejuana Note Added: 0086978
2016-06-03 10:21 migueldejuana Status resolved => new
2016-06-03 10:21 migueldejuana Resolution fixed => open
2016-06-07 09:28 umartirena Note Added: 0087045
2016-06-07 09:36 migueldejuana Status new => scheduled
2016-06-14 15:55 hgbot Checkin
2016-06-14 15:55 hgbot Note Added: 0087256
2016-06-14 15:58 mario_castello Note Edited: 0087256 View Revisions
2016-06-16 16:40 migueldejuana File Added: Screenshot from 2016-06-16 16:39:11.png
2016-06-16 16:40 migueldejuana File Deleted: Screenshot from 2016-06-16 16:39:11.png
2016-06-17 20:10 hgbot Checkin
2016-06-17 20:10 hgbot Note Added: 0087637
2016-06-17 20:10 hgbot Status scheduled => resolved
2016-06-17 20:10 hgbot Resolution open => fixed
2016-06-17 20:10 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/3ca7a68129942478f771b2053f65472328e5035d [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b25b20d8db0129c534cc70c8b6bd154b0a29c1ec [^]
2016-06-17 20:16 mario_castello Note Edited: 0087637 View Revisions
2016-06-17 20:19 mario_castello Note Edited: 0087637 View Revisions
2016-06-20 19:33 guilleaer Note Added: 0087687
2016-06-20 19:33 guilleaer Status resolved => new
2016-06-20 19:33 guilleaer Resolution fixed => open
2016-06-20 19:33 guilleaer Status new => scheduled
2016-06-20 19:33 guilleaer File Added: GAL_screenshoot_Selection_410.jpg
2016-06-21 21:01 hgbot Checkin
2016-06-21 21:01 hgbot Note Added: 0087758
2016-06-21 21:01 hgbot Status scheduled => resolved
2016-06-21 21:01 hgbot Resolution open => fixed
2016-06-21 21:01 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b25b20d8db0129c534cc70c8b6bd154b0a29c1ec [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/96b1af1bf79a5bcd3de438bee8f2b5095737f8ed [^]
2016-06-22 08:41 migueldejuana Review Assigned To => migueldejuana
2016-06-22 08:41 migueldejuana Note Added: 0087776
2016-06-22 08:41 migueldejuana Status resolved => closed
2016-10-24 22:01 dbaz Note Added: 0090832
2016-10-24 22:01 dbaz Status closed => new
2016-10-24 22:01 dbaz Resolution fixed => open
2016-10-25 00:26 mario_castello Assigned To mario_castello => dbaz
2016-10-25 00:27 mario_castello Note Added: 0090834
2016-10-25 00:27 mario_castello Status new => feedback
2016-10-25 11:16 dbaz Note Added: 0090855
2016-10-25 11:16 dbaz Assigned To dbaz => mario_castello
2016-10-25 11:16 dbaz Status feedback => new
2016-10-25 12:54 dbaz Note Edited: 0090855 View Revisions
2016-10-25 12:55 dbaz Note Edited: 0090832 View Revisions
2016-10-25 12:56 dbaz Note Edited: 0090855 View Revisions
2016-10-25 12:56 dbaz Note Edited: 0090832 View Revisions
2016-10-25 15:53 mario_castello Status new => acknowledged
2017-05-16 17:11 mario_castello Assigned To mario_castello => Retail

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker