0033070: Unused variables in pl code

Description

This module has a pl function obpos_fixissue25555

which declares 2 variables but never uses them.

Steps To Reproduce

Proposed Solution

Delete the unused variables

Tags

No tags attached.

Attached Files

33070.diff [^] (778 bytes) 2016-05-27 13:47 [Show Content] [Hide Content]

diff -r 75ca473759a8 src-db/database/model/functions/OBPOS_FIXISSUE25555.xml
--- a/src-db/database/model/functions/OBPOS_FIXISSUE25555.xml	Tue May 17 08:43:57 2016 +0200
+++ b/src-db/database/model/functions/OBPOS_FIXISSUE25555.xml	Fri May 27 13:47:24 2016 +0200
@@ -3,7 +3,6 @@
     <function name="OBPOS_FIXISSUE25555" type="NULL">
       <body><![CDATA[TYPE RECORD IS REF CURSOR;
 v_candidateInvoices RECORD;
-v_wrongPaymentSched RECORD;
 cursor1 RECORD;
 v_needToExecute NUMBER:=0;
 v_isWrongInvoice NUMBER:=0;
@@ -12,7 +11,6 @@
 v_paymentSchedDet1 character varying(32);
 v_paymentSched2 character varying(32);
 v_order1 character varying(32);
-v_numWrongInvoicesByOrder NUMBER:=0;
 v_numOfPaymentSched NUMBER:=0;
 v_numOfPaymentSched2 NUMBER:=0;
 sumGrandTotal NUMBER:=0;

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0086785) shuehner (administrator) 2016-05-27 13:47	Note: When checking code careful pl is case-insensitive. So when checking for users of the variable search without checking case for its name.

(0087066) hgbot (developer) 2016-06-07 16:24	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: ec3c157b407c50eab9e797a4f869de3898b3eb00 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Fri Jun 03 14:42:43 2016 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ec3c157b407c50eab9e797a4f869de3898b3eb00 [^] Fixed issue 33070: Delete unused variables in pl code --- M src-db/database/model/functions/OBPOS_FIXISSUE25555.xml ---

Issue History
Date Modified	Username	Field	Change
2016-05-27 13:47	shuehner	New Issue
2016-05-27 13:47	shuehner	Assigned To	=> Retail
2016-05-27 13:47	shuehner	OBNetwork customer	=> No
2016-05-27 13:47	shuehner	Triggers an Emergency Pack	=> No
2016-05-27 13:47	shuehner	File Added: 33070.diff
2016-05-27 13:47	shuehner	Note Added: 0086785
2016-06-02 17:49	Orekaria	Status	new => acknowledged
2016-06-03 23:06	mario_castello	Assigned To	Retail => mario_castello
2016-06-07 16:24	hgbot	Checkin
2016-06-07 16:24	hgbot	Note Added: 0087066
2016-06-07 16:24	hgbot	Status	acknowledged => resolved
2016-06-07 16:24	hgbot	Resolution	open => fixed
2016-06-07 16:24	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ec3c157b407c50eab9e797a4f869de3898b3eb00 [^]
2016-06-15 19:15	marvintm	Review Assigned To	=> marvintm
2016-06-15 19:15	marvintm	Status	resolved => closed