Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0033066 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 07. Sales management | major | always | 2016-05-27 10:17 | 2016-06-17 19:38 | |||
| Reporter | JONHM | View Status | public | |||||
| Assigned To | Sanjota | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | 3.0PR16Q3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 30c157cff610 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | aferraz | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0033066: PL function "c_order_post1" does not take "recalculateDiscounts" parameter when passing a pInstance | |||||||
| Description | When passing a pInstance to a c_order_post1 PL funciton, it calculates the discounts automatically, omitting the third parameter of the function. | |||||||
| Steps To Reproduce | As you can see in the c_order_post1 function, if you don't use a pInstance, you can pass the third parameter (calculate discounts), but if you use a pInstance instead the parameter is omitted. We need to check the parameter into the table if a pInstance is used. | |||||||
| Proposed Solution | Add a conditional checking the calculateDiscounts parameter into the table: https://code.openbravo.com/erp/devel/pi/file/65a012587054/src-db/database/model/functions/C_ORDER_POST1.xml#l148 [^] - LOOP - v_Record_ID:=Cur_Parameter.Record_ID; - v_User:=Cur_Parameter.AD_User_ID; - END LOOP; -- Get Parameter + LOOP + v_Record_ID:=Cur_Parameter.Record_ID; + v_User:=Cur_Parameter.AD_User_ID; + IF(Cur_Parameter.ParameterName='recalculateDiscounts') THEN + v_recalculateDiscounts:=Cur_Parameter.P_String; + END IF; + END LOOP; -- Get Parameter | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0087095) Sanjota (developer) 2016-06-08 17:14 |
Test Plan: * Create order for the products with discount. * Process order * Observe that c_order_post1 will take "recalculateDiscounts" parameter even while passing a pInstance |
|
(0087163) hgbot (developer) 2016-06-10 14:36 |
Repository: erp/devel/pi Changeset: 30c157cff610cbb9099e700b0e84d7445db93a4d Author: Sanjota <sanjota.nelagi <at> promantia.com> Date: Wed Jun 08 19:52:27 2016 +0530 URL: http://code.openbravo.com/erp/devel/pi/rev/30c157cff610cbb9099e700b0e84d7445db93a4d [^] Fixes issue 33066: Fix to recalculateDiscounts issue in C_Order_Post1 function When passing a pInstance to a c_order_post1 PL funciton, it calculates the discounts automatically, omitting the third parameter of the function. --- M src-db/database/model/functions/C_ORDER_POST1.xml --- |
|
(0087164) aferraz (manager) 2016-06-10 14:40 |
Code review + Testing OK |
|
(0087603) hudsonbot (developer) 2016-06-17 19:38 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^] Maturity status: Test |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-05-27 10:17 | JONHM | New Issue | |
| 2016-05-27 10:17 | JONHM | Assigned To | => Triage Finance |
| 2016-05-27 10:17 | JONHM | Modules | => Core |
| 2016-05-27 10:17 | JONHM | Resolution time | => 1467151200 |
| 2016-05-27 10:17 | JONHM | Triggers an Emergency Pack | => No |
| 2016-05-31 17:16 | aferraz | Assigned To | Triage Finance => Sanjota |
| 2016-06-08 17:09 | Sanjota | Status | new => scheduled |
| 2016-06-08 17:14 | Sanjota | Note Added: 0087095 | |
| 2016-06-10 14:36 | hgbot | Checkin | |
| 2016-06-10 14:36 | hgbot | Note Added: 0087163 | |
| 2016-06-10 14:36 | hgbot | Status | scheduled => resolved |
| 2016-06-10 14:36 | hgbot | Resolution | open => fixed |
| 2016-06-10 14:36 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/30c157cff610cbb9099e700b0e84d7445db93a4d [^] |
| 2016-06-10 14:40 | aferraz | Review Assigned To | => aferraz |
| 2016-06-10 14:40 | aferraz | Note Added: 0087164 | |
| 2016-06-10 14:40 | aferraz | Status | resolved => closed |
| 2016-06-10 14:40 | aferraz | Fixed in Version | => 3.0PR16Q3 |
| 2016-06-17 19:38 | hudsonbot | Checkin | |
| 2016-06-17 19:38 | hudsonbot | Note Added: 0087603 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |