Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033028
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-05-23 16:442016-06-22 08:37
ReporteramayavicenteView Statuspublic 
Assigned Tomario_castello 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision081608e4dbd9
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomigueldejuana
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033028: [SERQA 1145] It is possible to create negative quotation from WebPOS

DescriptionIt is possible to create negative quotation from WebPOS
Steps To ReproduceCase 1:
1. Log into VBS-1
2. In the menu, click Create Quotation. Don't add products.
3. In the menu, open Verified Return, select any ticket and clck Apply. Negative lines are included in the quotation.
4. Confirm the quotation.

Case 2:
1. Log into VBS-1
2. In the menu, click Create Quotation.
3. Add 1 unit of any product.
4. In the numeric keyboard, click '2' and after click '-'. The quatity of the line is now -1.
5. Confirm the quotation.
Proposed SolutionDon't allow negative quotation from webpos, it has not sense.
TagsSER-QA
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0086748)
hgbot (developer)
2016-05-25 16:26

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 030e3880653dfbdc8786ad11206e59f021e86060
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue May 24 11:13:08 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/030e3880653dfbdc8786ad11206e59f021e86060 [^]

Fixed issue 33028: Added validation in setUnit that not allows negative quantity for quotation

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0086749)
hgbot (developer)
2016-05-25 16:38

 Repository: erp/pmods/org.openbravo.retail.returns
Changeset: c3c80f65e97b49ff3bafe87a8785191164df5cde
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue May 24 11:10:24 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c3c80f65e97b49ff3bafe87a8785191164df5cde [^]

Related to issue 33028: Added validation to hide verified return menu option when the receipt is a quotation

---
M web/org.openbravo.retail.returns/js/returnReceiptButton.js
---
(0086898)
hgbot (developer)
2016-06-01 22:18

 Repository: tools/automation/pi-mobile
Changeset: fe7e2571aab3c1cbc4b8701ceba6a9b6505e7ebb
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Jun 01 14:17:56 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/fe7e2571aab3c1cbc4b8701ceba6a9b6505e7ebb [^]

Related to issue 33028: Added automated test

---
M src-test/org/openbravo/test/mobile/common/selenium/utils/AllowedErrorsHelper.java
A src-test/org/openbravo/test/mobile/quarantine/pack/MCA/sales/I33028_QuotationReturnLines.java
---
(0086954)
migueldejuana (developer)
2016-06-02 17:47

 Avoid maintaining duplicated code.

Change https://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/c3c80f65e97b49ff3bafe87a8785191164df5cde#l1.8 [^]
with:
this.updateVisibility();
(0087210)
hgbot (developer)
2016-06-13 18:42

 Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 41c555c45c3c7b861c0e2640077ef6db70403373
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Wed Jun 08 13:14:33 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/41c555c45c3c7b861c0e2640077ef6db70403373 [^]

Fixed issue 33028: Delete duplicate code in verified return menu

---
M web/org.openbravo.retail.returns/js/returnReceiptButton.js
---
(0087759)
hgbot (developer)
2016-06-21 21:18
edited on: 2016-06-21 21:27

 Repository: erp/pmods/org.openbravo.retail.returns
Changeset: 081608e4dbd9632fee04b5a110e993634a4dbb2b
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Jun 20 08:19:05 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/081608e4dbd9632fee04b5a110e993634a4dbb2b [^]

Fixed issue 33028: Delete duplicated code in verified return menu options

- This functionality is implemented in the updatevisibility function.

---
M web/org.openbravo.retail.returns/js/returnReceiptButton.js
---
(0087765)
migueldejuana (developer)
2016-06-22 08:22

 remove duplicate code but do not remove the logic:

     1.7 - if (this.model.get('order').get('isEditable') === false) {
     1.9 - this.setDisabled(true);
    1.10 - return;
    1.11 - }
    1.12 + this.updateVisibility();
(0087766)
migueldejuana (developer)
2016-06-22 08:37

 The idea was to use updateVisibility method instead of removing validation but that validation is not needed, so the change is ok.
(0087767)
migueldejuana (developer)
2016-06-22 08:37

 Tested and reviewed

- Issue History
Date Modified Username Field Change
2016-05-23 16:44 amayavicente New Issue
2016-05-23 16:44 amayavicente Assigned To => Retail
2016-05-23 16:44 amayavicente Resolution time => 1465164000
2016-05-23 16:44 amayavicente Triggers an Emergency Pack => No
2016-05-23 16:44 amayavicente Tag Attached: SER-QA
2016-05-23 17:56 Orekaria Status new => acknowledged
2016-05-23 19:33 mario_castello Assigned To Retail => mario_castello
2016-05-23 19:34 mario_castello Status acknowledged => scheduled
2016-05-25 16:26 hgbot Checkin
2016-05-25 16:26 hgbot Note Added: 0086748
2016-05-25 16:26 hgbot Status scheduled => resolved
2016-05-25 16:26 hgbot Resolution open => fixed
2016-05-25 16:26 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/030e3880653dfbdc8786ad11206e59f021e86060 [^]
2016-05-25 16:38 hgbot Checkin
2016-05-25 16:38 hgbot Note Added: 0086749
2016-06-01 22:18 hgbot Checkin
2016-06-01 22:18 hgbot Note Added: 0086898
2016-06-02 17:47 migueldejuana Note Added: 0086954
2016-06-02 17:47 migueldejuana Status resolved => new
2016-06-02 17:47 migueldejuana Resolution fixed => open
2016-06-03 16:27 Orekaria Status new => scheduled
2016-06-13 18:42 hgbot Checkin
2016-06-13 18:42 hgbot Note Added: 0087210
2016-06-13 18:42 hgbot Status scheduled => resolved
2016-06-13 18:42 hgbot Resolution open => fixed
2016-06-13 18:42 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/030e3880653dfbdc8786ad11206e59f021e86060 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/41c555c45c3c7b861c0e2640077ef6db70403373 [^]
2016-06-20 15:03 migueldejuana Status resolved => new
2016-06-20 15:03 migueldejuana Resolution fixed => open
2016-06-20 16:49 mario_castello Status new => scheduled
2016-06-21 21:18 hgbot Checkin
2016-06-21 21:18 hgbot Note Added: 0087759
2016-06-21 21:18 hgbot Status scheduled => resolved
2016-06-21 21:18 hgbot Resolution open => fixed
2016-06-21 21:18 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/41c555c45c3c7b861c0e2640077ef6db70403373 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.returns/rev/081608e4dbd9632fee04b5a110e993634a4dbb2b [^]
2016-06-21 21:27 mario_castello Note Edited: 0087759 View Revisions
2016-06-21 21:27 mario_castello Note Edited: 0087759 View Revisions
2016-06-22 08:22 migueldejuana Note Added: 0087765
2016-06-22 08:22 migueldejuana Status resolved => new
2016-06-22 08:22 migueldejuana Resolution fixed => open
2016-06-22 08:36 migueldejuana Status new => scheduled
2016-06-22 08:37 migueldejuana Note Added: 0087766
2016-06-22 08:37 migueldejuana Status scheduled => resolved
2016-06-22 08:37 migueldejuana Resolution open => fixed
2016-06-22 08:37 migueldejuana Review Assigned To => migueldejuana
2016-06-22 08:37 migueldejuana Note Added: 0087767
2016-06-22 08:37 migueldejuana Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker