Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0032995 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | major | always | 2016-05-19 10:44 | 2016-06-17 19:37 | |||
Reporter | alostale | View Status | public | |||||
Assigned To | alostale | |||||||
Priority | urgent | Resolution | fixed | Fixed in Version | 3.0PR16Q3 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 924f6aec18ba | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Review Assigned To | caristu | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0032995: some 2.50 style selectors do not work on JBoss | |||||||
Description | Some of the old 2.50 style selectors do not work when Openbravo is deployed on JBoss. | |||||||
Steps To Reproduce | 1. Deploy Openbravo on JBoss AS 7.1.1 2. Login as Openbravo group admin 3. Create a Goods Receipt 4. Click on Create Lines From button 5. Click on icon to open Warehouse position selector -> 5.1 No results appear on grid 5.2 The following error can be seen in log (see full stack here [1]) ERROR [org.apache.catalina.core.ContainerBase.[jboss.web].[default-host].[/qa-jboss-pgsql].[S801412]] (ajp--127.0.0.1-8009-1) Servlet.service() for servlet S801412 threw exception: org.openbravo.base.exception.OBException: Exception thrown Exception thrown Parameters processing failed. at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:63) [classes:] at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103) [classes:] at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:280) [jbossweb-7.0.13.Final.jar:] Alternatively to deploying in JBoss: 5.3. After step 5 check the request: in the form data sent to backend there is a field with no name. This generates also log in catalina.out when deployed in Tomcat, but the request is still processed [2]: May 16, 2016 6:28:21 PM org.apache.tomcat.util.http.Parameters processParameters INFO: Invalid chunk starting at byte [130] and ending at byte [130] with a value of [null] ignored [1] https://ci.openbravo.com/view/qa/job/qa-jboss-pgsql/1/artifact/SANDBOX/tomcat-logs/jboss-console.log [^] [2] https://ci.openbravo.com/job/int-basic-pgsql/lastSuccessfulBuild/artifact/SANDBOX/tomcat-logs/catalina.out [^] | |||||||
Proposed Solution | JBoss seems to be stricter than Tomcat when parsing request form data parameters not accepting unnamed parameters [3] which is what currently is (incorrectly) happening (see step 5.3 avobe). [3] http://stackoverflow.com/a/16088207/6355120 [^] | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
Relationships [ Relation Graph ] [ Dependency Graph ] | ||||||||
|
Notes | |
(0086572) hgbot (developer) 2016-05-19 11:16 |
Repository: erp/devel/pi Changeset: 924f6aec18ba1764800d30727824d1b9b85a5f6c Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Thu May 19 11:10:41 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/924f6aec18ba1764800d30727824d1b9b85a5f6c [^] fixed bug 32995: some 2.50 style selectors do not work on JBoss JBoss AS 7.1.1 is stricter than Tomcat when parsing request parameters. Some 2.50 style selectors where sending as part of the request an unnamed parameter (which, btw, was incorrect), this was not problematic for Tocmat but it is for JBoss. Fixed by removing unnamed parameters from the generated request in client side. --- M web/js/searchs.js --- |
(0086573) hgbot (developer) 2016-05-19 11:16 |
Repository: erp/devel/pi Changeset: dbc2c8a0f50553b9dbad79a6c4e2fe4c191a41df Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Thu May 19 11:15:28 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/dbc2c8a0f50553b9dbad79a6c4e2fe4c191a41df [^] related to bug 32995: force browser cache refresh --- M src/org/openbravo/erpCommon/security/Login.html M src/org/openbravo/erpCommon/security/Login_F1.html M web/js/utils.js --- |
(0086642) caristu (developer) 2016-05-23 11:14 |
Code review + testing OK: the selector request does not contain the empty named parameter ( : ) anymore. |
(0087542) hudsonbot (developer) 2016-06-17 19:37 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^] Maturity status: Test |
(0087543) hudsonbot (developer) 2016-06-17 19:37 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^] Maturity status: Test |
Issue History | |||
Date Modified | Username | Field | Change |
2016-05-19 10:44 | alostale | New Issue | |
2016-05-19 10:44 | alostale | Assigned To | => platform |
2016-05-19 10:44 | alostale | Modules | => Core |
2016-05-19 10:44 | alostale | Triggers an Emergency Pack | => No |
2016-05-19 10:45 | alostale | Relationship added | related to 0032511 |
2016-05-19 10:45 | alostale | Status | new => scheduled |
2016-05-19 10:45 | alostale | Assigned To | platform => alostale |
2016-05-19 10:45 | alostale | Review Assigned To | => caristu |
2016-05-19 10:53 | alostale | Steps to Reproduce Updated | View Revisions |
2016-05-19 10:53 | alostale | Proposed Solution updated | |
2016-05-19 11:16 | hgbot | Checkin | |
2016-05-19 11:16 | hgbot | Note Added: 0086572 | |
2016-05-19 11:16 | hgbot | Status | scheduled => resolved |
2016-05-19 11:16 | hgbot | Resolution | open => fixed |
2016-05-19 11:16 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/924f6aec18ba1764800d30727824d1b9b85a5f6c [^] |
2016-05-19 11:16 | hgbot | Checkin | |
2016-05-19 11:16 | hgbot | Note Added: 0086573 | |
2016-05-23 11:14 | caristu | Note Added: 0086642 | |
2016-05-23 11:14 | caristu | Status | resolved => closed |
2016-05-23 11:14 | caristu | Fixed in Version | => 3.0PR16Q3 |
2016-06-17 19:37 | hudsonbot | Checkin | |
2016-06-17 19:37 | hudsonbot | Note Added: 0087542 | |
2016-06-17 19:37 | hudsonbot | Checkin | |
2016-06-17 19:37 | hudsonbot | Note Added: 0087543 |
Copyright © 2000 - 2009 MantisBT Group |