Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0032974
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-05-17 17:332016-06-23 13:41
ReporteramayavicenteView Statuspublic 
Assigned Toshivum039 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision408828f969cd
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerOBPS
Support ticket
Regression levelProduction - QA Approved
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032974: [SERQA 1110] messages overlapped

DescriptionMessages 'There is not enough cash available' and 'The maximun lmit...' overlapped. See attached image.
Steps To ReproduceA)
1. In backend, for the POS Terminal type 'VBS POS Terminal Type' and payment method 'Cash' set 'Max. Limit Amount'=1000.
2. Log into the terminal VBS-1
3. Create a return ticket with 4 units of the product 'All mountain ski board Cham'
4. Click the button total amount. Check that the message 'There is not enough cash available' is raised.
5. Enter a payment in cash of 2000. Check that the message 'The maximun lmit...' is raised.
ERROR: both messages are overlapped.

B)
1. In webpos, for the terminal VBS-1, check in 'Cash Management' that the available cash is 0. If it is not, leave it as 0 doing a sale.
2. In backend, for the POS Terminal Type 'VBS POS Terminal Type', for the payment method 'Cash' set 'Max. Limit Amount' = 100.
3. In webpos, for the terminal VBS-1, create a ticket with the product 'Adhesive body warmers'.
4. Pay the ticket with an amount of 20€. Check that the message 'There is not enough cash available.' is displayed.
5. Without delete the previous payment, enter a new payment in cash of 200€. Check that the message 'The maximum limit (100.00€) for this payment method has been exceeded. Payment not allowed' is displayed.
ERROR: both messages are overlapped.
Proposed SolutionWe have to create an array of messages and if we need to show a message, push it to the messages array. After checking which messages we need to show, render the messages array line by line.

Note, if a message is too long and uses 2 lines, make it shorter
TagsSER-QA
Attached Filesjpg file icon 1110.JPG [^] (151,195 bytes) 2016-05-17 17:33

- Relationships [ Relation Graph ] [ Dependency Graph ]
caused by defect 0032814 closedmario_castello [SERQA 1018] Overlapping messages in Payment screen using Payment Method categories 
has duplicate defect 0033094 closedRetail If you create an overpayment and select card payment method two overlapped messages appear 
has duplicate defect 0033157 closedRetail [SERQA 1079] Messages overlapped 

-  Notes
(0086903)
guillermogil (viewer)
2016-06-02 09:32

 This is a QAA Regression
(0087118)
dbaz (viewer)
2016-06-09 14:37

 Since it could be frequent to have to render there more than two error lines, I want to propose a better solution:

http://screencast.com/t/9Gvq7Jg9pfU [^]

Some considerations:
* We should not use jQuery code in the WebPOS. Also, the JSFiddle code is just an example copy/pasted from somewhere, so it should be adapted, refactored and simplified.
* The auto-scroll ONLY happens when there are more than two lines (this can be known using javascript comparing clientHeight and scrollHeight).
* The "alert" shown once you tap/click the error messages area should have the WebPOS look and feel (green popup with white text).
* As you can see, now I include also a bullet • before each message. This improves the reading with several and multi-line messages.
* Here it is the JSFiddle shown as example: http://jsfiddle.net/g44x6y2v/2/ [^] but I want to
emphasize again that this code should be adapted, simplified and refactored into plain javascript before including it into our distribution.
(0087329)
hgbot (developer)
2016-06-16 10:11

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fd69c392c1cbe9506ff01f8a41d63531257163c2
Author: Shivanand Madiwalar <shivanand.madiwalar <at> promantia.com>
Date: Thu Jun 16 13:38:35 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fd69c392c1cbe9506ff01f8a41d63531257163c2 [^]

Fixes Issue 32974 : Added Logic To Avoid Payment Error Message Overlapping In the Payment Panel .

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0087404)
hgbot (developer)
2016-06-17 14:37

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 9dcb86ad6f5ca0787d96c2a3af6500491043bdb5
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Jun 17 14:37:02 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/9dcb86ad6f5ca0787d96c2a3af6500491043bdb5 [^]

Related to issue 32974. Three changes were done:
- alignErrorMessages should be called from outside the component.
- Long interval will only be initiated once there is more than one error message
- The animation will start from the top of the component.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0087751)
hgbot (developer)
2016-06-21 18:02

 Repository: retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal
Changeset: 8c2c543bd1e098c640db25508ea02e57508537fd
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jun 21 17:38:10 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal/rev/8c2c543bd1e098c640db25508ea02e57508537fd [^]

Fixes Issue 32974 : Added Logic To Avoid Payment Error Message Overlapping In the Payment Panel .

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0087752)
hgbot (developer)
2016-06-21 18:02

 Repository: retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal
Changeset: 7f6d0e013a2bff7e192e41703d6dcec9b729bfe6
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jun 21 17:40:02 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal/rev/7f6d0e013a2bff7e192e41703d6dcec9b729bfe6 [^]

Fixes Issue 32974 : Added Logic To Avoid Payment Error Message Overlapping In the Payment Panel .

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0087754)
hgbot (developer)
2016-06-21 18:18

 Repository: retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal
Changeset: dc90b63a8706810d2dc2098c7af345ef4e8fc245
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jun 21 17:38:10 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal/rev/dc90b63a8706810d2dc2098c7af345ef4e8fc245 [^]

Fixes Issue 32974 : Added Logic To Avoid Payment Error Message Overlapping In the Payment Panel .

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---
(0087755)
hgbot (developer)
2016-06-21 18:18

 Repository: retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal
Changeset: 408828f969cdc8ab5150a7a308c84371215eec12
Author: Miguel de Juana <miguel.dejuana <at> openbravo.com>
Date: Tue Jun 21 17:40:02 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal/rev/408828f969cdc8ab5150a7a308c84371215eec12 [^]

Fixes Issue 32974 : Added Logic To Avoid Payment Error Message Overlapping In the Payment Panel .

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/payment.js
---

- Issue History
Date Modified Username Field Change
2016-05-17 17:33 amayavicente New Issue
2016-05-17 17:33 amayavicente Assigned To => Retail
2016-05-17 17:33 amayavicente File Added: 1110.JPG
2016-05-17 17:33 amayavicente OBNetwork customer => Yes
2016-05-17 17:33 amayavicente Resolution time => 1464645600
2016-05-17 17:33 amayavicente Triggers an Emergency Pack => No
2016-05-17 17:33 amayavicente Tag Attached: SER-QA
2016-05-19 09:34 migueldejuana Proposed Solution updated
2016-05-19 10:19 Orekaria Status new => acknowledged
2016-05-25 12:39 shivum039 Assigned To Retail => shivum039
2016-05-25 12:39 shivum039 Status acknowledged => scheduled
2016-06-01 11:25 Orekaria Relationship added has duplicate 0033094
2016-06-02 09:32 guillermogil Note Added: 0086903
2016-06-02 09:32 guillermogil Regression level => Production - QA Approved
2016-06-06 16:33 Orekaria Steps to Reproduce Updated View Revisions
2016-06-06 16:36 Orekaria Relationship added has duplicate 0033157
2016-06-07 16:58 Orekaria Relationship added caused by 0032814
2016-06-09 14:37 dbaz Note Added: 0087118
2016-06-16 10:11 hgbot Checkin
2016-06-16 10:11 hgbot Note Added: 0087329
2016-06-16 10:11 hgbot Status scheduled => resolved
2016-06-16 10:11 hgbot Resolution open => fixed
2016-06-16 10:11 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fd69c392c1cbe9506ff01f8a41d63531257163c2 [^]
2016-06-17 14:37 hgbot Checkin
2016-06-17 14:37 hgbot Note Added: 0087404
2016-06-17 14:38 marvintm Review Assigned To => marvintm
2016-06-17 14:38 marvintm Status resolved => closed
2016-06-21 18:02 hgbot Checkin
2016-06-21 18:02 hgbot Note Added: 0087751
2016-06-21 18:02 hgbot Status closed => resolved
2016-06-21 18:02 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fd69c392c1cbe9506ff01f8a41d63531257163c2 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal/rev/8c2c543bd1e098c640db25508ea02e57508537fd [^]
2016-06-21 18:02 hgbot Checkin
2016-06-21 18:02 hgbot Note Added: 0087752
2016-06-21 18:02 hgbot Fixed in SCM revision http://code.openbravo.com/retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal/rev/8c2c543bd1e098c640db25508ea02e57508537fd [^] => http://code.openbravo.com/retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal/rev/7f6d0e013a2bff7e192e41703d6dcec9b729bfe6 [^]
2016-06-21 18:18 hgbot Checkin
2016-06-21 18:18 hgbot Note Added: 0087754
2016-06-21 18:18 hgbot Fixed in SCM revision http://code.openbravo.com/retail/backports/3.0RR16Q1.4/org.openbravo.retail.posterminal/rev/7f6d0e013a2bff7e192e41703d6dcec9b729bfe6 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal/rev/dc90b63a8706810d2dc2098c7af345ef4e8fc245 [^]
2016-06-21 18:18 hgbot Checkin
2016-06-21 18:18 hgbot Note Added: 0087755
2016-06-21 18:18 hgbot Fixed in SCM revision http://code.openbravo.com/retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal/rev/dc90b63a8706810d2dc2098c7af345ef4e8fc245 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2.1/org.openbravo.retail.posterminal/rev/408828f969cdc8ab5150a7a308c84371215eec12 [^]
2016-06-23 13:41 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker