0032829: Delivery Status shows wrong value

Description

In some cases, the Delivery Status field on Sales Order shows a wrong value.

Steps To Reproduce

1 - Log in ERP
2 - Go to sales Order Window
3 - Create a new Sales Order
4 - Create 2 lines:
A - Product A order quantity = 499
B - Product B order quantity = 1
5 - Book the order
6 - Go to Goods Shipment and create a new shipment with the same business partner than sales order created in 3 step
7 - Hit Create lines from button
8 - Select the line created for product A in 4A step
9 - Complete the shipment
10 - Go to sales Order window and open the Sales order created in step 3
11 - Observes that the field Delivery Status in status bar shows 100%, but the line for product B is not shipped.

Proposed Solution

Change reference to Numeric of the column DeliveryStatus from c_order table and don't round in the sql query

Tags

No tags attached.

Attached Files

32829.diff [^] (2,106 bytes) 2016-05-03 13:58 [Show Content] [Hide Content]

# HG changeset patch
# User Alvaro Ferraz <alvaro.ferraz@openbravo.com>
# Date 1462275053 -7200
#      Tue May 03 13:30:53 2016 +0200
# Node ID 2425fde034ebf3ee015b439242f77a9d08211241
# Parent  2bcf5c3e1da66ebae6a14d2c75d5627ac9e36ccd
Fixes issue 32829: Set C_Order DeliveryStatus column as Amount with 2 decimals

diff --git a/src-db/database/sourcedata/AD_COLUMN.xml b/src-db/database/sourcedata/AD_COLUMN.xml
--- a/src-db/database/sourcedata/AD_COLUMN.xml
+++ b/src-db/database/sourcedata/AD_COLUMN.xml
@@ -333156,8 +333156,8 @@
 <!--9E82E728716246B393C40D2CDCA0133A-->  <DESCRIPTION><![CDATA[Delivery Status]]></DESCRIPTION>
 <!--9E82E728716246B393C40D2CDCA0133A-->  <COLUMNNAME><![CDATA[DeliveryStatus]]></COLUMNNAME>
 <!--9E82E728716246B393C40D2CDCA0133A-->  <AD_TABLE_ID><![CDATA[259]]></AD_TABLE_ID>
-<!--9E82E728716246B393C40D2CDCA0133A-->  <AD_REFERENCE_ID><![CDATA[11]]></AD_REFERENCE_ID>
-<!--9E82E728716246B393C40D2CDCA0133A-->  <FIELDLENGTH><![CDATA[4]]></FIELDLENGTH>
+<!--9E82E728716246B393C40D2CDCA0133A-->  <AD_REFERENCE_ID><![CDATA[12]]></AD_REFERENCE_ID>
+<!--9E82E728716246B393C40D2CDCA0133A-->  <FIELDLENGTH><![CDATA[7]]></FIELDLENGTH>
 <!--9E82E728716246B393C40D2CDCA0133A-->  <ISKEY><![CDATA[N]]></ISKEY>
 <!--9E82E728716246B393C40D2CDCA0133A-->  <ISPARENT><![CDATA[N]]></ISPARENT>
 <!--9E82E728716246B393C40D2CDCA0133A-->  <ISMANDATORY><![CDATA[N]]></ISMANDATORY>
@@ -333179,7 +333179,7 @@
 <!--9E82E728716246B393C40D2CDCA0133A-->  <IMAGESIZEVALUESACTION><![CDATA[N]]></IMAGESIZEVALUESACTION>
 <!--9E82E728716246B393C40D2CDCA0133A-->  <ISUSEDSEQUENCE><![CDATA[N]]></ISUSEDSEQUENCE>
 <!--9E82E728716246B393C40D2CDCA0133A-->  <SQLLOGIC><![CDATA[(coalesce((select case when sum(abs(ol.qtyordered))  = 0 then 0 else 
-round(coalesce(sum(abs(ol.qtydelivered)), 0)/sum(abs(ol.qtyordered)) * 100, 0)  end 
+round(coalesce(sum(abs(ol.qtydelivered)), 0)/sum(abs(ol.qtyordered)) * 100, 2)  end 
  from c_orderline ol where ol.c_order_id=c_order_id and ol.c_order_discount_id is null
  ),0))]]></SQLLOGIC>
 <!--9E82E728716246B393C40D2CDCA0133A-->  <ALLOWSORTING><![CDATA[N]]></ALLOWSORTING>

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0086154) aferraz (manager) 2016-05-03 13:58 edited on: 2016-05-03 14:04	Several status fields show a rounded integer value such as Delivery Status, Invoice Status or Payment Status in Sales Order window. In order to have a consistent behaviour, all of them should be updated with a reference supporting decimals. Also, computed columns should be reviewed due to bad performance. Besides, any user can customize the number of decimals displayed in those columns with a template. Attached a patch to change the number of decimals displayed in C_Order.DeliveryStatus column to 2 and moved to Design Defect.

Issue History
Date Modified	Username	Field	Change
2016-05-03 01:40	rbianchini	New Issue
2016-05-03 01:40	rbianchini	Assigned To	=> Triage Finance
2016-05-03 01:40	rbianchini	Web browser	=> Google Chrome
2016-05-03 01:40	rbianchini	Modules	=> Core
2016-05-03 01:40	rbianchini	Resolution time	=> 1462417200
2016-05-03 01:40	rbianchini	Triggers an Emergency Pack	=> No
2016-05-03 13:58	aferraz	Web browser	Google Chrome => Google Chrome
2016-05-03 13:58	aferraz	Resolution time	1462417200 => 1462399200
2016-05-03 13:58	aferraz	Note Added: 0086154
2016-05-03 13:58	aferraz	Type	defect => design defect
2016-05-03 13:58	aferraz	File Added: 32829.diff
2016-05-03 14:04	aferraz	Note Edited: 0086154	View Revisions