Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0032818
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 02. Master data managementminorhave not tried2016-05-01 15:162016-06-17 19:37
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in Version3.0PR16Q3
StatusclosedFix in branchFixed in SCM revision23c0239a0516
ProjectionnoneETAnoneTarget Version3.0PR16Q3
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032818: Stack trace in log when a preference is not defined

DescriptionWhen opening product tab in backoffice I see the following stack trace in the console:

540995 [http-9080-6] ERROR org.openbravo.client.kernel.reference.CharacteristicsUIDefinition - Error finding ShowProductCharacteristicsParents preference
org.openbravo.erpCommon.utility.PropertyNotFoundException
    at org.openbravo.erpCommon.businessUtility.Preferences.getPreferenceValue(Preferences.java:219)
    at org.openbravo.client.kernel.reference.CharacteristicsUIDefinition.getValue(CharacteristicsUIDefinition.java:126)
    at org.openbravo.client.kernel.reference.CharacteristicsUIDefinition.getFieldProperties(CharacteristicsUIDefinition.java:97)
    at org.openbravo.client.application.window.FormInitializationComponent.computeColumnValues(FormInitializationComponent.java:751)
    at org.openbravo.client.application.window.FormInitializationComponent.execute(FormInitializationComponent.java:265)
    at org.openbravo.client.kernel.BaseActionHandler.execute(BaseActionHandler.java:73)
    at org.openbravo.client.kernel.KernelServlet.processActionRequest(KernelServlet.java:314)
    at org.openbravo.client.kernel.KernelServlet.doGet(KernelServlet.java:206)
    at org.openbravo.client.kernel.KernelServlet.doPost(KernelServlet.java:287)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:637)
    at org.openbravo.base.HttpBaseServlet.serviceInitialized(HttpBaseServlet.java:228)
    at org.openbravo.base.secureApp.HttpSecureAppServlet.service(HttpSecureAppServlet.java:431)
    at org.openbravo.client.kernel.BaseKernelServlet.callServiceInSuper(BaseKernelServlet.java:88)
    at org.openbravo.client.kernel.BaseKernelServlet.service(BaseKernelServlet.java:59)
    at org.openbravo.client.kernel.KernelServlet.service(KernelServlet.java:168)
    at javax.servlet.http.HttpServlet.service(HttpServlet.java:717)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:290)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.replication.symmetricds.ServletDisablerDuringTableReloadFilter.doFilter(ServletDisablerDuringTableReloadFilter.java:64)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.SessionExpirationFilter.doFilter(SessionExpirationFilter.java:66)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.utils.CharsetFilter.doFilter(CharsetFilter.java:35)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.client.kernel.KernelFilter$1.doAction(KernelFilter.java:62)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.client.kernel.KernelFilter.doFilter(KernelFilter.java:71)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.openbravo.dal.core.DalRequestFilter$1.doAction(DalRequestFilter.java:81)
    at org.openbravo.dal.core.ThreadHandler.run(ThreadHandler.java:46)
    at org.openbravo.dal.core.DalRequestFilter.doFilter(DalRequestFilter.java:103)
    at org.apache.catalina.core.ApplicationFilterChain.internalDoFilter(ApplicationFilterChain.java:235)
    at org.apache.catalina.core.ApplicationFilterChain.doFilter(ApplicationFilterChain.java:206)
    at org.apache.catalina.core.StandardWrapperValve.invoke(StandardWrapperValve.java:233)
    at org.apache.catalina.core.StandardContextValve.invoke(StandardContextValve.java:191)
    at org.apache.catalina.core.StandardHostValve.invoke(StandardHostValve.java:127)
    at org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:102)
    at org.apache.catalina.core.StandardEngineValve.invoke(StandardEngineValve.java:109)
    at org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:298)
    at org.apache.coyote.http11.Http11Processor.process(Http11Processor.java:859)
    at org.apache.coyote.http11.Http11Protocol$Http11ConnectionHandler.process(Http11Protocol.java:588)
    at org.apache.tomcat.util.net.JIoEndpoint$Worker.run(JIoEndpoint.java:489)
    at java.lang.Thread.run(Thread.java:745)
Steps To Reproducelogin to backoffice and go to product window
Proposed Solutionchange the catch block to not show an exception trace or log warn when a PropertyNotFoundException is thrown
TagsNo tags attached.
Attached Filesdiff file icon prevent-stack-trace.diff [^] (1,252 bytes) 2016-05-01 15:16 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0086136)
mtaal (manager)
2016-05-02 18:54

 Changeset : https://code.openbravo.com/erp/devel/try/graph/333b791be44405a51dd3f6a01d4ed963c46d2c71 [^]

Description :
$JOBS_TO_BUILD
Automation-repo : pi
PostgreSQL version : 9.1


FAILED:
        https://ci.openbravo.com//job/try-gui-oracle/4033/ [^]

SUCCESS:
        https://ci.openbravo.com//job/try-full-pgsql/4063/ [^]
        https://ci.openbravo.com//job/try-full-oracle/4053/ [^]
        https://ci.openbravo.com//job/try-checks-pgsql/3886/ [^]
        https://ci.openbravo.com//job/try-checks-oracle/3889/ [^]
        https://ci.openbravo.com//job/try-dbcons-pgsql/3766/ [^]
        https://ci.openbravo.com//job/try-dbcons-oracle/3777/ [^]
        https://ci.openbravo.com//job/try-api/3420/ [^]
        https://ci.openbravo.com//job/try-gui-pgsql/4030/ [^]
        https://ci.openbravo.com//job/try-initial-pgsql/4000/ [^]
        https://ci.openbravo.com//job/try-initial-oracle/4002/ [^]
        https://ci.openbravo.com//job/try-basic-pgsql/3997/ [^]
        https://ci.openbravo.com//job/try-basic-oracle/3998/ [^]
        https://ci.openbravo.com//job/try-modules-pgsql/3960/ [^]
        https://ci.openbravo.com//job/try-upgrade-pgsql/3936/ [^]
        https://ci.openbravo.com//job/try-dummy-pgsql/4000/ [^]


One failing try build, seems unrelated:
https://ci.openbravo.com/job/try-gui-oracle/4033/testReport/com.openbravo.test.integration.erp.modules.client.application.testsuites.standardview.form.fields/FIE0010_EnterValueInBusinessPartnerSelector/valueShouldBeEnteredUsingTheSelectorPopUp_0_/ [^]
(0086168)
hgbot (developer)
2016-05-03 22:09

 Repository: erp/devel/pi
Changeset: 23c0239a0516a2bae6d4901098fd1de04223110f
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue May 03 22:09:12 2016 +0200
URL: http://code.openbravo.com/erp/devel/pi/rev/23c0239a0516a2bae6d4901098fd1de04223110f [^]

Fixes issue 32818: Stack trace in log when a preference is not defined
Added catch with ignore exception

---
M modules/org.openbravo.client.kernel/src/org/openbravo/client/kernel/reference/CharacteristicsUIDefinition.java
---
(0086366)
AugustoMauch (manager)
2016-05-11 10:16

 Code reviewed and verified in pi@23c0239a0516
(0087514)
hudsonbot (developer)
2016-06-17 19:37

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2016-05-01 15:16 mtaal New Issue
2016-05-01 15:16 mtaal Assigned To => mtaal
2016-05-01 15:16 mtaal File Added: prevent-stack-trace.diff
2016-05-01 15:16 mtaal Modules => Core
2016-05-01 15:16 mtaal Triggers an Emergency Pack => No
2016-05-02 16:30 mtaal Review Assigned To => AugustoMauch
2016-05-02 18:54 mtaal Note Added: 0086136
2016-05-03 22:09 hgbot Checkin
2016-05-03 22:09 hgbot Note Added: 0086168
2016-05-03 22:09 hgbot Status new => resolved
2016-05-03 22:09 hgbot Resolution open => fixed
2016-05-03 22:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/23c0239a0516a2bae6d4901098fd1de04223110f [^]
2016-05-11 10:16 AugustoMauch Note Added: 0086366
2016-05-11 10:16 AugustoMauch Status resolved => closed
2016-05-11 10:16 AugustoMauch Fixed in Version => 3.0PR16Q3
2016-06-17 19:37 hudsonbot Checkin
2016-06-17 19:37 hudsonbot Note Added: 0087514

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker