Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0032650

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] 07. Sales management

major

always

2016-04-11 19:00

2016-06-17 19:36

Reporter

eduardo_Argal

View Status

public

Assigned To

eduardo_Argal

Priority

urgent

Resolution

fixed

Fixed in Version

3.0PR16Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Merge Request Status

Review Assigned To

aferraz

OBNetwork customer

OBPS

Web browser

Modules

Core

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0032650: Divide by zero problem when trying to relate a service to existing line in an order

Description

Create a new product of type service, linked to product and price rule based.
Add the product to an existing price list with price = 0.
when creating an order with two lines (one with the service another with a regular product) and try to relate one line to another.
An exception is thrown

Steps To Reproduce

1) Create a Product as follows:
Name Transport
Type service
linked to product 'Y' (Include a product category**)
price rule based 'Y' (Set a price rule as a %. 20 % for example)
Quantity rule 'Unique quantity'
Price tab: Select sales price list and price 0
2) create an order
3) Add service product and save
4) Add another line for a product in the category**
5)Press select order line button
6) select line one form pick and execute and click OK
Error is thrown

Proposed Solution

Find attached patch

Tags

No tags attached.

diff.diff [^] (1,772 bytes) 2016-04-11 19:00 [Show Content] [Hide Content]

diff -r 3b8d384cb998 src/org/openbravo/common/actionhandler/ServiceOrderLineRelate.java
--- a/src/org/openbravo/common/actionhandler/ServiceOrderLineRelate.java	Fri Apr 08 14:47:02 2016 +0200
+++ b/src/org/openbravo/common/actionhandler/ServiceOrderLineRelate.java	Mon Apr 11 17:40:54 2016 +0200
@@ -357,8 +357,9 @@
     mainOrderLine.setOrderedQuantity(lineQuantity.multiply(signum));
 
     // Calculate discount
-    BigDecimal discount = listPrice.subtract(servicePrice).multiply(new BigDecimal("100"))
-        .divide(listPrice, currency.getPricePrecision().intValue(), RoundingMode.HALF_UP);
+    BigDecimal discount = listPrice.compareTo(BigDecimal.ZERO) == 0 ? BigDecimal.ZERO : listPrice
+        .subtract(servicePrice).multiply(new BigDecimal("100"))
+        .divide(listPrice, currency.getPricePrecision().intValue(), BigDecimal.ROUND_HALF_EVEN);
     mainOrderLine.setDiscount(discount);
     OBDal.getInstance().save(mainOrderLine);
   }
diff -r 3b8d384cb998 src/org/openbravo/event/ServiceRelationEventHandler.java
--- a/src/org/openbravo/event/ServiceRelationEventHandler.java	Fri Apr 08 14:47:02 2016 +0200
+++ b/src/org/openbravo/event/ServiceRelationEventHandler.java	Mon Apr 11 17:40:54 2016 +0200
@@ -172,7 +172,8 @@
     currentOrderLine.setTaxableAmount(serviceAmount);
 
     // Calculate discount
-    BigDecimal discount = listPrice.subtract(servicePrice).multiply(new BigDecimal("100"))
+    BigDecimal discount = listPrice.compareTo(BigDecimal.ZERO) == 0 ? BigDecimal.ZERO : listPrice
+        .subtract(servicePrice).multiply(new BigDecimal("100"))
         .divide(listPrice, currency.getPricePrecision().intValue(), BigDecimal.ROUND_HALF_EVEN);
     currentOrderLine.setDiscount(discount);
     OBDal.getInstance().save(currentOrderLine);

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0085679) hgbot (developer) 2016-04-15 15:11	Repository: erp/devel/pi Changeset: 64e0da2942925b3352eb12435170cebc2c855a87 Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com> Date: Fri Apr 15 15:09:37 2016 +0200 URL: http://code.openbravo.com/erp/devel/pi/rev/64e0da2942925b3352eb12435170cebc2c855a87 [^] Fixes issue 32650: Division by zero when relating a service with an order line Set discount as zero if listprice is zero to avoid division by zero. --- M src/org/openbravo/common/actionhandler/ServiceOrderLineRelate.java M src/org/openbravo/event/ServiceRelationEventHandler.java ---

(0085680) aferraz (viewer) 2016-04-15 15:11 edited on: 2016-04-15 15:11	Fix done by eduardo_Argal. Code review OK done by aferraz.

(0087454) hudsonbot (viewer) 2016-06-17 19:36	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/0dc7be081b1c [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2016-04-11 19:00	eduardo_Argal	New Issue
2016-04-11 19:00	eduardo_Argal	Assigned To	=> Triage Finance
2016-04-11 19:00	eduardo_Argal	OBNetwork customer	=> No
2016-04-11 19:00	eduardo_Argal	Modules	=> Core
2016-04-11 19:00	eduardo_Argal	Triggers an Emergency Pack	=> No
2016-04-11 19:00	eduardo_Argal	File Added: diff.diff
2016-04-14 13:31	eduardo_Argal	OBNetwork customer	No => Yes
2016-04-14 14:13	eduardo_Argal	Resolution time	=> 1463176800
2016-04-15 15:11	hgbot	Checkin
2016-04-15 15:11	hgbot	Note Added: 0085679
2016-04-15 15:11	hgbot	Status	new => resolved
2016-04-15 15:11	hgbot	Resolution	open => fixed
2016-04-15 15:11	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/64e0da2942925b3352eb12435170cebc2c855a87 [^]
2016-04-15 15:11	aferraz	Assigned To	Triage Finance => eduardo_Argal
2016-04-15 15:11	aferraz	Review Assigned To	=> aferraz
2016-04-15 15:11	aferraz	Note Added: 0085680
2016-04-15 15:11	aferraz	Status	resolved => closed
2016-04-15 15:11	aferraz	Fixed in Version	=> 3.0PR16Q3
2016-04-15 15:11	aferraz	Note Edited: 0085680	View Revisions
2016-06-17 19:36	hudsonbot	Checkin
2016-06-17 19:36	hudsonbot	Note Added: 0087454

Copyright © 2000 - 2009 MantisBT Group