0032449: ProcessHQLQuery does not support List parameters (Collections)

Description

ProcessHQLQuery class does not support collection parameters.

Steps To Reproduce

Add a new parameter in a query which is a collection (for example and e.organization.id in :orgIds) and pass a collection as a parameter (overriding getParameterValues method in the created class).
When being executed the query does not throw any result as the parameter sent is not properly handled.

Proposed Solution

see attached patch

Tags

No tags attached.

Attached Files

ProcessHQLQuery.diff [^] (1,131 bytes) 2016-03-09 17:01 [Show Content] [Hide Content]

diff -r 3bc6c721e643 src/org/openbravo/mobile/core/process/ProcessHQLQuery.java
--- a/src/org/openbravo/mobile/core/process/ProcessHQLQuery.java	Fri Mar 04 12:05:14 2016 +0100
+++ b/src/org/openbravo/mobile/core/process/ProcessHQLQuery.java	Wed Mar 09 17:01:01 2016 +0100
@@ -12,6 +12,7 @@
 import java.io.Writer;
 import java.util.ArrayList;
 import java.util.Arrays;
+import java.util.Collection;
 import java.util.Date;
 import java.util.Iterator;
 import java.util.List;
@@ -145,7 +146,11 @@
         final Query query = session.createQuery(querybuilder.getHQLQuery());
         if (parameterValues != null) {
           for (String paramName : parameterValues.keySet()) {
-            query.setParameter(paramName, parameterValues.get(paramName).toString());
+            if (parameterValues.get(paramName) instanceof Collection<?>) {
+              query.setParameterList(paramName, (Collection<?>) parameterValues.get(paramName));
+            } else {
+              query.setParameter(paramName, parameterValues.get(paramName).toString());
+            }
           }
         }
         rememberQueryForErrorLog = query;

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0088600) hgbot (developer) 2016-07-20 14:03	Repository: erp/pmods/org.openbravo.mobile.core Changeset: 38f4b33ae59e5da99be1b7f782a99be9a61985c0 Author: Asier Martirena <asier.martirena <at> openbravo.com> Date: Wed Jul 20 14:02:53 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/38f4b33ae59e5da99be1b7f782a99be9a61985c0 [^] Fixes issue 32449: ProcessHQLQuery does not support List Parameters (Collections) --- M src/org/openbravo/mobile/core/process/ProcessHQLQuery.java ---

Issue History
Date Modified	Username	Field	Change
2016-03-09 17:01	eduardo_Argal	New Issue
2016-03-09 17:01	eduardo_Argal	Assigned To	=> marvintm
2016-03-09 17:01	eduardo_Argal	OBNetwork customer	=> No
2016-03-09 17:01	eduardo_Argal	Triggers an Emergency Pack	=> No
2016-03-09 17:01	eduardo_Argal	File Added: ProcessHQLQuery.diff
2016-03-22 14:20	mario_castello	Assigned To	marvintm => Retail
2016-03-22 14:20	mario_castello	Status	new => acknowledged
2016-03-22 14:25	mario_castello	Assigned To	Retail => mario_castello
2016-07-20 14:03	hgbot	Checkin
2016-07-20 14:03	hgbot	Note Added: 0088600
2016-07-20 14:03	hgbot	Status	acknowledged => resolved
2016-07-20 14:03	hgbot	Resolution	open => fixed
2016-07-20 14:03	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/38f4b33ae59e5da99be1b7f782a99be9a61985c0 [^]
2016-07-20 14:42	marvintm	Review Assigned To	=> marvintm
2016-07-20 14:42	marvintm	Status	resolved => closed