Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0032421
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-03-07 12:082018-06-26 11:41
ReporterageteView Statuspublic 
Assigned Tojorge-garcia 
PriorityhighResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision4534fd77d69b
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032421: [SERQA 770] Adding more units to a product with discount line using 2 families discount, an extranche split is done

DescriptionIf you add more units to a line in a receipt and this line has a discount of a two families discount, when you have fiur products for this line, the aplication make an extrange split in the linw without discount.

Also, the line with discount and the one without change the order
Steps To Reproduce1. In backend create a new promotion and discount of tow families discount type. Add an starting date and leave the other fields like they are.
2. Add tow families in the family tab, the first one with discount type percentage and 0 in percentage field, and the second one with discount type percentage and 50 in percentage field.
3. In the product tab of each family line add the product Gas lamp.
4. In web pos create a new receipt and add the product gas lamp
5. Click on the product and click + to add another unit --> check a new line is created with the discount
6. With the focus in the discount line, click again the + --> check a new unit is added to the line without the discount
7. With the focus in the discount line, click again the + --> check a new unit is added to the line with the discount
--> check the lines change the order
8. Repeat 6 and 7
9. Repeat 6
10. Repeat 7 --> check the application makes an split in the line without discount creating one line with 3 units and another one with 1. From here the behaviour when adding more units works similar, making splits at any time.
11. Repeat step 6 --> the split is undo and 5 units are applied to the line without the discount

Here you have a video done with another product:

https://drive.google.com/a/openbravo.com/file/d/0B4UosNh_2eDIbm9UOVRFTWZMZ28/view [^]
Proposed SolutionTo have the same behaviour always and do not change the order once and again.
TagsSER-QA
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on feature request 0032638 feedbackRetail Overhaul how lines are reorganized when discounts are applied 
related to defect 0032482 closedSoftwareFactory [SERQA 769] Service icon and quantity of service is not working properly when a discount is applied 
Not all the children of this issue are yet resolved or closed.

-  Notes
(0085773)
hgbot (developer)
2016-04-20 11:27

 Repository: erp/pmods/org.openbravo.retail.discount.twofamiliescombo
Changeset: 4534fd77d69b6ba7f58fe7731212ad9b35f6ed00
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Apr 20 10:44:30 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.discount.twofamiliescombo/rev/4534fd77d69b6ba7f58fe7731212ad9b35f6ed00 [^]

Fixed issue 32421: [SERQA 770] Adding more units to a product with discount
line using 2 families discount, an extranche split is done

Even with the change of merge lines that are splitted, the discount could be set
in another line different than the orginal line with the discount.

Fix this case could take a lot of time, so the WebPOS will warn the user that
the discounts could be set in another line.

---
M src-db/database/sourcedata/AD_MESSAGE.xml
M web/org.openbravo.retail.discount.twofamiliescombo/source/twofamilies-rule-impl.js
---
(0085829)
hgbot (developer)
2016-04-21 13:34

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: ae6c0b43c2b520d0733f8e88a1efbf06df933bb8
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Wed Apr 20 10:56:33 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/ae6c0b43c2b520d0733f8e88a1efbf06df933bb8 [^]

Related to issue 32421: [SERQA 770] Adding more units to a product with discount
line using 2 families discount, an extranche split is done

To avoid the creation of separate lines that participates in the two families
promotion, it's necessary to merge those line that have been splited.

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0085833)
hgbot (developer)
2016-04-21 13:35

 Repository: tools/automation/pi-mobile
Changeset: 0ea1c6b6d64c75cdc9137d70734b28a961641952
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Thu Apr 21 13:32:20 2016 +0200
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/0ea1c6b6d64c75cdc9137d70734b28a961641952 [^]

Verifies issue 32421: [SERQA 770] Adding more units to a product with discount
line using 2 families discount, an extranche split is done

Added test to extmodules I32421_TwoFamiliesWithSameProduct.

---
A src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/discounts_twofamilies/I32421_TwoFamiliesWithSameProduct.java
---

- Issue History
Date Modified Username Field Change
2016-03-07 12:08 agete New Issue
2016-03-07 12:08 agete Assigned To => Retail
2016-03-07 12:08 agete Resolution time => 1458428400
2016-03-07 12:08 agete Triggers an Emergency Pack => No
2016-03-07 12:26 Orekaria Tag Attached: SER-QA
2016-03-07 12:26 Orekaria Status new => acknowledged
2016-03-07 13:32 agete Description Updated View Revisions
2016-03-07 13:32 agete Steps to Reproduce Updated View Revisions
2016-03-07 13:32 agete Proposed Solution updated
2016-03-15 13:49 Orekaria Status acknowledged => scheduled
2016-03-15 13:50 Orekaria Status scheduled => acknowledged
2016-03-16 12:40 agete Relationship added related to 0032482
2016-04-06 11:00 jorge-garcia Status acknowledged => scheduled
2016-04-06 11:00 jorge-garcia Assigned To Retail => jorge-garcia
2016-04-11 10:03 Orekaria Status scheduled => feedback
2016-04-11 10:17 Orekaria Relationship added depends on 0032638
2016-04-11 10:18 Orekaria Assigned To jorge-garcia => Retail
2016-04-20 11:04 jorge-garcia Status feedback => scheduled
2016-04-20 11:04 jorge-garcia Assigned To Retail => jorge-garcia
2016-04-20 11:27 hgbot Checkin
2016-04-20 11:27 hgbot Note Added: 0085773
2016-04-20 11:27 hgbot Status scheduled => resolved
2016-04-20 11:27 hgbot Resolution open => fixed
2016-04-20 11:27 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.discount.twofamiliescombo/rev/4534fd77d69b6ba7f58fe7731212ad9b35f6ed00 [^]
2016-04-21 13:34 hgbot Checkin
2016-04-21 13:34 hgbot Note Added: 0085829
2016-04-21 13:35 hgbot Checkin
2016-04-21 13:35 hgbot Note Added: 0085833
2016-04-27 13:25 marvintm Review Assigned To => marvintm
2016-04-27 13:25 marvintm Status resolved => closed
2018-06-26 11:41 hgbot Checkin
2018-06-26 11:41 hgbot Note Added: 0105418
2018-06-26 14:14 gorka_gil Note Deleted: 0105418

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker