0032301: When printing Business Partner Card, Contacts Address is not shown if it does not have the Region defined

Description

When printing Business Partner Card, Contacts Address is not shown if it does not have the Region defined. The problem is the C_Location_Identifier is not returning any record in that case

Steps To Reproduce

As group admin role:
   Assign a business partner and its address to a user
   Print the Business Partner Card
   Check the Address is shown in the Contacts section
   Remove the Region from the Business Partner - Location/Address
   Print the Business Partner Card
   Check the Address is not shown in the Contacts section

Proposed Solution

Attached a possible fix

Tags

No tags attached.

Attached Files

32301.diff [^] (712 bytes) 2016-02-22 13:03 [Show Content] [Hide Content]

diff -r 1adc9a58e28a src-db/database/model/functions/C_LOCATION_IDENTIFIER.xml
--- a/src-db/database/model/functions/C_LOCATION_IDENTIFIER.xml	Fri Jan 22 14:10:36 2016 +0000
+++ b/src-db/database/model/functions/C_LOCATION_IDENTIFIER.xml	Mon Feb 22 13:02:04 2016 +0100
@@ -64,11 +64,9 @@
     END
     )
   INTO v_description
-  FROM C_REGION R
-  LEFT JOIN C_COUNTRY C
-    ON R.C_COUNTRY_ID = C.C_COUNTRY_ID
-  RIGHT JOIN C_LOCATION L
-    ON L.C_REGION_ID = R.C_REGION_ID
+  FROM  C_LOCATION L
+	  LEFT JOIN C_COUNTRY C ON C.C_COUNTRY_ID = L.C_COUNTRY_ID
+	  LEFT JOIN C_REGION R ON R.C_REGION_ID = L.C_REGION_ID
   WHERE L.C_LOCATION_ID = p_C_Location_ID;
   RETURN v_description;
 END C_LOCATION_IDENTIFIER

Relationships [ Relation Graph ] [ Dependency Graph ]

Notes
(0088840) Sanjota (developer) 2016-08-05 11:38	Test plan: As group admin role: Assign a business partner and its address to a user Print the Business Partner Card Check the Address is shown in the Contacts section Remove the Region from the Business Partner - Location/Address Print the Business Partner Card Observe that Address is shown in the Contacts section(with region details blank).

Issue History
Date Modified	Username	Field	Change
2016-02-22 12:57	ngarcia	New Issue
2016-02-22 12:57	ngarcia	Assigned To	=> Triage Finance
2016-02-22 12:57	ngarcia	Modules	=> Core
2016-02-22 12:57	ngarcia	Triggers an Emergency Pack	=> No
2016-02-22 12:57	ngarcia	Issue Monitored: networkb
2016-02-22 13:03	ngarcia	File Added: 32301.diff
2016-02-22 13:03	ngarcia	Proposed Solution updated
2016-08-05 11:10	Sanjota	Assigned To	Triage Finance => Sanjota
2016-08-05 11:10	Sanjota	Status	new => scheduled
2016-08-05 11:38	Sanjota	Note Added: 0088840
2017-05-09 11:39	Practics	Issue Monitored: Practics