0032102: Store summary report is not working when there are till differences

(0084096)
mtaal (manager)
2016-02-11 10:54

To add a note on current logic:

- system amount: is amount sold
- actual amount: cash management and cash differences, cash withdrawals are a positive number, cash deposits a negative number
- overshort amojnt: actual amount - system amount, so the overshort reflects the change in the cash position, a positive overshort means cash position decrease, negative number means cash position increase

(0084097)
mtaal (manager)
2016-02-11 11:05
edited on: 2016-02-11 11:09

This is caused by this code in the store summary report (StoreSummaryReportHandler.class around line 655):
      // ignore these ones
      if (fLine.getPayment() == null
          && fLine.getGLItem() != null
          && paymentType.getCashDifferences() != null
          && DalUtil.getId(fLine.getGLItem()).equals(
              DalUtil.getId(paymentType.getCashDifferences()))) {
        continue;
      }

This will ignore cash differences found at the cashup. It does not ignore cash differences found when opening the till.

To also ignore cash differences when opening the store we need to do:

      // ignore these ones
      if (fLine.getPayment() == null
          && fLine.getGLItem() != null
          && paymentType.getCashDifferences() != null
          && (DalUtil.getId(fLine.getGLItem()).equals(
              DalUtil.getId(paymentType.getCashDifferences())) || DalUtil.getId(fLine.getGLItem())
              .equals(DalUtil.getId(paymentType.getPossGlitemTilldiff())))) {
        continue;
      }

(0084098)
mtaal (manager)
2016-02-11 11:07

Question to be sure we do the right fix:

what should the report show in this scenario:
open till, expected zero, counted 200
cashup: expected 200, counted 125

(0084321)
malsasua (developer)
2016-02-18 13:17

we close the ticket because the problem reported by the customer is generated by other problem. The customer has not informed about this problem, so could be that it is the behavior expected

Issue History
Date Modified	Username	Field	Change
2016-02-02 18:13	malsasua	New Issue
2016-02-02 18:13	malsasua	Assigned To	=> Retail
2016-02-02 18:13	malsasua	Resolution time	=> 1454972400
2016-02-02 18:13	malsasua	Triggers an Emergency Pack	=> No
2016-02-05 11:32	Orekaria	Status	new => acknowledged
2016-02-08 07:14	ranjith_qualiantech_com	Assigned To	Retail => ranjith_qualiantech_com
2016-02-08 07:14	ranjith_qualiantech_com	Status	acknowledged => scheduled
2016-02-11 10:54	mtaal	Note Added: 0084096
2016-02-11 11:05	mtaal	Note Added: 0084097
2016-02-11 11:07	mtaal	Note Added: 0084098
2016-02-11 11:09	mtaal	Note Edited: 0084097	View Revisions
2016-02-12 13:41	marvintm	Assigned To	ranjith_qualiantech_com => mtaal
2016-02-18 13:17	malsasua	Note Added: 0084321
2016-02-18 13:17	malsasua	Status	scheduled => closed
2016-02-18 13:17	malsasua	Resolution	open => no change required

Notes
(0084096) mtaal (manager) 2016-02-11 10:54	To add a note on current logic: - system amount: is amount sold - actual amount: cash management and cash differences, cash withdrawals are a positive number, cash deposits a negative number - overshort amojnt: actual amount - system amount, so the overshort reflects the change in the cash position, a positive overshort means cash position decrease, negative number means cash position increase

(0084097) mtaal (manager) 2016-02-11 11:05 edited on: 2016-02-11 11:09	This is caused by this code in the store summary report (StoreSummaryReportHandler.class around line 655): // ignore these ones if (fLine.getPayment() == null && fLine.getGLItem() != null && paymentType.getCashDifferences() != null && DalUtil.getId(fLine.getGLItem()).equals( DalUtil.getId(paymentType.getCashDifferences()))) { continue; } This will ignore cash differences found at the cashup. It does not ignore cash differences found when opening the till. To also ignore cash differences when opening the store we need to do: // ignore these ones if (fLine.getPayment() == null && fLine.getGLItem() != null && paymentType.getCashDifferences() != null && (DalUtil.getId(fLine.getGLItem()).equals( DalUtil.getId(paymentType.getCashDifferences())) \|\| DalUtil.getId(fLine.getGLItem()) .equals(DalUtil.getId(paymentType.getPossGlitemTilldiff())))) { continue; }

(0084098) mtaal (manager) 2016-02-11 11:07	Question to be sure we do the right fix: what should the report show in this scenario: open till, expected zero, counted 200 cashup: expected 200, counted 125

(0084321) malsasua (developer) 2016-02-18 13:17	we close the ticket because the problem reported by the customer is generated by other problem. The customer has not informed about this problem, so could be that it is the behavior expected

Relationships [ Relation Graph ] [ Dependency Graph ]