Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032102Retail ModulesStore Summary Reportpublic2016-02-02 18:132016-02-18 13:17
Reportermalsasua 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionno change required 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned To
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0032102: Store summary report is not working when there are till differences
Descriptionwhen there are differences in the initial count of till, the store summary report is not working fine
Steps To Reproducein backoffice
. open store: date: 02/02/2016

in webpos
. open till
 in the initial count when the till is opened:
  expected: 0
  counted: 200

. do cashup
 in cash payment method:
  expected: 200
  count: 0
 process cashup

backoffice
 close the store
 print the store summary report: date 02/02/2016
in the store summary report is displayed:

Type System Amt Act. Amt Overshort
Cash 0.00 (200.00) (200.00)

and it should be
Type System Amt Act. Amt Overshort
Cash 0.00 0 0
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-02-02 18:13malsasuaNew Issue
2016-02-02 18:13malsasuaAssigned To => Retail
2016-02-02 18:13malsasuaResolution time => 1454972400
2016-02-02 18:13malsasuaTriggers an Emergency Pack => No
2016-02-05 11:32OrekariaStatusnew => acknowledged
2016-02-08 07:14ranjith_qualiantech_comAssigned ToRetail => ranjith_qualiantech_com
2016-02-08 07:14ranjith_qualiantech_comStatusacknowledged => scheduled
2016-02-11 10:54mtaalNote Added: 0084096
2016-02-11 11:05mtaalNote Added: 0084097
2016-02-11 11:07mtaalNote Added: 0084098
2016-02-11 11:09mtaalNote Edited: 0084097bug_revision_view_page.php?bugnote_id=0084097#r11062
2016-02-12 13:41marvintmAssigned Toranjith_qualiantech_com => mtaal
2016-02-18 13:17malsasuaNote Added: 0084321
2016-02-18 13:17malsasuaStatusscheduled => closed
2016-02-18 13:17malsasuaResolutionopen => no change required

Notes
(0084096)
mtaal   
2016-02-11 10:54   
To add a note on current logic:

- system amount: is amount sold
- actual amount: cash management and cash differences, cash withdrawals are a positive number, cash deposits a negative number
- overshort amojnt: actual amount - system amount, so the overshort reflects the change in the cash position, a positive overshort means cash position decrease, negative number means cash position increase
(0084097)
mtaal   
2016-02-11 11:05   
(edited on: 2016-02-11 11:09)
This is caused by this code in the store summary report (StoreSummaryReportHandler.class around line 655):
      // ignore these ones
      if (fLine.getPayment() == null
          && fLine.getGLItem() != null
          && paymentType.getCashDifferences() != null
          && DalUtil.getId(fLine.getGLItem()).equals(
              DalUtil.getId(paymentType.getCashDifferences()))) {
        continue;
      }

This will ignore cash differences found at the cashup. It does not ignore cash differences found when opening the till.

To also ignore cash differences when opening the store we need to do:

      // ignore these ones
      if (fLine.getPayment() == null
          && fLine.getGLItem() != null
          && paymentType.getCashDifferences() != null
          && (DalUtil.getId(fLine.getGLItem()).equals(
              DalUtil.getId(paymentType.getCashDifferences())) || DalUtil.getId(fLine.getGLItem())
              .equals(DalUtil.getId(paymentType.getPossGlitemTilldiff())))) {
        continue;
      }
(0084098)
mtaal   
2016-02-11 11:07   
Question to be sure we do the right fix:

what should the report show in this scenario:
open till, expected zero, counted 200
cashup: expected 200, counted 125
(0084321)
malsasua   
2016-02-18 13:17   
we close the ticket because the problem reported by the customer is generated by other problem. The customer has not informed about this problem, so could be that it is the behavior expected