Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0031920
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2016-01-16 18:032016-02-03 15:07
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionb6380a27f941
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031920: The value returned by MobileServerController.getThisServerDefinition can be cached

DescriptionMobileServerController.getThisServerDefinition returns the MobileServerDefinition of the current server, or null if it is not defined.

The MobileServerDefinition returned is going to be always the same, so it is better to cache to improve the performance.
Steps To ReproduceIt is clear just by looking at the code [1] that the value returned is always the same (it is going to depend on the mobile.server.key property defined in Openbravo.properties, its value is not going to change at least until tomcat is restarted).

[1] https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/47545a15e44c/src/org/openbravo/mobile/core/servercontroller/MobileServerController.java#l163 [^]
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0083360)
hgbot (developer)
2016-01-16 18:13

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: b6380a27f941d566695248743a83d34d124d6c3b
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Sat Jan 16 18:10:31 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b6380a27f941d566695248743a83d34d124d6c3b [^]

Fixes issue 31920: Cache current server definition in MobileServerController

The MobileServerController.getThisServerDefinition method seems to be invoked quite often and the value that returns is always the same, it is better to cache the returned value.

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
---
(0083361)
hgbot (developer)
2016-01-16 18:14

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: dd0b6d3bb826c477fecae0cad85b899efb219a1e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Sat Jan 16 18:11:56 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/dd0b6d3bb826c477fecae0cad85b899efb219a1e [^]

Related with issue 31920: Updates year in copyright

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
---
(0083380)
hgbot (developer)
2016-01-18 16:05

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 0e660a087cb3d245d11eb7b067b0f45f404257ac
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Jan 18 16:05:30 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/0e660a087cb3d245d11eb7b067b0f45f404257ac [^]

Related to issue 31920: The value returned by MobileServerController.getThisServerDefinition can be cached
Refresh the cached server definition and initialize the collections

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
---
(0083479)
hgbot (developer)
2016-01-21 06:36

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 3234152079598da93d07e78d7cda512fc4fabc33
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Thu Jan 21 06:36:34 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/3234152079598da93d07e78d7cda512fc4fabc33 [^]

Related to issue 31920: The value returned by MobileServerController.getThisServerDefinition can be cached
A background process should use the uncached version of the server definition

---
M src/org/openbravo/mobile/core/servercontroller/MobileServerController.java
M src/org/openbravo/mobile/core/servercontroller/ServerStateBackground.java
---
(0083896)
migueldejuana (viewer)
2016-02-03 15:07

 Tested and reviewed

- Issue History
Date Modified Username Field Change
2016-01-16 18:03 AugustoMauch New Issue
2016-01-16 18:03 AugustoMauch Assigned To => Retail
2016-01-16 18:03 AugustoMauch OBNetwork customer => No
2016-01-16 18:03 AugustoMauch Triggers an Emergency Pack => No
2016-01-16 18:10 AugustoMauch Review Assigned To => mtaal
2016-01-16 18:13 hgbot Checkin
2016-01-16 18:13 hgbot Note Added: 0083360
2016-01-16 18:13 hgbot Status new => resolved
2016-01-16 18:13 hgbot Resolution open => fixed
2016-01-16 18:13 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/b6380a27f941d566695248743a83d34d124d6c3b [^]
2016-01-16 18:14 hgbot Checkin
2016-01-16 18:14 hgbot Note Added: 0083361
2016-01-18 10:45 marvintm Assigned To Retail => AugustoMauch
2016-01-18 16:05 hgbot Checkin
2016-01-18 16:05 hgbot Note Added: 0083380
2016-01-18 16:06 mtaal Review Assigned To mtaal => AugustoMauch
2016-01-21 06:36 hgbot Checkin
2016-01-21 06:36 hgbot Note Added: 0083479
2016-02-01 14:21 mtaal Review Assigned To AugustoMauch => migueldejuana
2016-02-03 15:07 migueldejuana Note Added: 0083896
2016-02-03 15:07 migueldejuana Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker