Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0031758 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Openbravo ERP] A. Platform | minor | have not tried | 2015-12-22 08:51 | 2017-02-23 18:12 | |||
Reporter | alostale | View Status | public | |||||
Assigned To | alostale | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | 3.0PR16Q1 | |||
Status | closed | Fix in branch | Fixed in SCM revision | 418ed88a6db0 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | caristu | |||||||
OBNetwork customer | OBPS | |||||||
Web browser | ||||||||
Modules | Core | |||||||
Support ticket | ||||||||
Regression level | ||||||||
Regression date | ||||||||
Regression introduced in release | ||||||||
Regression introduced by commit | ||||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0031758: error uploading attachments/images rendering OB in a frame | |||||||
Description | When Openbravo is rendered within in HTML frame, JavaScript errors are displayed when trying to upload an image or an attachment. | |||||||
Steps To Reproduce | 1. Copy attached file to WebContent directory of a deployed Openbravo (it might require to edit the iframe's src to match actual OB url. 2. Open http://localhost:8080/openbravo/framed-ob.html [^] 3. Go to Product window and open any record 3.1 Try to upload an image 3.2 Try to upload an attachment 3.3 Try to edit description of an existing attachment In all cases (3.x) a JavaScript error similar to following one appears, and the uploading popup remains open: Uncaught TypeError: top.callback is not a function | |||||||
Tags | No tags attached. | |||||||
Attached Files | ![]() | |||||||
![]() |
||||||||
|
![]() |
|
(0082921) hgbot (developer) 2015-12-22 09:29 |
Repository: erp/devel/pi Changeset: 418ed88a6db0b2be7cb2dcf8308b8e62139ef9bf Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Tue Dec 22 09:29:10 2015 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/418ed88a6db0b2be7cb2dcf8308b8e62139ef9bf [^] fixed bug 31758: error uploading attachments/images rendering OB in a frame Whent trying to upload attachments/images in an application rendered in a frame, JS errors were thrown. This was caused because callback script for those actions assumed top was the container for Openbravo, but when in a frame, top is the topmost frameset. Fixed by checking if top is OB, and if not using parent instead. --- M src/org/openbravo/erpCommon/businessUtility/TabAttachments.java M src/org/openbravo/erpCommon/info/ImageInfoBLOB.java --- |
(0082940) caristu (viewer) 2015-12-22 13:48 |
Verified working with OB inside an iframe: - Try to upload an image -- OK - Try to upload an attachment -- OK |
(0082943) hudsonbot (viewer) 2015-12-22 15:06 |
A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b29a20897f10 [^] Maturity status: Test |
![]() |
|||
Date Modified | Username | Field | Change |
2015-12-22 08:51 | alostale | New Issue | |
2015-12-22 08:51 | alostale | Assigned To | => platform |
2015-12-22 08:51 | alostale | OBNetwork customer | => No |
2015-12-22 08:51 | alostale | Modules | => Core |
2015-12-22 08:51 | alostale | Triggers an Emergency Pack | => No |
2015-12-22 08:52 | alostale | Review Assigned To | => caristu |
2015-12-22 08:52 | alostale | Assigned To | platform => alostale |
2015-12-22 08:52 | alostale | Status | new => scheduled |
2015-12-22 08:53 | alostale | File Added: framed-ob.html | |
2015-12-22 08:54 | alostale | Steps to Reproduce Updated | View Revisions |
2015-12-22 08:55 | alostale | OBNetwork customer | No => Yes |
2015-12-22 09:29 | hgbot | Checkin | |
2015-12-22 09:29 | hgbot | Note Added: 0082921 | |
2015-12-22 09:29 | hgbot | Status | scheduled => resolved |
2015-12-22 09:29 | hgbot | Resolution | open => fixed |
2015-12-22 09:29 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/devel/pi/rev/418ed88a6db0b2be7cb2dcf8308b8e62139ef9bf [^] |
2015-12-22 13:48 | caristu | Note Added: 0082940 | |
2015-12-22 13:48 | caristu | Status | resolved => closed |
2015-12-22 13:48 | caristu | Fixed in Version | => 3.0PR16Q1 |
2015-12-22 15:06 | hudsonbot | Checkin | |
2015-12-22 15:06 | hudsonbot | Note Added: 0082943 | |
2017-02-23 18:12 | caristu | Relationship added | related to 0012479 |
Copyright © 2000 - 2009 MantisBT Group |