Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0031758
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2015-12-22 08:512017-02-23 18:12
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PrioritynormalResolutionfixedFixed in Version3.0PR16Q1
StatusclosedFix in branchFixed in SCM revision418ed88a6db0
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tocaristu
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031758: error uploading attachments/images rendering OB in a frame

DescriptionWhen Openbravo is rendered within in HTML frame, JavaScript errors are displayed when trying to upload an image or an attachment.
Steps To Reproduce1. Copy attached file to WebContent directory of a deployed Openbravo (it might require to edit the iframe's src to match actual OB url.
2. Open http://localhost:8080/openbravo/framed-ob.html [^]
3. Go to Product window and open any record
3.1 Try to upload an image
3.2 Try to upload an attachment
3.3 Try to edit description of an existing attachment

In all cases (3.x) a JavaScript error similar to following one appears, and the uploading popup remains open:

  Uncaught TypeError: top.callback is not a function
TagsNo tags attached.
Attached Fileshtml file icon framed-ob.html [^] (280 bytes) 2015-12-22 08:53

- Relationships Relation Graph ] Dependency Graph ]
related to feature request 0012479 closeddbaz Openbravo ERP should has the capability to be opened within an iframe 

-  Notes
(0082921)
hgbot (developer)
2015-12-22 09:29

Repository: erp/devel/pi
Changeset: 418ed88a6db0b2be7cb2dcf8308b8e62139ef9bf
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Tue Dec 22 09:29:10 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/418ed88a6db0b2be7cb2dcf8308b8e62139ef9bf [^]

fixed bug 31758: error uploading attachments/images rendering OB in a frame

  Whent trying to upload attachments/images in an application rendered in a frame,
  JS errors were thrown.

  This was caused because callback script for those actions assumed top was the
  container for Openbravo, but when in a frame, top is the topmost frameset.

  Fixed by checking if top is OB, and if not using parent instead.

---
M src/org/openbravo/erpCommon/businessUtility/TabAttachments.java
M src/org/openbravo/erpCommon/info/ImageInfoBLOB.java
---
(0082940)
caristu (developer)
2015-12-22 13:48

Verified working with OB inside an iframe:

- Try to upload an image -- OK
- Try to upload an attachment -- OK
(0082943)
hudsonbot (developer)
2015-12-22 15:06

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b29a20897f10 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-12-22 08:51 alostale New Issue
2015-12-22 08:51 alostale Assigned To => platform
2015-12-22 08:51 alostale Modules => Core
2015-12-22 08:51 alostale Triggers an Emergency Pack => No
2015-12-22 08:52 alostale Review Assigned To => caristu
2015-12-22 08:52 alostale Assigned To platform => alostale
2015-12-22 08:52 alostale Status new => scheduled
2015-12-22 08:53 alostale File Added: framed-ob.html
2015-12-22 08:54 alostale Steps to Reproduce Updated View Revisions
2015-12-22 09:29 hgbot Checkin
2015-12-22 09:29 hgbot Note Added: 0082921
2015-12-22 09:29 hgbot Status scheduled => resolved
2015-12-22 09:29 hgbot Resolution open => fixed
2015-12-22 09:29 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/418ed88a6db0b2be7cb2dcf8308b8e62139ef9bf [^]
2015-12-22 13:48 caristu Note Added: 0082940
2015-12-22 13:48 caristu Status resolved => closed
2015-12-22 13:48 caristu Fixed in Version => 3.0PR16Q1
2015-12-22 15:06 hudsonbot Checkin
2015-12-22 15:06 hudsonbot Note Added: 0082943
2017-02-23 18:12 caristu Relationship added related to 0012479


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker