Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0031757
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Cash Managementmajoralways2015-12-21 18:552016-01-29 10:08
ReportergorkaionView Statuspublic 
Assigned Toranjith_qualiantech_com 
PrioritynormalResolutionfixedFixed in VersionRR16Q2
StatusclosedFix in branchFixed in SCM revision0194a497190a
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031757: Cash Management is not saving the Date when it is done

DescriptionThe json sent to the backend to import the Cash Management is not including the Date when it is done. Just the "time" part.

If the Cash Management is done in offline mode and it is synchronized a date later the financial account transaction generated in the backend will have the date of the synchronization instead of the real date when it was created in the terminal.
Steps To Reproduce* Open a terminal and create a Cash Management.
* Get the json from the related ImportEntry to check that the date is not send:

{
  "messageId":"B53520A16DBF8ED82932243059BA68AC",
  "data":[
    {
      "id":"A139EECBE64225BCF77263BF51997558",
      "description":"Cash - Cashier shift (transfer to VBS backoffice)",
      "amount":20,
      "origAmount":20,
      "type":"drop",
      "reasonId":"84CB7407F7834C05BD6E2ADF7A4AFC25",
      "paymentMethodId":"63339A82A49A4AE0BCD9AC5929B0EA3B",
      "user":"Demo User",
      "userId":"E49545E7D0A2413E90C31C2CDC2153B1",
      "time":"18:26",
      "isocode":"EUR",
      "cashup_id":"B6D1C2F51257B713FF91470828E48F93",
      "glItem":"FA646455DCC94D7C90CED9A6C00748E0",
      "isbeingprocessed":"N",
      "_idx":null
    }
  ],
  "client":"39363B0921BB4293B48383844325E84C",
  "organization":"D270A5AC50874F8BA67A88EE977F8E3B",
  "pos":"9104513C2D0741D4850AE8493998A7C8",
  "terminalName":"VBS-1",
  "appName":"WebPOS"
}
Proposed SolutionSend the date in the json and use it to populate the Transaction Date and Accounting date of the Transaction. Use the date and time to popuplate the creation date of the Transaction.
TagsNo tags attached.
Attached Filespatch file icon issue #31757 posterminal Source 5550.patch [^] (5,747 bytes) 2015-12-29 07:56 [Show Content]
patch file icon issue #31757 Test 4855.patch [^] (5,429 bytes) 2015-12-29 07:56 [Show Content]
patch file icon issue #31757 Source v2 5553.patch [^] (8,391 bytes) 2015-12-31 09:55 [Show Content]
patch file icon issue #31757 Test v2 4858.patch [^] (5,373 bytes) 2015-12-31 09:56 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0031503 closedguilleaer [SERQA 397] The orderDate of receipts loaded in webPOS is showing an incorrect date 
related to backport 0031643RR15Q3.3 closedOrekaria invoice date is wrong in invoice created in cashup 

-  Notes
(0083029)
ranjith_qualiantech_com (developer)
2015-12-29 07:57

Patch Attached
Source => issue 0031757 posterminal Source 5550.patch
Test => issue 0031757 Test 4855.patch
(0083049)
gorkaion (developer)
2015-12-29 13:17

I have reviewed the patch and have some doubts about the fix:

* Why name the object with the date strCashUpDate if we are loading the date of the Cash Management.
* The date and time is sent in an object called objToSend but that object is not accessed in the java.
** Why not add that information in the main json as in other entities?
** In the main json of cash management there is already a 'time' that seems to be not used. Why not use it completing the information added there, or removed if it is not needed?
(0083098)
ranjith_qualiantech_com (developer)
2015-12-31 10:00

New Patch has been attached
issue 0031757 Source v2 5553.patch
issue 0031757 Test v2 4858.patch

New Patch includes which are asked in note https://issues.openbravo.com/view.php?id=31757#c83049 [^]
(0083132)
hgbot (developer)
2016-01-05 07:25

Repository: tools/automation/pi-mobile
Changeset: 429721c6cbf8bd3b7cbfff806f61ab9cb8fb4e2a
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jan 05 11:54:34 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/429721c6cbf8bd3b7cbfff806f61ab9cb8fb4e2a [^]

Verifies issue 31757: Added automated test 'I31757_CashMgmtTrxDate'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/cashmanagement/I31757_CashMgmtTrxDate.java
---
(0083133)
hgbot (developer)
2016-01-05 07:25

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 206aa790731b56490b1e71079f87efcf7b9f7196
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Tue Jan 05 11:55:01 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/206aa790731b56490b1e71079f87efcf7b9f7196 [^]

Fixes issue 31757 : Create Cash Mgmt Transaction Date based on WEBPOS Date

---
M src/org/openbravo/retail/posterminal/ProcessCashMgmt.java
M src/org/openbravo/retail/posterminal/master/Cashup.java
M web/org.openbravo.retail.posterminal/js/cashmgmt/model/cashmgmt-model.js
M web/org.openbravo.retail.posterminal/js/cashmgmt/view/listdepositsdrops.js
M web/org.openbravo.retail.posterminal/js/model/cashmanagement.js
---
(0083519)
guilleaer (manager)
2016-01-22 08:45

reopened after test and review.

I think that there is an error there when you read the date in the server (ProcessCashMgmt.java)
There you should read the field "creationDate" (the one that you added) but you are reading "dateTime" so the cashmgmt transaction is always stored with the server date
(0083695)
hgbot (developer)
2016-01-29 06:15

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 0194a497190ab1be211e5bd9b4bfd75b4e66dd25
Author: Ranjith S R <ranjith <at> qualiantech.com>
Date: Fri Jan 29 10:43:29 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0194a497190ab1be211e5bd9b4bfd75b4e66dd25 [^]

Fixes issue 31757 : Create Cash Mgmt Transaction Date based on WEBPOS Date

Adding Creation Date & timezoneOffset in Cash Management Model

---
M src/org/openbravo/retail/posterminal/ProcessCashMgmt.java
M web/org.openbravo.retail.posterminal/js/utils/cashManagementUtils.js
---
(0083720)
guilleaer (manager)
2016-01-29 10:08

code reviewed and tested

- Issue History
Date Modified Username Field Change
2015-12-21 18:55 gorkaion New Issue
2015-12-21 18:55 gorkaion Assigned To => Retail
2015-12-21 18:55 gorkaion Triggers an Emergency Pack => No
2015-12-22 11:03 gorkaion Resolution time => 1451948400
2015-12-22 11:07 Orekaria Status new => acknowledged
2015-12-28 08:13 ranjith_qualiantech_com Assigned To Retail => ranjith_qualiantech_com
2015-12-28 08:13 ranjith_qualiantech_com Status acknowledged => scheduled
2015-12-29 07:56 ranjith_qualiantech_com File Added: issue #31757 posterminal Source 5550.patch
2015-12-29 07:56 ranjith_qualiantech_com File Added: issue #31757 Test 4855.patch
2015-12-29 07:57 ranjith_qualiantech_com Note Added: 0083029
2015-12-29 13:17 gorkaion Note Added: 0083049
2015-12-29 14:05 ranjith_qualiantech_com Note Added: 0083053
2015-12-31 09:55 ranjith_qualiantech_com File Added: issue #31757 Source v2 5553.patch
2015-12-31 09:56 ranjith_qualiantech_com File Added: issue #31703 Test 4852.patch
2015-12-31 09:56 ranjith_qualiantech_com File Deleted: issue #31703 Test 4852.patch
2015-12-31 09:56 ranjith_qualiantech_com File Added: issue #31757 Test v2 4858.patch
2015-12-31 09:59 ranjith_qualiantech_com Note Deleted: 0083053
2015-12-31 10:00 ranjith_qualiantech_com Note Added: 0083098
2015-12-31 11:33 Orekaria Relationship added related to 0031503
2015-12-31 11:34 Orekaria Relationship added related to 0031643
2016-01-05 07:25 hgbot Checkin
2016-01-05 07:25 hgbot Note Added: 0083132
2016-01-05 07:25 hgbot Checkin
2016-01-05 07:25 hgbot Note Added: 0083133
2016-01-05 07:25 hgbot Status scheduled => resolved
2016-01-05 07:25 hgbot Resolution open => fixed
2016-01-05 07:25 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/206aa790731b56490b1e71079f87efcf7b9f7196 [^]
2016-01-22 08:45 guilleaer Note Added: 0083519
2016-01-22 08:45 guilleaer Status resolved => new
2016-01-22 08:45 guilleaer Resolution fixed => open
2016-01-22 10:05 ranjith_qualiantech_com Status new => scheduled
2016-01-29 06:15 hgbot Checkin
2016-01-29 06:15 hgbot Note Added: 0083695
2016-01-29 06:15 hgbot Status scheduled => resolved
2016-01-29 06:15 hgbot Resolution open => fixed
2016-01-29 06:15 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/206aa790731b56490b1e71079f87efcf7b9f7196 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/0194a497190ab1be211e5bd9b4bfd75b4e66dd25 [^]
2016-01-29 10:08 guilleaer Review Assigned To => guilleaer
2016-01-29 10:08 guilleaer Note Added: 0083720
2016-01-29 10:08 guilleaer Status resolved => closed
2016-01-29 10:08 guilleaer Fixed in Version => RR16Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker