0031746: [SERQA 486] Payment buttons added from external modules missing under certain circumstances

Description

When the amount of buttons added from external modules* matches the number of "core" buttons shown on the 'More payments' popup, external payments are not added to the 'More payments' popup.
E.g.: if the core configuration of a terminal includes 6 payments (4 payments will be directly shown and 2 will be on the 'More payments' popup), and the user installs the Giftcards and Vouchers module (which adds 2 payment buttons), the giftcard payment buttons will not be shown in web pos

Steps To Reproduce

Install the Giftcards and Vouchers module
Configure a POS Terminal in backend with 6 payment methods.
Login in web pos.
Create a ticket and add a product.
Click on the Total Amount button to pay the ticket.
Verify that 4 payment method buttons are shown, plus the 'More' button.
Click on the 'More' button and verify that only the 2 payment methods defined in the terminal are shown. The 'Gift Card' and 'Gift Voucher' buttons are not shown.

Proposed Solution

The following code adds external buttons to the payment button list:
    enyo.forEach(this.sideButtons, function (sidebutton) {
      btncomponent = this.getButtonComponent(sidebutton);
      if (countbuttons++ < paymentsbuttons) {
        this.createComponent(btncomponent);
      } else if (this.sideButtons.length !== OB.OBPOSPointOfSale.UI.PaymentMethods.prototype.sideButtons.length) {
        OB.OBPOSPointOfSale.UI.PaymentMethods.prototype.sideButtons.push(btncomponent);
        dialogbuttons[sidebutton.command] = sidebutton.label;
      } else {
        dialogbuttons[sidebutton.command] = sidebutton.label;
      }
    }, this);

This condition:
} else if (this.sideButtons.length !== OB.OBPOSPointOfSale.UI.PaymentMethods.prototype.sideButtons.length) {
should probably be removed, and the logic inside that else-if moved to the final else.

Tags

SER-QA

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

duplicate of

defect

0031718

closed

ranjith_qualiantech_com

[SERQA 486]payment type "gift card" is not displayed when there is 6 payment methods

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2015-12-17 18:07	aaroncalero	New Issue
2015-12-17 18:07	aaroncalero	Assigned To	=> Retail
2015-12-17 18:07	aaroncalero	Resolution time	=> 1451516400
2015-12-17 18:07	aaroncalero	Triggers an Emergency Pack	=> No
2015-12-17 18:11	aaroncalero	Summary	Payment buttons added from external modules missing under certain circumstances => [SERQA 486] Payment buttons added from external modules missing under certain circumstances
2015-12-17 18:12	aaroncalero	Tag Attached: SER-QA
2015-12-17 21:54	Orekaria	Relationship added	related to 0031718
2015-12-18 08:09	aaroncalero	Relationship replaced	duplicate of 0031718
2015-12-18 08:10	aaroncalero	Status	new => closed
2015-12-18 08:10	aaroncalero	Resolution	open => duplicate