0031746: [SERQA 486] Payment buttons added from external modules missing under certain circumstances

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0031746

Retail Modules

Web POS

public

2015-12-17 18:07

2015-12-18 08:10

Reporter

aaroncalero

Assigned To

Retail

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

duplicate

Platform

OS Version

Product Version

Target Version

Fixed in Version

Merge Request Status

Review Assigned To

OBNetwork customer

OBPS

Support ticket

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

Summary

0031746: [SERQA 486] Payment buttons added from external modules missing under certain circumstances

Description

When the amount of buttons added from external modules* matches the number of "core" buttons shown on the 'More payments' popup, external payments are not added to the 'More payments' popup.
E.g.: if the core configuration of a terminal includes 6 payments (4 payments will be directly shown and 2 will be on the 'More payments' popup), and the user installs the Giftcards and Vouchers module (which adds 2 payment buttons), the giftcard payment buttons will not be shown in web pos

Steps To Reproduce

Install the Giftcards and Vouchers module
Configure a POS Terminal in backend with 6 payment methods.
Login in web pos.
Create a ticket and add a product.
Click on the Total Amount button to pay the ticket.
Verify that 4 payment method buttons are shown, plus the 'More' button.
Click on the 'More' button and verify that only the 2 payment methods defined in the terminal are shown. The 'Gift Card' and 'Gift Voucher' buttons are not shown.

Proposed Solution

The following code adds external buttons to the payment button list:
    enyo.forEach(this.sideButtons, function (sidebutton) {
      btncomponent = this.getButtonComponent(sidebutton);
      if (countbuttons++ < paymentsbuttons) {
        this.createComponent(btncomponent);
      } else if (this.sideButtons.length !== OB.OBPOSPointOfSale.UI.PaymentMethods.prototype.sideButtons.length) {
        OB.OBPOSPointOfSale.UI.PaymentMethods.prototype.sideButtons.push(btncomponent);
        dialogbuttons[sidebutton.command] = sidebutton.label;
      } else {
        dialogbuttons[sidebutton.command] = sidebutton.label;
      }
    }, this);

This condition:
} else if (this.sideButtons.length !== OB.OBPOSPointOfSale.UI.PaymentMethods.prototype.sideButtons.length) {
should probably be removed, and the logic inside that else-if moved to the final else.

Additional Information