Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0031742
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2015-12-17 15:062015-12-28 16:43
ReporterguillermogilView Statuspublic 
Assigned Tosimbu94 
PriorityhighResolutionfixedFixed in VersionRR16Q1
StatusclosedFix in branchFixed in SCM revision109e42f6be54
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionProfessional ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned Tojorge-garcia
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031742: Cancel a payment with paymentData and no VoidTransaction function creates an error

DescriptionCancel a payment with paymentData and no VoidTransaction function creates an error.

Error:
TypeError: voidTransaction is not a function
    at callVoidTransaction (fab28d396699f3dea414d78c44238eff_WebPOS.js:38168)
    at Object.OB.UTIL.showConfirmation.display.action (fab28d396699f3dea414d78c44238eff_WebPOS.js:38203)
    at Object.button.tap (fab28d396699f3dea414d78c44238eff_WebPOS.js:10015)
    at Object.enyo.kind.dispatch (enyo.js:628)
    at Object.enyo.kind.dispatchEvent (enyo.js:612)
    at Object.enyo.kind.inherited (enyo.js:410)
    at Object.enyo.kind.dispatchEvent (enyo.js:1338)
    at Object.enyo.kind.dispatchBubble (enyo.js:616)
    at Object.enyo.kind.bubble (enyo.js:604)
    at Object.enyo.dispatcher.dispatchBubble (enyo.js:1783)
    at Object.enyo.dispatcher.dispatch [as dispatch] (enyo.js:1762)
    at Object.enyo.dispatch (enyo.js:1788); line: Object.OB.UTIL.showError (http://localhost:8080/openbravo/web/js/gen/fab28d396699f3dea414d78c44238eff_WebPOS.js:10150:6 [^]) (*,+)processConsoleLevel @ fab28d396699f3dea414d78c44238eff_WebPOS.js:2522
fab28d396699f3dea414d78c44238eff_WebPOS.js:38168 Uncaught TypeError: voidTransaction is not a function
Steps To ReproduceCreate a Payment with paymentData.
e.g.-
      OB.MobileApp.model.receipt.addPayment(new OB.Model.PaymentLine({
        kind: payment.payment.searchKey,
        name: OB.MobileApp.model.getPaymentName(payment.payment.searchKey),
        amount: OB.DEC.number(OB.DEC.div(amount, 100)),
        rate: payment.rate,
        mulrate: payment.mulrate,
        isocode: payment.isocode,
        isCash: payment.paymentMethod.iscash,
        allowOpenDrawer: payment.paymentMethod.allowopendrawer,
        openDrawer: payment.paymentMethod.openDrawer,
        printtwice: payment.paymentMethod.printtwice,
        paymentData: {
          serialNumber: voucherNumber
        }
      })
Then try to cancel it. It will show an error
Proposed SolutionEnsure that the WebPOS does not fail when, in a payment, the paymentData is defined and the voidTransaction is not defined
Right now, the application tries to execute voidTransaction even if the voidTransaction is not defined
TagsNo tags attached.
Attached Filespng file icon Screenshot from 2015-12-17 15:04:04.png [^] (344,825 bytes) 2015-12-17 15:06

- Relationships Relation Graph ] Dependency Graph ]
related to defect 0031743 closedranjith_qualiantech_com Cancel a payment with paymentData after a refresh creates an error 

-  Notes
(0082931)
hgbot (developer)
2015-12-22 11:25

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 109e42f6be54d5c8369c1ab81f64981d7d8dd4ea
Author: Silambarasan Sekar <silambarasan <at> qualiantech.com>
Date: Tue Dec 22 15:54:17 2015 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/109e42f6be54d5c8369c1ab81f64981d7d8dd4ea [^]

Fixed Issue 31742: Ignore Void Transaction Function if voidTransaction is not defined.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0082932)
hgbot (developer)
2015-12-22 11:25

Repository: tools/automation/pi-mobile
Changeset: e869045470e449f75a2fa6dde92ac35c44b34575
Author: Silambarasan Sekar <silambarasan <at> qualiantech.com>
Date: Tue Dec 22 15:54:22 2015 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/e869045470e449f75a2fa6dde92ac35c44b34575 [^]

Verifies issue 31742: Added automated test 'I31742_CancelPaymentWithPaymentDataNoVoidTranx'

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I31742_CancelPaymentWithPaymentDataNoVoidTranx.java
---
(0082962)
hgbot (developer)
2015-12-23 13:42

Repository: tools/automation/pi-mobile
Changeset: 96c0c6bc93bcd8be755be25575df9fec5c4b5cc9
Author: Silambarasan Sekar <silambarasan <at> qualiantech.com>
Date: Wed Dec 23 18:10:47 2015 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/96c0c6bc93bcd8be755be25575df9fec5c4b5cc9 [^]

Verifies issue 31742: Added automated test 'I31742_CancelPaymentWithPaymentDataNoVoidTranx'

---
M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/system/I31742_CancelPaymentWithPaymentDataNoVoidTranx.java
---
(0083016)
jorge-garcia (reporter)
2015-12-28 16:43

Code review and testing ok

- Issue History
Date Modified Username Field Change
2015-12-17 15:06 guillermogil New Issue
2015-12-17 15:06 guillermogil Assigned To => Retail
2015-12-17 15:06 guillermogil File Added: Screenshot from 2015-12-17 15:04:04.png
2015-12-17 15:06 guillermogil Resolution time => 1450738800
2015-12-17 15:06 guillermogil Triggers an Emergency Pack => No
2015-12-17 15:07 guillermogil Summary Cancel a payment with paymentData and no VoidTransaction functioin creates and error => Cancel a payment with paymentData and no VoidTransaction function creates an error
2015-12-17 15:07 guillermogil Description Updated View Revisions
2015-12-17 15:17 guillermogil Relationship added related to 0031743
2015-12-17 18:27 Orekaria Proposed Solution updated
2015-12-17 19:12 Orekaria Status new => acknowledged
2015-12-22 06:35 simbu94 Assigned To Retail => simbu94
2015-12-22 07:50 simbu94 Status acknowledged => scheduled
2015-12-22 11:25 hgbot Checkin
2015-12-22 11:25 hgbot Note Added: 0082931
2015-12-22 11:25 hgbot Status scheduled => resolved
2015-12-22 11:25 hgbot Resolution open => fixed
2015-12-22 11:25 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/109e42f6be54d5c8369c1ab81f64981d7d8dd4ea [^]
2015-12-22 11:25 hgbot Checkin
2015-12-22 11:25 hgbot Note Added: 0082932
2015-12-23 13:42 hgbot Checkin
2015-12-23 13:42 hgbot Note Added: 0082962
2015-12-28 16:03 jorge-garcia Review Assigned To => jorge-garcia
2015-12-28 16:43 jorge-garcia Note Added: 0083016
2015-12-28 16:43 jorge-garcia Status resolved => closed
2015-12-28 16:43 jorge-garcia Fixed in Version => RR16Q1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker