Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0031624 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| feature request | [Retail Modules] Web POS | minor | have not tried | 2015-12-01 10:29 | 2018-06-26 11:42 | |||
| Reporter | aaroncalero | View Status | public | |||||
| Assigned To | aaroncalero | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | RR17Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | d7b9f1285ddc | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | ||||||||
| Review Assigned To | marvintm | |||||||
| OBNetwork customer | No | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0031624: Implement the ability to add Digital Coupons as payments to WebPOS | |||||||
| Description | Implement the ability to manage Digital Coupons (such as Cheque Gourmet) from the POS as payment methods. The main development will be done on the following module: https://code.openbravo.com/erp/pmods/org.openbravo.retail.digitalcoupons [^] | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|
 Relationships |
|
Notes |
|
|
(0097929) hgbot (developer) 2017-07-07 09:34 |
Repository: erp/pmods/org.openbravo.retail.digitalcoupons Changeset: 9659f497c359495dc866e69c461429af85aa3a9b Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Fri Jul 07 09:32:25 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.digitalcoupons/rev/9659f497c359495dc866e69c461429af85aa3a9b [^] Related to issue 31624: [Digital Coupons] Code Review: Changed label of button 'Manual Mode' to Add Coupon --- M src-db/database/sourcedata/AD_MESSAGE.xml --- |
|
(0097931) hgbot (developer) 2017-07-07 10:00 |
Repository: erp/pmods/org.openbravo.retail.digitalcoupons Changeset: 19fd75cda257aa1d09f4c17c9a16da0fbeca1113 Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Fri Jul 07 10:00:13 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.digitalcoupons/rev/19fd75cda257aa1d09f4c17c9a16da0fbeca1113 [^] Related to issue 31624: [Digital Coupons] Code Review: Changed hooks to extend abstract classes --- M src/org/openbravo/retail/digitalcoupons/process/DigitalCouponsPaidReceiptsPaymentsInHook.java M src/org/openbravo/retail/digitalcoupons/process/DigitalCouponsPaidReceiptsPaymentsTypeHook.java --- |
|
(0097932) hgbot (developer) 2017-07-07 10:03 |
Repository: erp/pmods/org.openbravo.retail.digitalcoupons Changeset: 9f527ec4786499cc652928a68510994a19b6966d Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Fri Jul 07 10:03:33 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.digitalcoupons/rev/9f527ec4786499cc652928a68510994a19b6966d [^] Related to issue 31624: [Digital Coupons] Code Review: Changed license year for DigitalCouponsComponentProvider.java --- M src/org/openbravo/retail/digitalcoupons/DigitalCouponsComponentProvider.java --- |
|
(0097946) hgbot (developer) 2017-07-07 13:33 |
Repository: erp/pmods/org.openbravo.retail.digitalcoupons Changeset: 19d3e5511560959514f0558dcc402d680c4e3625 Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Fri Jul 07 13:31:25 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.digitalcoupons/rev/19d3e5511560959514f0558dcc402d680c4e3625 [^] Related to issue 31624: Code Review: Removed subquery from IssuingCompanyProperties and moved join to main query --- M src/org/openbravo/retail/digitalcoupons/master/IssuingCompany.java M src/org/openbravo/retail/digitalcoupons/master/IssuingCompanyProperties.java --- |
|
(0097951) hgbot (developer) 2017-07-07 14:03 |
Repository: erp/pmods/org.openbravo.retail.digitalcoupons Changeset: 6d59b7c81c8232d0d4ff900268ed81b2cfad0145 Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Fri Jul 07 14:01:34 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.digitalcoupons/rev/6d59b7c81c8232d0d4ff900268ed81b2cfad0145 [^] Related to issue 31624: Code Review: Fixed license years --- M src/org/openbravo/retail/digitalcoupons/master/IssuingCompany.java M src/org/openbravo/retail/digitalcoupons/master/IssuingCompanyProperties.java M src/org/openbravo/retail/digitalcoupons/master/SubType.java M src/org/openbravo/retail/digitalcoupons/master/SubTypeProperties.java M src/org/openbravo/retail/digitalcoupons/process/DigitalCouponsPaidReceiptsPaymentsProperties.java M web/org.openbravo.retail.digitalcoupons/css/obdico-standard.css M web/org.openbravo.retail.digitalcoupons/js/hookPaymentSelected.js M web/org.openbravo.retail.digitalcoupons/js/hookPreAddPayment.js M web/org.openbravo.retail.digitalcoupons/js/modalDigitalCoupons.js M web/org.openbravo.retail.digitalcoupons/js/model/issuingCompany.js M web/org.openbravo.retail.digitalcoupons/js/model/subType.js M web/org.openbravo.retail.digitalcoupons/js/utils/digitalcouponutils.js --- |
|
(0097957) hgbot (developer) 2017-07-07 14:21 |
Repository: erp/pmods/org.openbravo.retail.digitalcoupons Changeset: 603c5d7541edc006138493c91f007403b30fa63c Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Fri Jul 07 14:20:37 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.digitalcoupons/rev/603c5d7541edc006138493c91f007403b30fa63c [^] Related to issue 31624: Code Review: Moved join with issuingCompany to the main query of SubTypes --- M src/org/openbravo/retail/digitalcoupons/master/SubType.java M src/org/openbravo/retail/digitalcoupons/master/SubTypeProperties.java --- |
|
(0097958) hgbot (developer) 2017-07-07 14:25 |
Repository: erp/pmods/org.openbravo.retail.digitalcoupons Changeset: 7c8b07babd071cb794d1c233dfa792fcb5526341 Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Fri Jul 07 14:24:52 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.digitalcoupons/rev/7c8b07babd071cb794d1c233dfa792fcb5526341 [^] Related to issue 31624: Code Review: Fixed typo --- M src/org/openbravo/retail/digitalcoupons/process/DigitalCouponsPaidReceiptsPaymentsInHook.java --- |
|
(0097979) hgbot (developer) 2017-07-10 15:34 |
Repository: erp/pmods/org.openbravo.retail.digitalcoupons Changeset: 46221419b82deab0ea2aaee88409ce4f8cc8e554 Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Mon Jul 10 15:31:14 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.digitalcoupons/rev/46221419b82deab0ea2aaee88409ce4f8cc8e554 [^] Related to issue 31624: Code Review: Query PaymentType directly, instead of looping in code --- M src/org/openbravo/retail/digitalcoupons/master/IssuingCompanyProperties.java M src/org/openbravo/retail/digitalcoupons/process/DigitalCouponsOrderLoaderHook.java --- |
|
(0097981) hgbot (developer) 2017-07-10 16:13 |
Repository: erp/pmods/org.openbravo.retail.digitalcoupons Changeset: 4c84ba4d4bf642bdc6726a42feb32df42b4da8f5 Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Mon Jul 10 16:04:26 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.digitalcoupons/rev/4c84ba4d4bf642bdc6726a42feb32df42b4da8f5 [^] Related to issue 31624: Code Review: Simplified code --- M web/org.openbravo.retail.digitalcoupons/js/hookPreAddPayment.js --- |
|
(0097990) hgbot (developer) 2017-07-10 17:19 |
Repository: erp/pmods/org.openbravo.retail.digitalcoupons Changeset: 1222f5a2d387a7c910c31153b6fe9a1fb28717c9 Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Mon Jul 10 17:18:42 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.digitalcoupons/rev/1222f5a2d387a7c910c31153b6fe9a1fb28717c9 [^] Related to issue 31624: Code Review: Move the code to a callback so it is executed after the save() if needed --- M web/org.openbravo.retail.digitalcoupons/js/hookPreAddPayment.js M web/org.openbravo.retail.digitalcoupons/js/modalDigitalCoupons.js --- |
|
(0098002) hgbot (developer) 2017-07-11 10:06 |
Repository: erp/pmods/org.openbravo.retail.digitalcoupons Changeset: 7b699697a937df2af15771cbf0a2f01e0e6c8aaa Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Tue Jul 11 10:04:14 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.digitalcoupons/rev/7b699697a937df2af15771cbf0a2f01e0e6c8aaa [^] Related to issue 31624: Code Review: Added ad_client_id to unique constraints OBDICO_ICA_ORG_UNI and OBDICO_UNIQUE_CODE_IC --- M src-db/database/model/tables/OBDICO_ISSUING_COMP_ACCOUNT.xml M src-db/database/model/tables/OBDICO_SUBTYPE.xml --- |
|
(0098565) hgbot (developer) 2017-08-22 08:30 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 51b9a22c899d53ce2fd8e4356ed3c49885557cad Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Fri Jun 30 09:45:21 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/51b9a22c899d53ce2fd8e4356ed3c49885557cad [^] Related to issue 31624: [Digital Coupons] Removed duplicated code --- M web/org.openbravo.retail.posterminal/js/components/renderorderline.js --- |
|
(0098566) hgbot (developer) 2017-08-22 08:31 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e584c42e762d3a3d01ac08bfe49e9b8a46efafd4 Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Fri Jul 07 09:54:36 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e584c42e762d3a3d01ac08bfe49e9b8a46efafd4 [^] Related to issue 31624: [Digital Coupons] Code Review: Keep old API for the processPayments method in OrderLoader --- M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
|
(0098567) hgbot (developer) 2017-08-22 08:31 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: fca00e9685c6b7a67aa3b1f00f81fd6cd7740f80 Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Fri Jul 07 09:59:23 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fca00e9685c6b7a67aa3b1f00f81fd6cd7740f80 [^] Related to issue 31624: [Digital Coupons] Code Review: Changed definition of hooks to be abstract classes --- M src/org/openbravo/retail/posterminal/PaidReceiptsPaymentsInHook.java M src/org/openbravo/retail/posterminal/PaidReceiptsPaymentsTypeHook.java --- |
|
(0098568) hgbot (developer) 2017-08-22 08:31 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: b645e7f9bf8cc9c090cb26063ba1691a1b90788f Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Mon Aug 14 09:50:42 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b645e7f9bf8cc9c090cb26063ba1691a1b90788f [^] Fixed issue 31624: [Digital Coupons] Merged with Posterminal --- M src/org/openbravo/retail/posterminal/OrderLoader.java M src/org/openbravo/retail/posterminal/PaidReceipts.java M web/org.openbravo.retail.posterminal/js/components/renderorderline.js M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalpayments.js A src/org/openbravo/retail/posterminal/PaidReceiptsPaymentsInHook.java A src/org/openbravo/retail/posterminal/PaidReceiptsPaymentsTypeHook.java --- |
|
(0098569) hgbot (developer) 2017-08-22 08:31 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: d7b9f1285ddcbac55b4b41df2f70e69494ca2496 Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Tue Aug 22 08:25:48 2017 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d7b9f1285ddcbac55b4b41df2f70e69494ca2496 [^] Fixed issue 31624: [Digital Coupons] Merged with Posterminal --- M src/org/openbravo/retail/posterminal/OrderLoader.java M src/org/openbravo/retail/posterminal/PaidReceipts.java M web/org.openbravo.retail.posterminal/js/components/renderorderline.js M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/modals/modalpayments.js A src/org/openbravo/retail/posterminal/PaidReceiptsPaymentsInHook.java A src/org/openbravo/retail/posterminal/PaidReceiptsPaymentsTypeHook.java --- |
|
(0098622) hgbot (developer) 2017-08-24 08:31 |
Repository: tools/automation/pi-mobile Changeset: 6520cd527f417cdd8c34351f6058750468a4b3a8 Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Mon Jul 03 14:37:24 2017 +0200 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/6520cd527f417cdd8c34351f6058750468a4b3a8 [^] Related to issue 31624: [Digital Coupons] Fixed tests --- M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/cashup/I33915_CreateCashUpPaymentsOnOpenTill.java M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/creditnote/PayUsingCreditNote.java M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/giftcards/TryToPayMoreThanCardBalance.java M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/productonfly/CreateOTFAndDoCancelAndReplace.java M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I34235_CashUpSynchonizedWithOpenTillRequest.java M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/sessions/openstoretill/I36052_VerifyMultiPaymentMethodWithInitialCountCash.java --- |
|
(0098623) hgbot (developer) 2017-08-24 08:31 |
Repository: tools/automation/pi-mobile Changeset: 1d4279dfac2673b784a0e2de5bfc368c90c90183 Author: Aaron Calero <aaron.calero <at> openbravo.com> Date: Fri Jul 07 09:00:34 2017 +0200 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/1d4279dfac2673b784a0e2de5bfc368c90c90183 [^] Related to issue 31624: [Digital Coupons] Code review: Changed payment method, issuing company and subtype names --- M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/TestIdExtModules.java M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/digital_coupons/DigitalCoupons.java M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/digital_coupons/DigitalCouponsMultiple.java M src-test/org/openbravo/test/mobile/retail/extmodules/selenium/tests/digital_coupons/DigitalCouponsReversePayment.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-12-01 10:29 | aaroncalero | New Issue | |
| 2015-12-01 10:29 | aaroncalero | Assigned To | => aaroncalero |
| 2015-12-01 10:29 | aaroncalero | OBNetwork customer | => No |
| 2015-12-01 10:29 | aaroncalero | Triggers an Emergency Pack | => No |
| 2017-07-07 09:34 | hgbot | Checkin | |
| 2017-07-07 09:34 | hgbot | Note Added: 0097929 | |
| 2017-07-07 10:00 | hgbot | Checkin | |
| 2017-07-07 10:00 | hgbot | Note Added: 0097931 | |
| 2017-07-07 10:03 | hgbot | Checkin | |
| 2017-07-07 10:03 | hgbot | Note Added: 0097932 | |
| 2017-07-07 13:33 | hgbot | Checkin | |
| 2017-07-07 13:33 | hgbot | Note Added: 0097946 | |
| 2017-07-07 14:03 | hgbot | Checkin | |
| 2017-07-07 14:03 | hgbot | Note Added: 0097951 | |
| 2017-07-07 14:21 | hgbot | Checkin | |
| 2017-07-07 14:21 | hgbot | Note Added: 0097957 | |
| 2017-07-07 14:25 | hgbot | Checkin | |
| 2017-07-07 14:25 | hgbot | Note Added: 0097958 | |
| 2017-07-10 15:34 | hgbot | Checkin | |
| 2017-07-10 15:34 | hgbot | Note Added: 0097979 | |
| 2017-07-10 16:13 | hgbot | Checkin | |
| 2017-07-10 16:13 | hgbot | Note Added: 0097981 | |
| 2017-07-10 17:19 | hgbot | Checkin | |
| 2017-07-10 17:19 | hgbot | Note Added: 0097990 | |
| 2017-07-11 10:06 | hgbot | Checkin | |
| 2017-07-11 10:06 | hgbot | Note Added: 0098002 | |
| 2017-08-22 08:30 | hgbot | Checkin | |
| 2017-08-22 08:30 | hgbot | Note Added: 0098565 | |
| 2017-08-22 08:31 | hgbot | Checkin | |
| 2017-08-22 08:31 | hgbot | Note Added: 0098566 | |
| 2017-08-22 08:31 | hgbot | Checkin | |
| 2017-08-22 08:31 | hgbot | Note Added: 0098567 | |
| 2017-08-22 08:31 | hgbot | Checkin | |
| 2017-08-22 08:31 | hgbot | Note Added: 0098568 | |
| 2017-08-22 08:31 | hgbot | Status | new => resolved |
| 2017-08-22 08:31 | hgbot | Resolution | open => fixed |
| 2017-08-22 08:31 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b645e7f9bf8cc9c090cb26063ba1691a1b90788f [^] |
| 2017-08-22 08:31 | hgbot | Checkin | |
| 2017-08-22 08:31 | hgbot | Note Added: 0098569 | |
| 2017-08-22 08:31 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/b645e7f9bf8cc9c090cb26063ba1691a1b90788f [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d7b9f1285ddcbac55b4b41df2f70e69494ca2496 [^] |
| 2017-08-24 08:31 | hgbot | Checkin | |
| 2017-08-24 08:31 | hgbot | Note Added: 0098622 | |
| 2017-08-24 08:31 | hgbot | Checkin | |
| 2017-08-24 08:31 | hgbot | Note Added: 0098623 | |
| 2017-09-04 11:33 | marvintm | Review Assigned To | => marvintm |
| 2017-09-04 11:33 | marvintm | Status | resolved => closed |
| 2017-09-04 11:33 | marvintm | Fixed in Version | => RR17Q4 |
| 2018-06-26 11:42 | hgbot | Checkin | |
| 2018-06-26 11:42 | hgbot | Note Added: 0105423 | |
| 2018-06-26 14:11 | gorka_gil | Note Deleted: 0105423 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |