Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0031481
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformminorhave not tried2015-11-14 14:162015-11-26 09:43
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in Version3.0PR16Q1
StatusclosedFix in branchFixed in SCM revisionb252497be371
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Toalostale
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0031481: Fix javadoc generation

DescriptionGenerating javadoc for pi using the 'ant generate.java.doc' target has quite some problems. One introduced by not updating the target in the latest src-test/cdi changes + but also lots of old issues there since a long time.

This issue is to fix the following items:
- remove linksource=no as that is default already
- fix ${base.src.test} reference as that should be §{base.src.test}/src as otherwise it reads packages as src.org.openbravo.test instead of org.openbravo.test
- add src + src-test below any installed modules when generating docs, as otherwise half of code is not covered
- add jar files below modules/*/lib/test to find references to those in test code
- update link to java6 core docs from outdated java.sun.com url to docs.oracle.com (note: keep at java6 as that is still oldest version supported)

Plus through in 3 unrelated javadoc syntax fixes to fix up javadoc warnings shown on generation
Steps To Reproducerun ant generate.java.doc and notice the many errors and warnings happening
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]

-  Notes
(0081909)
hgbot (developer)
2015-11-16 19:18

 Repository: erp/devel/pi
Changeset: b252497be371e0adf8bb4288ce214c23c0126996
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Sat Nov 14 14:19:01 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b252497be371e0adf8bb4288ce214c23c0126996 [^]

Fixed 31481: Fix & improve javadoc generation

- add modules src + src-test to generated javadoc to not miss all the
  code in modules in the docs (convert to subelement sourcepath for this)
- fix referencing java sources in src-test by adding /src to the reference
- add modules/*/lib/test/*.jar to find referenced class in test code
- update link to standard java6 javadoc to use newer url

- 2-3 simple javadoc syntax fixes in java files

---
M build.xml
M modules/org.openbravo.client.application/src/org/openbravo/client/application/report/ReportingUtils.java
M modules/org.openbravo.service.json/src/org/openbravo/service/json/UnpagedRequestCachedPreference.java
M src/org/openbravo/financial/FinancialUtils.java
---
(0082359)
alostale (viewer)
2015-11-26 09:43

 code reviewed

generated javadoc looks fine

- Issue History
Date Modified Username Field Change
2015-11-14 14:16 shuehner New Issue
2015-11-14 14:16 shuehner Assigned To => shuehner
2015-11-14 14:16 shuehner OBNetwork customer => No
2015-11-14 14:16 shuehner Modules => Core
2015-11-14 14:16 shuehner Triggers an Emergency Pack => No
2015-11-16 14:01 shuehner Review Assigned To => alostale
2015-11-16 19:18 hgbot Checkin
2015-11-16 19:18 hgbot Note Added: 0081909
2015-11-16 19:18 hgbot Status new => resolved
2015-11-16 19:18 hgbot Resolution open => fixed
2015-11-16 19:18 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/b252497be371e0adf8bb4288ce214c23c0126996 [^]
2015-11-26 09:43 alostale Note Added: 0082359
2015-11-26 09:43 alostale Status resolved => closed
2015-11-26 09:43 alostale Fixed in Version => 3.0PR16Q1

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker