Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0031390 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| backport | [Retail Modules] Discounts and Promotions | major | always | 2015-08-04 13:41 | 2015-12-03 18:01 | |||
| Reporter | malsasua | View Status | public | |||||
| Assigned To | jorge-garcia | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | RR15Q3.3 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | 72d3ee12d66b | ||||
| Projection | none | ETA | none | Target Version | RR15Q3.3 | |||
| OS | Linux 32 bit | Database | PostgreSQL | Java version | 1.6.0_18 | |||
| OS Version | Community Appliance | Database version | 8.3.9 | Ant version | 1.7.1 | |||
| Product Version | SCM revision | |||||||
| Review Assigned To | guilleaer | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0031390: infinite loop with discounts of type "Buy X pay Y of different product" | |||||||
| Description | when there are several discounts of type "Buy X pay Y of different product", and several products are added to receipt, then the total button never is enabled. Infinite loop in discount executor note: with old flow discount is working fine | |||||||
| Steps To Reproduce | . in back office: . go to discount and promotions window . create three new discounts: disc1: see disc1 attached disc2: see disc2 attached disc3: see disc3 attached . in web pos . create a new receipt (see receipt.png attached). Add the products quickly total button never is enabled | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0082310) hgbot (developer) 2015-11-25 08:42 |
Repository: retail/backports/3.0RR15Q3.3/org.openbravo.retail.posterminal Changeset: 72d3ee12d66bfa9e30986477eaeecd3ce8334d0a Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Fri Nov 06 11:20:43 2015 +0100 URL: http://code.openbravo.com/retail/backports/3.0RR15Q3.3/org.openbravo.retail.posterminal/rev/72d3ee12d66bfa9e30986477eaeecd3ce8334d0a [^] Fixed issue 31390: infinite loop with discounts of type "Buy X pay Y of different product" It's necessary to set two flags in the applyDiscounts process. “IsBeingDiscounted” indicates that the process is running. The second, “reApplyDiscounts” is set to true if the applyDiscounts process is called more than once, applying the discounts only one more time. This way, the process doesn't do an infinite loop calculating discounts. --- M web/org.openbravo.retail.posterminal/js/model/discounts.js M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
(0082311) hgbot (developer) 2015-11-25 08:42 |
Repository: retail/backports/3.0RR15Q3.3/org.openbravo.retail.posterminal Changeset: 88deb600cc7ab96a2a6209513de2862aadd8dc92 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Thu Nov 19 10:40:09 2015 +0100 URL: http://code.openbravo.com/retail/backports/3.0RR15Q3.3/org.openbravo.retail.posterminal/rev/88deb600cc7ab96a2a6209513de2862aadd8dc92 [^] Related to issue 31390: infinite loop with discounts of type "Buy X pay Y of different products It's necessary to set applyPromotions to false when setting the order type. If not, calculateGross is never execute. --- M web/org.openbravo.retail.posterminal/js/model/order.js M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js --- |
|
(0082312) hgbot (developer) 2015-11-25 08:42 |
Repository: retail/backports/3.0RR15Q3.3/org.openbravo.retail.posterminal Changeset: 2b3dcd5c13acc99d5e0f2bbef7960a779d1f4386 Author: Jorge Garcia <jorge.garcia <at> openbravo.com> Date: Tue Nov 24 17:26:22 2015 +0100 URL: http://code.openbravo.com/retail/backports/3.0RR15Q3.3/org.openbravo.retail.posterminal/rev/2b3dcd5c13acc99d5e0f2bbef7960a779d1f4386 [^] Related to issue 31390: infinite loop with discounts of type "Buy X pay Y of different product Need to add a receipt.calculateGross --- M web/org.openbravo.retail.posterminal/js/model/order.js --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-11-06 11:01 | jorge-garcia | Type | defect => backport |
| 2015-11-06 11:01 | jorge-garcia | Target Version | => RR15Q3.3 |
| 2015-11-06 11:10 | jorge-garcia | Relationship added | has duplicate 0029522 |
| 2015-11-25 08:42 | hgbot | Checkin | |
| 2015-11-25 08:42 | hgbot | Note Added: 0082310 | |
| 2015-11-25 08:42 | hgbot | Status | scheduled => resolved |
| 2015-11-25 08:42 | hgbot | Resolution | open => fixed |
| 2015-11-25 08:42 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/92e150fb18152d7831b7cfbe74329e5582a0eaf9 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q3.3/org.openbravo.retail.posterminal/rev/72d3ee12d66bfa9e30986477eaeecd3ce8334d0a [^] |
| 2015-11-25 08:42 | hgbot | Checkin | |
| 2015-11-25 08:42 | hgbot | Note Added: 0082311 | |
| 2015-11-25 08:42 | hgbot | Checkin | |
| 2015-11-25 08:42 | hgbot | Note Added: 0082312 | |
| 2015-12-03 18:01 | guilleaer | Review Assigned To | marvintm => guilleaer |
| 2015-12-03 18:01 | guilleaer | Status | resolved => closed |
| 2015-12-03 18:01 | guilleaer | Fixed in Version | => RR15Q3.3 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |