Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0031373

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Openbravo ERP] A. Platform

major

have not tried

2015-11-05 12:35

2015-11-23 21:17

Reporter

alostale

View Status

public

Assigned To

alostale

Priority

urgent

Resolution

fixed

Fixed in Version

3.0PR16Q1

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

dbaz

Web browser

Modules

Core

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0031373: UI frozen if calendar data request fails

Description

If there is a server error when fetching data for a calendar, infinite requests to calendar datasource are performed and the UI gets locked with a popup showing the error message.

Steps To Reproduce

1. Install the Resources and Reservations Management module
2. Apply attached patch (which fakes an error in backend)

or alternatively:

1.a. Install Resource and Reservation Management module version 1.0.21

---

3. Add the Resource Reservation widget to the workspace
   * Error popup appear
         -> OK: as datasource is expected to fail
   * This popup can't be closed
         -> ERROR: it should be possible to close it, as other ways it freezes all the UI
   * In dev tools infinite requests to calendar datasource can be seen
         -> ERROR: this is the cause the popup can't be closed: a new popup is displayed for each request.

Proposed Solution

When request fails, don't try to execute it once and again.

Tags

No tags attached.

calendar-fails.diff [^] (788 bytes) 2015-11-05 12:41 [Show Content] [Hide Content]

diff -r 6f147580f5cc src/org/openbravo/module/resources/calendar/ResourcesCalendarDataService.java
--- a/src/org/openbravo/module/resources/calendar/ResourcesCalendarDataService.java	Thu Nov 05 09:58:43 2015 +0100
+++ b/src/org/openbravo/module/resources/calendar/ResourcesCalendarDataService.java	Thu Nov 05 12:41:12 2015 +0100
@@ -56,6 +56,9 @@
   @Override
   protected List<BaseOBObject> bobFetchTransformation(List<BaseOBObject> bobs,
       Map<String, String> parameters) {
+    if (true) {
+      throw new java.lang.RuntimeException("something went wrong!!");
+    }
     List<BaseOBObject> newBobs = bobs;
     newBobs = ReservationUtilities.splitReservationInAvailableHours(newBobs, parameters);
     newBobs = ReservationUtilities.splitReservationInDays(newBobs, parameters);

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

closed

Modules

Resource Reservation widget is not working in 3.0PR15Q3, it blocks the application

Notes
(0081517) hgbot (developer) 2015-11-05 12:40	Repository: erp/devel/pi Changeset: db630f824809fccbdfcbc8e13c398b77098d4a05 Author: Asier Lostalé <asier.lostale <at> openbravo.com> Date: Thu Nov 05 12:40:18 2015 +0100 URL: http://code.openbravo.com/erp/devel/pi/rev/db630f824809fccbdfcbc8e13c398b77098d4a05 [^] fixed bug 31373: UI frozen if calendar data request fails When a request to calendar datasource fails, don't try to execute it again as it most probably, will continue failing. --- M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/calendar/ob-calendar.js ---

(0081913) dbaz (developer) 2015-11-17 09:58	Reviewed @ changeset: 27897 - ecf5c6932ff2

(0082179) hudsonbot (developer) 2015-11-23 21:17	A changeset related to this issue has been promoted main and to the Central Repository, after passing a series of tests. Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^] Maturity status: Test

Issue History
Date Modified	Username	Field	Change
2015-11-05 12:35	alostale	New Issue
2015-11-05 12:35	alostale	Assigned To	=> platform
2015-11-05 12:35	alostale	Modules	=> Core
2015-11-05 12:35	alostale	Triggers an Emergency Pack	=> No
2015-11-05 12:36	alostale	Relationship added	related to 0031358
2015-11-05 12:36	alostale	Status	new => scheduled
2015-11-05 12:36	alostale	Assigned To	platform => alostale
2015-11-05 12:36	alostale	Review Assigned To	=> dbaz
2015-11-05 12:36	alostale	Proposed Solution updated
2015-11-05 12:40	hgbot	Checkin
2015-11-05 12:40	hgbot	Note Added: 0081517
2015-11-05 12:40	hgbot	Status	scheduled => resolved
2015-11-05 12:40	hgbot	Resolution	open => fixed
2015-11-05 12:40	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/devel/pi/rev/db630f824809fccbdfcbc8e13c398b77098d4a05 [^]
2015-11-05 12:41	alostale	File Added: calendar-fails.diff
2015-11-17 09:58	dbaz	Note Added: 0081913
2015-11-17 09:58	dbaz	Status	resolved => closed
2015-11-17 09:58	dbaz	Fixed in Version	=> 3.0PR16Q1
2015-11-23 21:17	hudsonbot	Checkin
2015-11-23 21:17	hudsonbot	Note Added: 0082179

Copyright © 2000 - 2009 MantisBT Group